-
Notifications
You must be signed in to change notification settings - Fork 6
Saralyn's pull request for Code Review Activity #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SaralynOgden
wants to merge
1
commit into
main
Choose a base branch
from
Saralyn_Ogden_CodeReview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,97 @@ | ||
| public class StringManipulation implements StringManipulationInterface { | ||
| private String string; | ||
|
|
||
| @Override | ||
| public String getString() { | ||
| return null; | ||
| return string; | ||
| } | ||
|
|
||
| @Override | ||
| public void setString(String string) { | ||
| this.string = string; | ||
| } | ||
|
|
||
| @Override | ||
| public int count() { | ||
| return 0; | ||
| String[] preFilteredResult = string.split(" "); | ||
| int count = 0; | ||
|
|
||
| for (String result : preFilteredResult) { | ||
| if (!result.isEmpty()) { | ||
| count++; | ||
| } | ||
| } | ||
|
|
||
| return count; | ||
| } | ||
|
|
||
| @Override | ||
| public String removeNthCharacter(int n, boolean maintainSpacing) { | ||
| return null; | ||
| if (n <= 0) { | ||
| throw new IllegalArgumentException(); | ||
| } else if (n > string.length()) { | ||
| throw new IndexOutOfBoundsException(); | ||
| } | ||
|
|
||
| StringBuilder stringBuilder = new StringBuilder(); | ||
|
|
||
| for (int i = 0; i < string.length(); i++) { | ||
| if ((i + 1) % n == 0) { | ||
| if (maintainSpacing) { | ||
| stringBuilder.append(" "); | ||
| } | ||
| } else { | ||
| stringBuilder.append(string.charAt(i)); | ||
| } | ||
| } | ||
|
|
||
| return stringBuilder.toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public String[] getSubStrings(int startWord, int endWord) { | ||
| return null; | ||
| public String[] getSubStrings(int startWord, int endWord){ | ||
| if (startWord <= 0 || endWord <= 0 || startWord > endWord) { | ||
| throw new IllegalArgumentException(); | ||
| } | ||
|
|
||
| String[] preFilteredResult = string.split(" "); | ||
| String[] substrings = new String[endWord - startWord + 1]; | ||
| int wordCount = 1; | ||
| int substringsIndex = 0; | ||
|
|
||
| for (String result : preFilteredResult) { | ||
| if (!result.isEmpty()) { | ||
| if (wordCount >= startWord && wordCount <= endWord) { | ||
| substrings[substringsIndex] = result; | ||
| substringsIndex++; | ||
| } | ||
| wordCount++; | ||
| } | ||
| } | ||
|
|
||
| if (wordCount < endWord) { | ||
| throw new IndexOutOfBoundsException(); | ||
| } | ||
|
|
||
| return substrings; | ||
| } | ||
|
|
||
| @Override | ||
| public String restoreString(int[] indices) { | ||
| return null; | ||
| } | ||
| public String restoreString(int[] indices){ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider adding more descriptive object names to enhance readability |
||
| if (indices.length != string.length()) { | ||
| throw new IllegalArgumentException(); | ||
| } | ||
|
|
||
| String[] restoredStringArray = new String[indices.length]; | ||
|
|
||
| for (int i = 0; i < indices.length; i++) { | ||
| int oldIndex = indices[i]; | ||
| if (oldIndex < 0 || oldIndex >= string.length()) { | ||
| throw new IndexOutOfBoundsException(); | ||
| } | ||
| restoredStringArray[i] = String.valueOf(string.charAt(oldIndex)); | ||
| } | ||
|
|
||
| return String.join("", restoredStringArray); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changing .append to .deleteCharAt() could add some optimization by possibly avoiding creating a new string for each character removal