-
Notifications
You must be signed in to change notification settings - Fork 6
added implementation from unit test assignment #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lrassbach
wants to merge
4
commits into
main
Choose a base branch
from
Lucas_Rassbach_CodeReview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| language: java | ||
| jdk: openjdk17 | ||
| jdk: openjdk19 | ||
| jobs: | ||
| include: | ||
| - script: mvn clean verify package | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,179 @@ | ||
| public class StringManipulation implements StringManipulationInterface { | ||
|
|
||
| String myString; | ||
| @Override | ||
| public String getString() { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public void setString(String string) { | ||
| this.myString = string; | ||
| } | ||
|
|
||
| @Override | ||
| public int count() { | ||
| return 0; | ||
| int tally = 0; | ||
| if(myString == null || myString.length() == 0){ | ||
| return tally; | ||
| } | ||
| // " here is a string" 4 | ||
| // "a here is a string" 4 | ||
| // "a " 1 | ||
| // "here" 1 | ||
| for (int i = 0; i < myString.length(); i++){ | ||
| char currentChar = myString.charAt(i); | ||
| if(currentChar != ' '){ | ||
| tally++; | ||
| while(currentChar != ' '){ | ||
| i++; | ||
| if(i >= myString.length()){ | ||
| break; | ||
| } | ||
| currentChar = myString.charAt(i); | ||
| } | ||
| } | ||
| while (currentChar == ' '){ | ||
| i++; | ||
| if(i >= myString.length()){ | ||
| break; | ||
| } | ||
| currentChar = myString.charAt(i); | ||
| } | ||
|
|
||
|
|
||
| } | ||
| return tally; | ||
| } | ||
|
|
||
| @Override | ||
| // n = 3; aaabbbaaaccc -> aabbaacc | ||
| // | ||
| public String removeNthCharacter(int n, boolean maintainSpacing) { | ||
| return null; | ||
| if(n <= 0){ | ||
| throw new IllegalArgumentException("n must be greater than or equal to 0"); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe give a message on my it throws and error. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just realized that it does have a message in it. |
||
| } | ||
| else if (n > myString.length()){ | ||
| throw new IndexOutOfBoundsException(n); | ||
| } | ||
| String buildString = ""; | ||
| if (maintainSpacing) { | ||
| if (n == 1){ | ||
| for (int i = 0; i < myString.length(); i++){ | ||
| buildString += " "; | ||
| } | ||
| return buildString; | ||
| } | ||
| int prior = 0; | ||
| for(int i = 0; i < myString.length(); i++){ | ||
| if ((i+1) % n == 0){ | ||
| String slice = myString.substring(prior, i); | ||
| buildString += slice; | ||
| buildString += " "; | ||
| prior = i + 1; | ||
| } | ||
| if (i == myString.length() - 1 && myString.length() % n != 0){ | ||
| String slice = myString.substring(prior); | ||
| buildString += slice; | ||
| } | ||
| } | ||
| } | ||
| else { | ||
| // todo need to update criteria for n == 1 | ||
| if (n == 1){ | ||
| return buildString; | ||
| } | ||
| int prior = 0; | ||
| for(int i = 0; i < myString.length(); i++){ | ||
| if ((i+1) % n == 0){ | ||
| String slice = myString.substring(prior, i); | ||
| buildString += slice; | ||
| prior = i + 1; | ||
| } | ||
| if (i == myString.length() - 1 && myString.length() % n != 0){ | ||
| String slice = myString.substring(prior); | ||
| buildString += slice; | ||
| } | ||
| } | ||
| } | ||
| return buildString; | ||
| } | ||
|
|
||
| @Override | ||
| public String[] getSubStrings(int startWord, int endWord) { | ||
| return null; | ||
| public String[] getSubStrings(int startWord, int endWord){ | ||
| if (startWord <= 0 || endWord <= 0 || endWord < startWord){ | ||
| throw new IllegalArgumentException(); | ||
| } | ||
| int numWords = this.count(); | ||
| if (endWord > numWords){ | ||
| throw new IndexOutOfBoundsException(endWord); | ||
| } | ||
| String[] array = new String[1 + endWord - startWord]; | ||
| for (int i = 0; i < array.length; i++){ | ||
| array[i] = null; | ||
| } | ||
| int arrayPosition = 0; | ||
| int wordCount = 0; | ||
| while(array[array.length - 1] == null){ | ||
| char firstChar = myString.charAt(0); | ||
| for (int i = 0; i < myString.length(); i++){ | ||
| char currentChar = myString.charAt(i); | ||
| while (currentChar == ' '){ | ||
| i++; | ||
| if(i >= myString.length()){ | ||
| return array; | ||
| } | ||
| currentChar = myString.charAt(i); | ||
| } | ||
| String currentWord = ""; | ||
| while(currentChar != ' '){ | ||
| i++; | ||
| currentWord += String.valueOf(currentChar); | ||
| if(i == myString.length()){ | ||
| array[arrayPosition] = currentWord; | ||
| return array; | ||
| } | ||
| currentChar = myString.charAt(i); | ||
| } | ||
| wordCount++; | ||
| if(wordCount >= startWord){ | ||
| array[arrayPosition] = currentWord; | ||
| arrayPosition++; | ||
| } | ||
| if (arrayPosition >= array.length){ | ||
| return array; | ||
| } | ||
| } | ||
| } | ||
| return array; | ||
| } | ||
|
|
||
| @Override | ||
| public String restoreString(int[] indices) { | ||
| return null; | ||
| public String restoreString(int[] indices){ | ||
| if(indices.length != myString.length()){ | ||
| throw new IllegalArgumentException(); | ||
| } | ||
| else { | ||
| for (int i = 0; i < indices.length; i++){ | ||
| int num = indices[i]; | ||
| if(num > myString.length() - 1 || num < 0){ | ||
| throw new IndexOutOfBoundsException(i); | ||
| } | ||
| } | ||
| } | ||
| String convString = ""; | ||
| String[] arrayString = new String[myString.length()]; | ||
| String[] converted = new String[myString.length()]; | ||
| for(int i = 0; i < myString.length(); i++){ | ||
| String currentLetter = String.valueOf(myString.charAt(i)); | ||
| arrayString[i] = currentLetter; | ||
| } | ||
| for(int i = 0; i < myString.length(); i++){ | ||
| int index = indices[i]; | ||
| converted[i] = arrayString[index]; | ||
| } | ||
| for (int i = 0; i < myString.length(); i++){ | ||
| convString += converted[i]; | ||
| } | ||
| return convString; | ||
| } | ||
|
|
||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this can be shorter for counting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate?