-
Notifications
You must be signed in to change notification settings - Fork 6
Added my code of #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IgorJanGit
wants to merge
3
commits into
main
Choose a base branch
from
IgorJanottiCodeReview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,128 @@ | ||
| public class StringManipulation implements StringManipulationInterface { | ||
|
|
||
| private String _string; | ||
|
|
||
| @Override | ||
| public String getString() { | ||
| return null; | ||
| return _string; | ||
| } | ||
|
|
||
| @Override | ||
| public void setString(String string) { | ||
| _string = string; | ||
| } | ||
|
|
||
| @Override | ||
| public int count() { | ||
| return 0; | ||
|
|
||
| String string = getString(); | ||
| if (string.isBlank()){ | ||
| return 0; | ||
| } | ||
| String[] words = string.split("\\s+"); | ||
| return words.length; | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public String removeNthCharacter(int n, boolean maintainSpacing) { | ||
| return null; | ||
| String string = getString(); | ||
| StringBuilder result = new StringBuilder(); | ||
|
|
||
| // exception throw IndexOutOfBoundsException | ||
| if (n > string.length()) { | ||
| throw new IndexOutOfBoundsException("n is more then string "); | ||
| } | ||
| // exception throw IllegalArgumentException | ||
| if (n <= 0) { | ||
| throw new IllegalArgumentException("n is less then or equal to zero"); | ||
| } | ||
|
|
||
| int target_n = n; | ||
| for (int i = 0; i < string.length(); i++) { | ||
|
|
||
| // gets character | ||
| char c = string.charAt(i); | ||
|
|
||
| // if i is not equal to n then it add charter | ||
| if (i != target_n-1) { | ||
| result.append(c); | ||
|
|
||
| } | ||
| else { | ||
| if(maintainSpacing) { | ||
|
|
||
| result.append(' '); | ||
|
|
||
| } | ||
| target_n += n; | ||
| } | ||
|
|
||
|
|
||
| } | ||
| return result.toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public String[] getSubStrings(int startWord, int endWord) { | ||
| return null; | ||
| // get number of words | ||
| int numberOfWords = count(); | ||
| String string = getString(); | ||
| String[] words = string.split("\\s+"); | ||
|
|
||
|
|
||
| // exception throw IndexOutOfBoundsException | ||
|
|
||
| if (numberOfWords < endWord) { | ||
| throw new IndexOutOfBoundsException("string has less then endword "); | ||
| } | ||
| // exception throw IllegalArgumentException | ||
|
|
||
| if (startWord <= 0 || endWord <= 0 || startWord > endWord) { | ||
| throw new IllegalArgumentException("startword or endword is invalid "); | ||
| } | ||
|
|
||
| String[] substrings = new String[endWord - startWord + 1]; | ||
|
|
||
| int count = 0; | ||
| for (int i = startWord-1; i <= endWord-1;i++){ | ||
| substrings[count] = words[i]; | ||
| count++; | ||
| } | ||
| return substrings; | ||
| } | ||
|
|
||
| @Override | ||
| public String restoreString(int[] indices) { | ||
| return null; | ||
| } | ||
| String string = getString(); | ||
| int stringSize = string.length(); | ||
|
|
||
| System.out.println("The count is: " + stringSize+ "indices.length = "+indices.length); | ||
|
|
||
|
|
||
| // exception throw IllegalArgumentException | ||
|
|
||
| if (stringSize != indices.length ) { | ||
| throw new IllegalArgumentException("length of indices does not match string length "); | ||
| } | ||
|
|
||
|
|
||
|
|
||
| char[] stringOutPut = new char[indices.length]; | ||
|
|
||
| for (int i = 0; i < stringSize; i++) { | ||
| int index = indices[i]; | ||
|
|
||
|
|
||
| // exception throw IndexOutOfBoundsException | ||
| //indices.length | ||
| if (index < 0 || index >= stringSize) { | ||
| throw new IndexOutOfBoundsException("string has less then endword "); | ||
| } | ||
|
|
||
| stringOutPut[i] = string.charAt(index); | ||
|
|
||
| } | ||
| return new String(stringOutPut); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make sure that if there's an empty sting it will return a 0 you can add a if statement to it so that if the string is empty it will return 0 (using methods like isEmpty())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4c58815 here git commit i did to fix the issue