Skip to content

Update call implementation and custom ringtones#841

Open
7w1 wants to merge 45 commits into
devfrom
refactor-calls
Open

Update call implementation and custom ringtones#841
7w1 wants to merge 45 commits into
devfrom
refactor-calls

Conversation

@7w1

@7w1 7w1 commented May 14, 2026

Copy link
Copy Markdown
Member

Description

Attempts to match spec notification/call end/join behaviors a little better.
Adds an option for custom ringtones and ringbacks.
Adds permissions for calls.
Makes it so when you leave calls they don't instantly end
Makes it so calls are properly declined
Makes it so when a call is declined you don't automatically hang up
Includes updated sablecall
Removes the call controls from the call view and instead injects styles to modify the widget appearance. For whatever reason font isn't working quite yet, although it works locally :/
Adds some tests for things.
Fixes #857
Fixes #855
Fixes #691
Might address #898, #908 (needs testing)

Still todo:

  • update changesets again
  • figure out how to style the call room backgrounds properly
  • inject twemoji font (or put in sable call?)
  • add phosphor icons to sable call?
  • add deafen button to sable call
  • fix odd ringtone looping behavior
  • more testing
  • Some file cleanup of some no longer necessary stuff due to removing the call ui overlay thing

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

Tests were AI generated and AI was used to compare some other call implementations and ensure spec and standard compliance and to figure out how to inject the sable theme into all the widget elements.

Comment thread src/app/features/call/callRingtone.ts Fixed
Comment thread src/app/features/call/callRingtone.ts Dismissed
@github-actions

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-841-sable.raspy-dream-bb1d.workers.dev 2e5fd52 pr-841 Sun, 28 Jun 2026 05:51:04 GMT

@7w1 7w1 marked this pull request as ready for review June 28, 2026 06:02
@7w1 7w1 requested a review from hazre as a code owner June 28, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants