Update call implementation and custom ringtones#841
Open
7w1 wants to merge 45 commits into
Open
Conversation
had to ai this one ngl
# Conflicts: # src/app/components/message/content/ImageContent.tsx
…tor-calls # Conflicts: # src/app/components/IncomingCallModal.tsx # src/app/features/room/RoomCallButton.tsx # src/app/state/settings.defaults.test.ts
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-841-sable.raspy-dream-bb1d.workers.dev | 2e5fd52 | pr-841 |
Sun, 28 Jun 2026 05:51:04 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attempts to match spec notification/call end/join behaviors a little better.
Adds an option for custom ringtones and ringbacks.
Adds permissions for calls.
Makes it so when you leave calls they don't instantly end
Makes it so calls are properly declined
Makes it so when a call is declined you don't automatically hang up
Includes updated sablecall
Removes the call controls from the call view and instead injects styles to modify the widget appearance. For whatever reason font isn't working quite yet, although it works locally :/
Adds some tests for things.
Fixes #857
Fixes #855
Fixes #691
Might address #898, #908 (needs testing)
Still todo:
Type of change
Checklist:
AI disclosure:
Tests were AI generated and AI was used to compare some other call implementations and ensure spec and standard compliance and to figure out how to inject the sable theme into all the widget elements.