Bring SableCall Up-to-Date With ElementCall Upstream#12
Merged
Conversation
* Add Posthog events for Call reconnect including the reason * Expose single trackCallReconnecting() entry point on PosthogAnalytics * Track reconnect duration and align with existing analytics pattern * Refactor combined$ to return [connected, reason] tuple * Update firefoxUserPrefs to allow getUserMedia and enumerateDevices on CI --------- Co-authored-by: Valere <bill.carson@valrsoft.com> Co-authored-by: Robin <robin@robin.town> Co-authored-by: Timo K <toger5@hotmail.de>
Update dependency @vector-im/compound-design-tokens to v10.1.1
…tions Update GitHub Actions
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Minor README fixes
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
…fixes Minor documentation fixes
Create a proper one-on-one call layout for portrait screens
…lient Update dependency livekit-client to v2.18.10
Add PiP border in 1on1 layouts
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Switch from eslint to oxlint
…call_to_earpiece fix(voice): Default to earpiece for voice only call
To match the designs. Just like in portrait, it wouldn't contribute anything meaningful.
Hide local tile from mobile voice calls in landscape orientation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3 # v5.3.1 | ||
| with: | ||
| flags: unittests | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
| # zizmor: ignore[unfenced-secrets] | ||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3 # v5.3.1 | ||
| if: ${{ secrets.CODECOV_TOKEN != '' }} |
Member
|
I have it mostly working with Sable now in the related PR there, I think everything here is working so I'm gonna merge and release a version to hopefully get it fully integrated and updated in Sable. Might have a few more small PRs later to clean things up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Pulling in changes from element-hq/element-call:livekit upstream branch to bring SableCall up to date.
Utilized the assistance of AI to review merge conflicts due to a lack of familiarity of some Sable specific changes vs element-call. Removed GitHub workflow files introduced by upstream as SableCall has its own set of GitHub Workflow build yaml.
Merge conflicts were resolved within:
playwright/spa-call-sticky.spec.tssrc/Avatar.test.tsxsrc/Avatar.tsxsrc/ClientContext.tsxsrc/settings/useSubmitRageshake.test.tsxsrc/state/CallViewModel/CallViewModel.tssrc/widget.tsMotivation and context
Features that have been added to element-call have been sought after, in particular the removal of noise suppression in screen share audio: Sable Issue 857