-
Notifications
You must be signed in to change notification settings - Fork 76
[SYNPY-1851] Add high level function for creating grids #1423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrewelamb
wants to merge
22
commits into
develop
Choose a base branch
from
SYNPY-1851
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1ece9d3
added get grid endpoint and method
andrewelamb 2767cc6
added get grid endpoint and method
andrewelamb c72ea4a
add new high level function for creating grids
andrewelamb 3d52d8c
removetry/except blocks
andrewelamb b14f9b6
updated docs to use new function
andrewelamb 88589df
rename file
andrewelamb 0bf43d2
revert doc file
andrewelamb 7abf9a4
fix bug when task has no execution details
andrewelamb d397d90
added use-case where thr taks points to a Grid that no longer exists
andrewelamb 98e6f41
update doc to use new function
andrewelamb 1e920bf
fix docstring
andrewelamb 1fa90df
Merge branch 'develop' into SYNPY-1851
andrewelamb 92fff26
Merge branch 'develop' into SYNPY-1851
andrewelamb c98a005
Merge branch 'develop' into SYNPY-1851
andrewelamb 2f0507b
renamed function
andrewelamb 80a7155
fix bug in doc example
andrewelamb db3e6c9
Merge branch 'develop' into SYNPY-1851
andrewelamb 305c5bd
Merge branch 'develop' into SYNPY-1851
andrewelamb 30651df
Merge branch 'develop' into SYNPY-1851
andrewelamb 9f5a01a
removed logging messaging
andrewelamb 35ee9eb
added async verison of function
andrewelamb a134177
moved mock client to conftest
andrewelamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,6 +62,7 @@ | |
| inherited_members: true | ||
| members: | ||
| - create | ||
| - get | ||
| - export_to_record_set | ||
| - synchronize | ||
| - download_csv | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think it's very easy to forget unlinking the grid and the task. What about creating something like
CurationTask.delete_active_grid_session_async()that deletes the Grid and clears the link in one coordinated call in the future?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cconrad8 What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative is to make
get_or_create_curator_grida context manager that handled this automatically with a boolean flag to not clean up.That way in the finally you can handle this for the user (The following is not correct code, but just mocking up what it roughly looks like).