-
Notifications
You must be signed in to change notification settings - Fork 76
[SYNPY-1880] feat: added per row validation to Grid data class #1428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
linglp
wants to merge
29
commits into
develop
Choose a base branch
from
SYNPY-1880-clean
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
8f98d13
add all dataclasses and tests
linglp 78ec656
fix docstring
linglp 879a2c8
added create replica endpoint, dataclasses, updated documentation
linglp b7d80dd
add test for create replica data classes and add add a unit test of c…
linglp df9d8bd
if nothing returned, then it should raise error
linglp bdf168c
raise an error if query_request is none when querying the grid
linglp 9ff1bad
update documentation; export filter and column selection data classes…
linglp 3f6f584
add the connect method
linglp 146ac3c
add connect to documentation
linglp 050a448
restore thing
linglp 16ac436
when no validation result returned, it should not raise an error
linglp 224ddd4
added otel trace method
linglp a5ea43d
update docstring
linglp 8fb46ce
add test
linglp 6449b72
make sure that GridQuery does not allow empty column selection
linglp d07551b
make create replica a private method
linglp 028b57a
update docstring
linglp cf7b2d4
remove fill_from_dict in selectItem classes and filter classes; edit …
linglp 67a045f
update import; docstring example; and documentation
linglp efacbfe
Merge branch 'develop' into SYNPY-1880-clean
linglp 17cb35e
update to reference the grid previously created
linglp 3b81365
query result should be returned instead of none when there is no row
linglp b853a52
add to grid class docstring
linglp 2c81990
update docstring example to avoid recreating another grid instance
linglp 990fac7
added integration tests
linglp 740c76d
update docstring
linglp 056e25c
add import back
linglp 8518dce
add comment
linglp ee55485
Merge branch 'develop' into SYNPY-1880-clean
linglp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we determined this limit doesn't exist?