Skip to content

[scolv] make eventedit.scripts.column.* work#203

Open
luca-s wants to merge 1 commit into
SeisComP:mainfrom
luca-s:patch-2
Open

[scolv] make eventedit.scripts.column.* work#203
luca-s wants to merge 1 commit into
SeisComP:mainfrom
luca-s:patch-2

Conversation

@luca-s

@luca-s luca-s commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Currently the special values added by eventedit.scripts.column.* are never visualized on the event edit tab of scolv

Currently the special values added by eventedit.scripts.column.* are never visualized on the event edit tab of scolv
@cla-bot cla-bot Bot added the cla-signed The CLA has been signed by all contributors label Jul 23, 2026
@luca-s luca-s changed the title [scolv] make eventedit.origin.customColumn.* work [scolv] make eventedit.scripts.column.* work Jul 23, 2026
@luca-s

luca-s commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Just to provide more context, the issue was in PublicObjectEvaluator, which was failing to load origins from the database because the required RTTI was missing from job.classType. Instead, a string was passed. This PR fixes that issue.

Interestingly, if the user had the same scripts configured in the event list tab, the special columns in the event edit tab would still be populated for the currently selected origin (and only that row). This happened because the EventEdit::evalResultAvailable callback was triggered by the PublicObjectEvaluator instance used by the event list tab. In that code path, the correct RTTI information was passed, so the evaluation completed successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed by all contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant