Fix impl publish: add syn printing feature, bump to 11.4.1 - #27
Merged
Conversation
impl/src/lib.rs uses syn::Error::new_spanned (added in #21), which needs the ToTokens trait from syn's "printing" feature. impl/Cargo.toml sets default-features = false without it, so the crate fails to compile when built in isolation — which is exactly what cargo publish's verification step does. The workspace test build passed only because feature unification pulled "printing" in via another crate. utils 11.4.0 already published before impl failed, so bump all crates to 11.4.1 to re-release cleanly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
=======================================
Coverage 75.97% 75.97%
=======================================
Files 9 9
Lines 566 566
=======================================
Hits 430 430
Misses 136 136 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
The 11.4.0 release workflow published
rust-embed-for-web-utils11.4.0 to crates.io, then failed publishingrust-embed-for-web-impl:Root cause
impl/src/lib.rsusessyn::Error::new_spanned(added in #21). That function requires theToTokenstrait, which lives behind syn'sprintingfeature.impl/Cargo.tomlsetsdefault-features = falseand never enabledprinting. The workspace test job passes because Cargo feature unification pullsprintingin via another crate, butcargo publishverifies the crate in isolation, where the feature is absent.Fix
printingfeature on syn inimpl/Cargo.toml. Verified withcargo publish --dry-runonimplin isolation.After merge, re-trigger the
releaseworkflow.