Ajout des Evenement Journalier (Pêche Miraculeuse) - Part 1/3#1319
Merged
Conversation
iambibi
changed the title
Member
Author
|
en attente de #1318 |
# Conflicts: # src/main/java/fr/openmc/core/features/events/commands/calendar/CalendarMenu.java
…melines? no it's biome
iambibi
added
the
🔥Urgent
Member
Author
|
Label urgent appliqué, besoin de ceci pour avancer dans les événements journalier, vous avez tous voulu que je fasse plusieurs PR pour les évènements journalier maintenant faut vite review |
AxenoDev
previously approved these changes
Jul 1, 2026
Member
Author
|
c'est a merge ou tu att qlq d'autres? |
Member
Author
|
je resolve ça apres manger |
# Conflicts: # src/main/java/fr/openmc/core/features/dream/mecanism/rng/DreamRngLootManager.java # src/main/java/fr/openmc/core/features/dream/milestone/quests/MudOrbQuest.java # src/main/java/fr/openmc/core/features/dream/registries/mobs/CrazyFrog.java # src/main/resources/translations/default/dream.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petit résumé de la PR:
Étape nécessaire afin que la PR soit fini (si PR en draft)
Suivre le Code de Conduite
Enlever tous les imports non utilisés
Bien documenter la feature SOYEZ EXIGEANT PLS (j'en ai pas mis volontairement sur certaines méthodes que je trouvais peu utile)
Fournir un profileur (si besoin/demandé par un admin) :
https://spark.lucko.me/KFTbhQjYdq lancement + peche
https://spark.lucko.me/ou5GXTPTYO kraken
Avoir une milestone associée à la PR
Valider tout les checks
Tester et valider la feature/changement
Decrivez vos changements