[Security] Harden client ID generation in ExtensionServerClient#7957
[Security] Harden client ID generation in ExtensionServerClient#7957gonzaloriestra wants to merge 1 commit into
Conversation
Replace insecure Math.random() with globalThis.crypto.randomUUID() for generating client IDs. Included fallback for environments without Web Crypto API and added regression tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
ExtensionServerClientwas usingMath.random()for ID generation, which is not cryptographically secure and can lead to predictable identifiers.WHAT is this pull request doing?
This PR hardens the client ID generation by using
globalThis.crypto.randomUUID()(CSPRNG) when available. It maintains a fallback to the originalMath.random()logic for compatibility with environments that do not support the Web Crypto API.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 4903850465924769794 started by @gonzaloriestra