[Performance] Memoize getPackageManager result#7959
Conversation
This optimization memoizes the result of the `getPackageManager` function per directory. Since the package manager for a project is unlikely to change during the execution of a single CLI command, this significantly reduces redundant recursive filesystem lookups when the function is called multiple times for the same path. Expected impact: - Reduced filesystem I/O operations for package manager detection. - Faster execution in monorepos or scenarios where many packages are processed sequentially. - Measurable performance improvement in high-frequency call paths. Implemented with a module-level `Map` using normalized paths as keys. Added `_resetPackageManagerCache` for test isolation and verified with unit tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/node-package-manager.d.ts@@ -58,6 +58,11 @@ export declare class FindUpAndReadPackageJsonNotFoundError extends BugError {
* @returns The dependency manager
*/
export declare function packageManagerFromUserAgent(env?: NodeJS.ProcessEnv): PackageManager;
+/**
+ * Resets the memoized package manager cache.
+ * This is useful for unit tests.
+ */
+export declare function _resetPackageManagerCache(): void;
/**
* Returns the dependency manager used in a directory.
* Walks upward from so workspace packages (e.g. )
|
1 participant
Why is this change necessary?
The
getPackageManagerfunction performs a recursive filesystem traversal to find a lockfile, which can be expensive when called repeatedly in deep directory structures or monorepos.How to test your changes?
CI
Post-deployment tasks
None
PR created automatically by Jules for task 14151923874589541598 started by @gonzaloriestra