[Refactor] Modernize errorHandler in cli-kit#7960
Conversation
Modernize the errorHandler function by replacing Promise chains with async/await and using early returns to reduce nesting. Also updated associated tests to improve mocking and coverage.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
errorHandlerfunction in@shopify/cli-kitused a nested.then()promise chain and complexif/else if/elsenesting, which made it harder to read and maintain than modernasync/awaitpatterns.WHAT is this pull request doing?
errorHandlerinpackages/cli-kit/src/public/node/error-handler.tsto useasync/await.packages/cli-kit/src/public/node/error-handler.test.tsto verify generic error handling.@oclif/coremock in tests to preserve original exports while overriding settings.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 5284855694113462077 started by @gonzaloriestra