Run E2E app cleanup after shards finish#7962
Merged
Merged
Conversation
github-actions
Bot
added
the
no-changelog
alfonso-noriega
force-pushed
the
06-30-e2e_cleanup_reuse_auth
branch
from
4b3369e to
cb7a258
Compare
alfonso-noriega
force-pushed
the
06-30-e2e_cleanup_single_job
branch
from
a4baec4 to
44cd07a
Compare
isaacroldan
approved these changes
Jun 30, 2026
alfonso-noriega
force-pushed
the
06-30-e2e_cleanup_single_job
branch
from
44cd07a to
4107341
Compare
Assisted-By: devx/56dcddb4-0bb1-4e96-b794-1bb2fda2cba1
alfonso-noriega
force-pushed
the
06-30-e2e_cleanup_single_job
branch
from
4107341 to
cc05d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The current E2E cleanup step runs once per shard. That creates concurrent cleanup browser sessions for the same run token, and one shard can start cleanup while the other shard is still creating apps.
WHAT is this pull request doing?
continue-on-error, but prevents duplicate/concurrent cleanup runs for the same CI run.Stacked on #7961.
How to test your changes?
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/tests-pr.yml"); puts "YAML OK"'