test(ui): cover masked/mono/dl on AddressDisplay, add Separator suite, SkeletonCard custom header & SkeletonRow count (#338) - #384
Open
RUKAYAT-CODER wants to merge 1 commit into
Conversation
…, SkeletonCard custom header & SkeletonRow count (Sorokit#338) Adds Vitest coverage for the alternative layouts flagged in Sorokit#338: - AddressDisplay: masked produces a 4-prefix + 3 middot + 4-suffix string shorter than the source; mono adds font-mono; when label is set the markup is a <dl><dt>{label}</dt><dd>{addressSpan}</dd></dl>, no <dl> when label is omitted. - Separator (new test file): role=separator on both orientations; aria-orientation=vertical and w-px h-full for vertical; labeled renders the label inline between the two horizontal lines; unlabeled renders only h-px bg-line; spacing=sm|md|lg maps to my-2|my-4|my-6; forwarded className lands on the root. - Skeleton: SkeletonCard renders the structure prop wholesale in place of the default header + rows layout (same path as children); SkeletonRow renders the expected 4 placeholders (1 outer wrapper + 1 avatar circle + 2 text lines). Closes Sorokit#338
|
@RUKAYAT-CODER Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Vitest coverage for the alternative layouts flagged in the Stellar Wave issue:
maskedproduces a 4-prefix + 3 middot + 4-suffix string shorter than the source;monoaddsfont-mono; whenlabelis set the markup is a<dl><dt>{label}</dt><dd>{addressSpan}</dd></dl>, no<dl>whenlabelis omitted.role=separatoron both orientations;aria-orientation=verticalandw-px h-fullfor vertical; labeled renders the label inline; unlabeled renders onlyh-px bg-line;spacing=sm|md|lgmaps tomy-2|my-4|my-6.SkeletonCardrenders thestructureprop wholesale in place of the default header + rows layout (same path aschildren);SkeletonRowrenders the expected 4 placeholders (1 outer wrapper + 1 avatar circle + 2 text lines).Notes
className.toContain(...)/toHaveTextContent(...)patterns already established by the existing test suites in this repo.#338's structural assertion onSkeletonCard, thedata-testidmarker on the custom block is a normal Vitest dev-only attribute and does not leak into production output.Closes #338