fix: move non-sensitive data out of secrets.toml - BED-8838#57
Open
StranDutton wants to merge 1 commit into
Open
fix: move non-sensitive data out of secrets.toml - BED-8838#57StranDutton wants to merge 1 commit into
StranDutton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the BHE destination url out of
secrets.tomland intoconfig.toml, so thatsecrets.tomlcontains only credentials (token id and key), whileconfig.tomlholds non-sensitive config./resolves BED-8838
Note
This change is backward-compatible - existing collectors will still work if URL is left in
secrets_<collector-name>.tomlafter the update. Read below to find relevant DLT documentation that confirms this behavior.docker-compose.yml(for enterprise) to reflect changes.intervalwhich needed to be removedDLT Config Documentation - our situation applies to rule #4.
-> Previously, we referenced the BHE URL via
dlt.secrets.value- this meant that value had to be defined as an env variable or inside ofsecrets.toml. Because of how secret injection works, our update to now grab the URL fromdlt.config.valueallows DLT to search through the 2 previously mentioned places (env variables andsecrets.toml) in ADDITION toconfig.toml. As a result, the URL can now be defined insecrets.tomlorconfig.toml. **One caveat ** is that if URL is that, if URL defined in both files, the one insecrets.tomlwill take precedence after this change due to DLT's hierarchy.