Polish the consumer-repo wording in the update-copyright skill#32
Open
alexander-yevsyukov wants to merge 1 commit into
Open
Polish the consumer-repo wording in the update-copyright skill#32alexander-yevsyukov wants to merge 1 commit into
alexander-yevsyukov wants to merge 1 commit into
Conversation
Apply the documentation-review nits noted on PR #31 and left for follow-up: - Sentence-case the H1 per the documentation guideline. - Explain the `config:replaces` marker instead of citing it as bare jargon, and make the relative clause restrictive. - Add a second example before "etc.". - Name `update_copyright.py` as the holder of the exclusions; "the script's exclusions" read as if `migrate` were meant. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Documentation-only refinement to the update-copyright skill, improving clarity and consistency around how consumer repositories and config-distributed files are described (no script/behavior changes).
Changes:
- Sentence-cases the skill H1 (“Copyright update”) to match documentation style.
- Clarifies the
config:replacesconcept by describing it as a directive that produces replacement workflow variants with different basenames. - Improves wording and wrapping in the “config-distributed files” section (adds an additional example and points to
update_copyright.pyas the exclusion source).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wording-only follow-up to #31, applying the documentation-review nits that were noted there and left for a separate pass. All changes are in
skills/update-copyright/SKILL.md; no behavior changes.# Copyright update) per the documentation guideline.config:replacesmechanism instead of citing it as bare jargon, using the defining terminology fromconfig'smigratescript ("directive") and a restrictive that-clause: "variants that replace a distributed workflow via aconfig:replacesdirective and so ship under a different basename".buildSrc/,gradle.properties, etc.) — "etc." after a single item promised a list that wasn't there.update_copyright.pyexplicitly as the holder of the exclusion set; the previous "update the script's exclusions" read as ifmigratewere the antecedent.Verification
review-docsreviewed the diff: APPROVE, no Must-fix or Should-fix items. Its one optional nit (marker → directive) is folded into this PR.gradle.propertiesis in the script'sCONFIG_DISTRIBUTED_ROOT_FILES, andconfig/migratedocuments theconfig:replacesdirective with variants under distinct basenames.version.gradle.kts).🤖 Generated with Claude Code