Skip to content

Provide test coverage #107

Merged
Vladyslav-Kuksiuk merged 4 commits into
masterfrom
test-coverage
Jul 10, 2026
Merged

Provide test coverage #107
Vladyslav-Kuksiuk merged 4 commits into
masterfrom
test-coverage

Conversation

@Vladyslav-Kuksiuk

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

This PR provides test coverage verification via Codecov.

Resolves this issue.

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk self-assigned this Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk marked this pull request as ready for review July 9, 2026 12:00
@Oleg-Melnik

Copy link
Copy Markdown
Collaborator

Claude Review

The PR wires up Codecov coverage reporting: a new coverage.yml workflow that runs go test with coverage and uploads to Codecov, a codecov.yml enforcing 90% patch coverage on PRs, a README badge, and a PROJECT.md note. It's config/docs only — no Go code changes. Overall it's clean and consistent with the existing workflows.

Findings

1. .github/workflows/coverage.yml:38fail_ci_if_error: true will red-fail CI on fork PRs where CODECOV_TOKEN is unavailable.
The workflow triggers on pull_request, but GitHub does not expose repository secrets (secrets.CODECOV_TOKEN) to workflows triggered by PRs from forks. With fail_ci_if_error: true, the upload step fails and the whole check goes red for any external contributor's PR — through no fault of their change. For a public repo that accepts fork contributions this is a real friction point. If contributions come only from in-repo branches (as this PR does), the risk is latent but still worth a conscious decision. Consider fail_ci_if_error: false, or gating the upload/token requirement on non-fork PRs.

Minor / worth confirming

  • codecov.yml + only_pulls: true with push on master: the workflow also runs on push to master and uploads coverage, but the patch status is only_pulls: true and project: off. That's internally consistent (master pushes just populate the base coverage for later PR diffs) — just confirm that's the intent, since there's no status check on master by design.
  • README badge: the branch/master/graph/badge.svg URL is the correct Codecov format; it will render as "unknown" until the first successful upload lands on master.

Nothing else survived review. The one item worth acting on before merge is the fail_ci_if_error behavior for fork PRs.

🤖 Generated with Claude Code

@Oleg-Melnik Oleg-Melnik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vladyslav-Kuksiuk LGTM with Claude comments.

@Vladyslav-Kuksiuk

Copy link
Copy Markdown
Collaborator Author

Findings

1. .github/workflows/coverage.yml:38fail_ci_if_error: true will red-fail CI on fork PRs where CODECOV_TOKEN is unavailable. The workflow triggers on pull_request, but GitHub does not expose repository secrets (secrets.CODECOV_TOKEN) to workflows triggered by PRs from forks. With fail_ci_if_error: true, the upload step fails and the whole check goes red for any external contributor's PR — through no fault of their change. For a public repo that accepts fork contributions this is a real friction point. If contributions come only from in-repo branches (as this PR does), the risk is latent but still worth a conscious decision. Consider fail_ci_if_error: false, or gating the upload/token requirement on non-fork PRs.

That's the main purpose of this coverage check: to fail PRs when the coverage is insufficient. We shouldn't remove this behavior. Supporting forks in this way is not necessary, as they should have their own CODECOV_TOKEN anyway.

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk merged commit 62132b0 into master Jul 10, 2026
5 checks passed
@Vladyslav-Kuksiuk Vladyslav-Kuksiuk deleted the test-coverage branch July 10, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a test coverage tool to the project

2 participants