Harden Sirius adapter transaction boundaries - #259
Draft
KevinMehrabi wants to merge 1 commit into
Draft
Conversation
KevinMehrabi
requested review from
Raziievskyi-Illia,
Serhii-Apriorit and
vishakh
July 30, 2026 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous adapter could overquote a swap by one atomic unit, did not protect the minimum liquidity-token output with user-selected slippage, and lacked direct regression coverage for the external contract boundary.
Closes #249.
Validation
npm run verifyRelease gate
Keep this pull request in draft until both direct swaps, add/remove liquidity, wallet rejection, and allowance cleanup have been rehearsed with a no-broadcast simulation or controlled test wallet.