chore: update irm and comptroller in ui - #456
Conversation
90dbb76 to
7cadab1
Compare
KevinMehrabi
left a comment
There was a problem hiding this comment.
The Guard Comptroller and dynamic IRM integration are moving in the right direction, but please address the following before approval:
-
In Guard/recovery mode,
RedeemOpGroupshould not call the legacy Comptroller’supdateAccountLiquidityWithView. That unnecessarily makes withdrawals depend on the compromised oracle and every legacy market. Accrue only the selected ꜰToken and then perform the redeem. -
In Guard/recovery mode,
RepayBorrowOpGroupshould accrue only the market being repaid. A failure in an unrelated market should not block repayment. -
Guard market storage does not contain
mintPausedorborrowPaused. WhencomptrollerDataSourceis present, treat minting and borrowing as disabled based on Guard mode instead of falling back to the legacy Comptroller’s pause values. -
Please remove the unrelated deployment/configuration changes from this UI PR, especially
TezFinBuild/deploy_result/deploy.mainnet.json. The addresses currently recorded there do not resolve as mainnet contracts and the files overlap with PR #455. -
Add CI coverage that builds the actual React UI and tests the Guard/legacy storage combination and the recovery operation groups.
Once these items are fixed and the recovery withdrawal and repayment flows are tested against the live contract interfaces, this PR should be ready for approval.
We cannot perform a full e2e verification of the repay and withdraw flows because we do not have access to an account with an outstanding debt and supplied fToken balance. The operation groups are covered by unit tests, but validating actual on-chain execution requires a suitable borrower account |
|
Thank you. I confirmed that the original recovery-path issues are now addressed:
Before approval, please address these remaining items:
Once those items are fixed and CI remains green, please provide a staging URL pointed at the live recovery contracts so I can perform a small real repayment and zero-debt withdrawal as final release checks. |
|
Thanks, I reviewed the latest update. The recovery-mode behavior is now substantially improved: collateral controls are restricted only in recovery mode, unsafe oracle-derived USD values are hidden, and the action buttons respect the market pause and listing states. Two blockers remain:
Please restore both files exactly from
Also, CI currently builds with Once these items are resolved, this PR should be ready for another review. |
No description provided.