feat(#477): add one-shot initialiser guard to initialize() - #550
Merged
Kingsman-99 merged 2 commits intoJul 29, 2026
Conversation
- Add AlreadyInitialised = 33 to ContractError in error.rs
- Add initialised_key() returning symbol_short!("init_flg") in lib.rs
- Replace the admin_key existence check with a dedicated Initialised
boolean stored under initialised_key() in instance storage
- Guard panics with "AlreadyInitialised" if the flag is already set,
preventing front-run hijacking of the admin address
- Set the flag atomically at the end of initialize() so the contract is
only marked fully initialised after all state has been written
- Add initialised_key to storage_snapshot.rs and update the JSON baseline
Closes Stellar-split#477
|
@k2ghostyou Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i Add AlreadyInitialised = 33 to ContractError in error.rs
Closes #477