Feat/memo issuer sep24 paginator - #571
Open
proverbs31ziggo-a11y wants to merge 5 commits into
Open
Conversation
Add src/memoBuilder.ts with buildMemo/buildHashMemo/buildIdMemo/parseMemo/
isStellarSplitMemo functions. Encodes invoice ID, split version, and payer
ID into a canonical SS:v{version}:{invoiceId}:{payerSuffix} format that
fits within Stellar's 28-byte text memo limit. Adds ParsedMemo and
SplitConfig types to src/types.ts.
Add src/assetIssuerVerifier.ts that verifies issuer accounts exist on network, checks home domain and stellar.toml CURRENCIES section, and detects frozen/deauthorised flags. Adds IssuerVerificationResult to src/types.ts.
Add src/sep/sep24Handler.ts with Sep24Handler class that manages the full interactive transfer lifecycle: initiation, IFRAME URL generation, status polling, and completion detection. Emits sep24StatusChanged events via TypedEventEmitter. Adds Sep24TransactionRecord, Sep24Status, and Sep24StatusChangedEvent to src/types.ts.
Add src/horizonPaginator.ts providing an async iterator that transparently walks all pages of Horizon collection endpoints until exhausted or a configurable maxRecords limit is hit. Add src/cursorTracker.ts with InMemoryCursorStore for persisting paging tokens. Adds CollectionPage, HorizonPaginatorOptions, and CursorStore to src/types.ts.
…4 handler, and horizon paginator
|
@proverbs31ziggo-a11y Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #508
Closes #509
Closes #510
Closes #511
Many Horizon collection endpoints (transactions, operations, payments) use cursor-based pagination, but the SDK wraps them with one-shot calls that silently truncate results at the default page size. Callers iterating over a large invoice's payment history receive incomplete data without any indication that more pages exist. An async iterator should transparently walk all pages and yield records until the collection is exhausted.
Technical Context
Add src/horizonPaginator.ts. Wraps @stellar/stellar-sdk CollectionPage and its .next() method. Exposes paginate(initialPage: CollectionPage): AsyncIterableIterator. Used by src/client.ts listPayments(), listOperations(), and invoiceFilter.ts. Respects a configurable maxRecords limit. Integrates with src/cursorTracker.ts to persist the last paging token.