Equipment & inventory: item schema, weapons/armor/gear catalog, character items, sheet panel

[StreamDemon]

Closes #43.

Items become first-class: a page-stamped catalog, character inventory with per-instance state, armor as a wearable ablative pool, and the dossier's equipment surface.

Rules layer

• schema/items.ts — discriminated union over kind:
  • Weapons: category (future W.P. wiring), structured damage (formula dice + sdc/md type, with the printed multi-setting sentence in note beside the headline dice, like ppeNote), range/payload as printed strings.
  • Armor: S.D.C. armor = ar + sdc pool; M.D.C. armor = mdc.mainBody as a dice formula, because the book prints both constants (Gladiator "70", p.267) and per-suit rolls (Ley Line Walker concealed: "2D6+32 M.D.C. main body", p.113). Refinements reject the contradictions at load: armor must be exactly one of the two shapes, and an M.D.C. shell cannot declare an A.R. (there is no A.R. on M.D.C. armor).
  • Gear: name + printed notes, no mechanics.
• content/items/items.json — 34 items transcribed from rendered pages this session: 8 armors (pp.113/267–268), 11 weapons (energy pp.268–270; conventional damage from the W.P. sections pp.326–329), 15 gear entries from the LLW Standard Equipment list (p.116). Counts pinned in tests.
• engine/items.ts — catalog load + id index, armorNeedsRoll/rollArmorMdc/armorMaxPool for per-suit capacity, and damageArmor implementing the printed absorb rule: "the armor absorbs the attack — subtract the damage from the armor's S.D.C." (p.287) — the suit takes the whole hit, floors at 0, and nothing spills onto the body; a depleted suit stops protecting future hits.
• Character: items[] (itemId + worn + rolledMdc) and current.armor — the living-vitals pattern (feat: living vitals — current vs. max, P.P.E. spend on cast, damage tracking #40/Recovery rates & healing spells: rest/meditation/ley draw, treatment days, spell healing with targets #41): maximum on content (or the per-suit roll), live remainder on the character, illegal states rejected in deriveSheet (worn/rolledMdc are armor-only, one worn suit, roll within printed dice, pool ≤ max). The sheet surfaces equipment and the worn armor layer.

Backend

• addItem rolls dice-capacity suits at acquisition (mutation randomness + one transaction, same rationale as rollVitals), removeItem clears the pool with the worn suit, equipArmor is exclusive and resets the pool on change (fresh suit at max; per-suit damage memory across swaps is future scope).
• applyDamage grows an explicit toArmor flag: the worn suit absorbs the whole hit per p.287. Which hits strike armor (strike-vs-A.R. threshold, defender wins ties) is resolver scope (Combat resolution: strike constants + attack resolver #16/A.R. & armor damage in combat: strike-vs-A.R., armor ablation, the M.D.C. scope decision #44 companion) — until then the flag keeps it GM-adjudicated, the same philosophy as elapsed time in Recovery rates & healing spells: rest/meditation/ley draw, treatment days, spell healing with targets #41.
• Every write still revalidates through deriveSheet; items is optional in the Convex schema for pre-inventory docs (the rules layer defaults it).

Web

• EQUIPMENT — MANIFEST panel: kind-tagged rows, weapons roll their printed dice into the telemetry log client-side (like skills/saves — table moments, not records), armor rows wear/doff, everything discards, and a catalog picker acquires.
• Worn-armor bar beside the vitals in rust (amber family — armor is NOT magic), current / max with the printed dice range on hover.
• The Damage control gains an Armor toggle routing hits to the suit; telemetry distinguishes DAMAGE from DAMAGE (ARMOR). All new per-character control state resets on route-id change.

Verification

• vp check and root vp test green: 241 tests (was 219), including pinned catalog counts, printed-value assertions with page cites, armor-shape refinements, absorb/floor/no-spill semantics, and backend equip/damage flows.
• Driven live in the browser: acquired the LLW concealed suit (telemetry reported the per-suit roll, 39, inside the printed 34–44), wore it, dealt body damage (armor untouched), armor damage (body untouched), overkill (floored at 0, no spill), rolled weapon dice into the log, full-restored, doffed, and navigated to another character (fresh log, no leaked state, zero console errors).

Out of scope, per the issue: strike-vs-A.R. resolution and M.D.C. combat mechanics, W.P. proficiency bonuses, encumbrance, credits bookkeeping.

---

Summary by cubic

Adds a first-class equipment system with a page-stamped catalog and character inventory, plus a worn-armor layer that absorbs damage with no spill. Adds an equipment panel, a rust-toned armor bar, and an Armor toggle to route hits to a suit.

• New Features

  • Rules/catalog: item schema (weapon/armor/gear), 34-item catalog with page cites, and helpers (getItem, itemsByKind, armorNeedsRoll/rollArmorMdc/armorMaxPool, damageArmor per p.287).
  • Character model/sheet: inventory entries with per-instance worn and rolledMdc; deriveSheet enforces armor-only fields, one worn suit, roll within printed dice, and current.armor ≤ max; sheet shows equipment and the worn-armor bar.
  • Backend: addItem (rolls dice-capacity suits at acquisition), removeItem (clears pool if the worn suit is dropped), equipArmor (exclusive; resets pool on change), and applyDamage with toArmor to land hits on the suit.
  • Web UI: EQUIPMENT — MANIFEST (click weapon dice to roll; wear/doff; discard; acquire from catalog) and a rust-toned armor bar beside vitals; Damage control gains an Armor toggle; per-character control state resets on character switch.
  • Scope guardrails: strike-vs-A.R./full M.D.C. combat remain resolver/GM-adjudicated (use the toArmor toggle); encumbrance/credits are out of scope.

• Bug Fixes

  • applyDamage(toArmor) now refuses hits on a depleted suit; GMs route those to the body per p.287.
  • equipArmor is a no-op if the requested suit is already worn, so repeated clicks can’t “refill” armor.
  • Inventory writes (removeItem, equipArmor) verify the client’s instance snapshot (index + itemId/worn/rolledMdc) to avoid stale-index races.
  • Unequip also verifies the worn-suit snapshot (equipArmor(null, expect)), and is a no-op when nothing is worn.

^{Written for commit 11920c7. Summary will update on new commits.}

[cubic-dev-ai]

4 issues found across 14 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/web/src/pages/character-sheet.tsx">

<violation number="1" location="apps/web/src/pages/character-sheet.tsx:344">
P1: A depleted worn armor suit can still keep body damage from landing when the Armor toggle remains on. The client keeps sending `toArmor: true` without checking the live armor pool, while the server floors a 0 armor pool back to 0 instead of treating future hits as body hits or refusing them.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[StreamDemon]

All four validated as real; fixed in 19105fb.

1. Depleted armor keeps soaking (P1) — confirmed, and it was a fidelity bug, not just UX: p.287 says a depleted suit "no longer affords protection. Any future attacks will hit the character's body." The server now refuses a toArmor hit when the pool is already 0 (with the page cite in the error), so the GM explicitly routes it to the body; the client surfaces the refusal in telemetry like every other refused action. Chose refusal over silent rerouting to keep the client's stated intent and the applied effect in agreement. Covered by a new backend test (hit on 0-pool suit → /depleted/) and verified live.

2. Re-equip refills the pool (P2) — confirmed. equipArmor now compares the requested index against the currently worn one and no-ops when nothing would change, so a repeated [wear] can never repair the suit. Pool still resets on a real change of worn suit (documented: per-suit damage memory across swaps is future scope). New test: damage to 40/70 → re-equip same suit → still 40/70.

3. Stale-index inventory writes (P2) — confirmed, and fixed as a bug class: both removeItem and equipArmor now take the client's instance snapshot (itemId + worn + rolledMdc) and refuse with "manifest changed" when the entry at that index no longer matches. Snapshot verification rather than stored instance ids keeps the schema unchanged while making every mismatch (including a same-item different-state instance) detectable. New test exercises both mutations with stale snapshots and asserts nothing was written.

4. Misleading refine message (P3) — confirmed; the second refine rejects either field, so "cannot declare both" was wrong. Now: "M.D.C. armor is a Mega-Damage shell — it cannot declare an A.R. or an S.D.C. pool."

243 tests green, vp check clean, refused-hit and re-wear flows re-verified in the browser.

[cubic-dev-ai]

1 issue found across 5 files (changes from recent commits).

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

0 issues found across 3 files (changes from recent commits).

<sub>Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

Re-trigger cubic</sub>