test: add comprehensive refund splitting tests for cancel_stream - #1341
Merged
greatest0fallt1me merged 3 commits intoJul 29, 2026
Conversation
- Add 14 tests covering boundary conditions and edge cases for refund splits - Test scenarios: immediate cancel, full vesting, partial vesting, withdrawals - Cover paused streams, draft streams, small/large amounts, multiple withdrawals - Include error cases: already settled, already cancelled, nonexistent stream - Verify sender/recipient split: recipient gets vested - released, sender gets unvested - Add test documentation with coverage goals and verification approach
|
@Kenlachy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Perfect. LGTM ✨ merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Changes
Type of Security Change
Vulnerability Details (if applicable)
CVE/Advisory ID:
Affected Package:
Fix Applied:
Exemption Request (if applicable)
Exemption ID: EXEMPT-___
Justification:
Mitigation Applied:
Expiry Date: YYYY-MM-DD (max 90 days from now)
Review Plan:
Testing
npm auditlocally - output attached or no new vulnerabilitiesnpm testnpm run buildSecurity Impact Analysis
Affected Components:
Risk Assessment:
Documentation Updates
Checklist
Additional Notes
Test Output
CI Run Link
Workflow Run:
Security Review Required: @security-team
Compliance Impact: [Yes/No - explain if yes]
closes #938