Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the clarity and UX of automatic node filtering guidance in the converter’s advanced node management dialog, and extends the shared FormField component to support rendering helper text before the control for better readability.
Changes:
- Updated the exclusion-regex helper text to clarify global exclusion behavior and restoration when automatic filtering is disabled.
- Added
descriptionPlacementtoFormFieldto support rendering the description before the control while keeping the existing default behavior. - Added/updated regression tests to cover helper placement and accessible description wiring.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ui/src/product/converter/advanced-mode/sections/node-management/auto-processing-dialog.tsx | Updates helper copy and opts into description-before-control placement for the regex textarea. |
| packages/ui/src/product/converter/advanced-mode/sections/node-management/auto-processing-dialog.test.ts | Adjusts mocks and assertions to verify helper placement and props passed to FormField. |
| packages/ui/src/components/ui/form-field.tsx | Adds descriptionPlacement API and renders description either before or after the control while preserving aria-describedby behavior. |
| packages/ui/src/components/ui/form-controls.test.ts | Adds regression coverage for the new placement behavior and ordering/accessibility expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a111afc781
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Validation