Skip to content

feat(ui): clarify automatic filter guidance - #66

Merged
Ryson-32 merged 2 commits into
mainfrom
ryan/dev
Jul 26, 2026
Merged

feat(ui): clarify automatic filter guidance#66
Ryson-32 merged 2 commits into
mainfrom
ryan/dev

Conversation

@Ryson-32

Copy link
Copy Markdown
Member

Summary

  • Clarify that matched nodes are excluded globally and restored when automatic filtering is disabled.
  • Show the helper text before the regular-expression input while preserving the existing form-field default.
  • Add regression coverage for helper placement and accessible descriptions.

Validation

  • Public CI
  • Dev Release

Copilot AI review requested due to automatic review settings July 26, 2026 16:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the clarity and UX of automatic node filtering guidance in the converter’s advanced node management dialog, and extends the shared FormField component to support rendering helper text before the control for better readability.

Changes:

  • Updated the exclusion-regex helper text to clarify global exclusion behavior and restoration when automatic filtering is disabled.
  • Added descriptionPlacement to FormField to support rendering the description before the control while keeping the existing default behavior.
  • Added/updated regression tests to cover helper placement and accessible description wiring.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/ui/src/product/converter/advanced-mode/sections/node-management/auto-processing-dialog.tsx Updates helper copy and opts into description-before-control placement for the regex textarea.
packages/ui/src/product/converter/advanced-mode/sections/node-management/auto-processing-dialog.test.ts Adjusts mocks and assertions to verify helper placement and props passed to FormField.
packages/ui/src/components/ui/form-field.tsx Adds descriptionPlacement API and renders description either before or after the control while preserving aria-describedby behavior.
packages/ui/src/components/ui/form-controls.test.ts Adds regression coverage for the new placement behavior and ordering/accessibility expectations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/ui/src/components/ui/form-controls.test.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a111afc781

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI review requested due to automatic review settings July 26, 2026 16:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Ryson-32
Ryson-32 merged commit 7a62822 into main Jul 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants