fix(selfhost): keep app stable when starting cron - #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-depsafter the candidate app passes health checksReproduction
On the amd64 fresh one-click path,
subboost updatepassed its candidate health wait, thendocker compose up -d cronrecreated the app throughdepends_on. The immediate post-update request repeatedly failed withcurl: (56) Recv failure: Connection reset by peer; an update retry passed after the app settled.Validation
bash -n local/scripts/subboost.shnpm run test:unit -- local/scripts/selfhost-shell.test.ts local/scripts/selfhost-lifecycle-shell.test.ts(16/16)npm run test:unit(1175/1175)npm run lintnpm run check:local-appNo version bump, tag, release, or deployment is included.