Fix board changes lost on page refresh#20
Merged
Conversation
|
7d4a256 to
d2c10aa
Compare
Reject reload only when tasks have invalid owners, not missing due dates. Flush edits made during load once sync is ready. Persist to localStorage when API is unavailable. Save on page unload. Rebased onto main. Co-authored-by: Sanket Sharma <sharma.sanket272@gmail.com>
d2c10aa to
14068ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes changes disappearing after a page refresh.
Root causes
applyBoardrequired 30% of leaf tasks to have due dates, so boards saved to SQLite were discarded on reload and replaced with sample data./api/boardbackend; saves failed silently and every refresh reloaded sample data.Fix
localStorage; use the API when it returns JSON.pagehideto survive quick refreshes.Test plan
npm run ci(45 tests)python server.py, add a project, refresh — project remains