macos: fix yt-dlp#785
Open
prez wants to merge 1 commit into
Open
Conversation
closes Syncplay#585 syncplay spawns mpv as a subprocess, inheriting its env. mpv in turn spawns yt-dlp, and this inherits PYTHONHOME / PYTHONPATH pointing at syncplay's bundled python, making any python change where it looks for its stdlib, causing it to crash with `ModuleNotFoundError: No module named 'encodings'`. I do not fully understand why the old code did things the way it did, but it appears as if it attempted to work around this by hardcoding PATH (questionable) to "common" (and incomplete) locations, then doing a peculiar and fragile dance to extract its PYTHONPATH... my hypothesis is that the only thing breaking yt-dlp is the inherited PYTHONHOME/PYTHONPATH, so just drop that and rely on python locating its stdlib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is an attempt to fix #585. seems to work fine for me locally on macOS.
explanation from the commit message:
syncplay spawns mpv as a subprocess, inheriting its env. mpv in turn spawns yt-dlp, and this inherits PYTHONHOME / PYTHONPATH pointing at syncplay's bundled python, making any python change where it looks for its stdlib, causing it to crash with
ModuleNotFoundError: No module named 'encodings'. I do not fully understand why the old code did things the way it did, but it appears as if it attempted to work around this by hardcoding PATH (questionable) to "common" (and incomplete) locations, then doing a peculiar and fragile dance to extract its PYTHONPATH...my hypothesis is that the only thing breaking yt-dlp is the inherited PYTHONHOME/PYTHONPATH, so just drop that and rely on python locating its stdlib.