fix(QTDI-3124): [Refactoring] Merge sonar fixes

component-api/src/main/java/org/talend/sdk/component/api/configuration/ui/layout/GridLayout.java

@@ -27,10 +27,12 @@
 import org.talend.sdk.component.api.meta.Documentation;
 
 @Ui
-@Documentation("Advanced layout to place properties by row, this is exclusive with `@OptionsOrder`.\n"
-        + "\nNOTE: the logic to handle forms (gridlayout names) is to use the only layout if there is only one defined, "
-        + "else to check if there are `Main` and `Advanced` and if at least `Main` exists, use them, else "
-        + "use all available layouts.")
+@Documentation("""
+               Advanced layout to place properties by row, this is exclusive with `@OptionsOrder`.
+
+               NOTE: the logic to handle forms (gridlayout names) is to use the only layout if there is only one defined, \
+               else to check if there are `Main` and `Advanced` and if at least `Main` exists, use them, else \
+               use all available layouts.""")
 @Target(TYPE)
 @Retention(RUNTIME)
 @Repeatable(GridLayouts.class)

component-api/src/main/java/org/talend/sdk/component/api/record/Schema.java

@@ -532,7 +532,7 @@ public EntriesOrder(final String fields) {
             if (fields == null || fields.isEmpty()) {
                 fieldsOrder = new OrderedMap<>(Function.identity());
             } else {
-                final List<String> fieldList = Arrays.stream(fields.split(",")).collect(Collectors.toList());
+                final List<String> fieldList = Arrays.stream(fields.split(",")).toList();
                 fieldsOrder = new OrderedMap<>(Function.identity(), fieldList);
             }
         }

component-api/src/main/java/org/talend/sdk/component/api/service/asyncvalidation/AsyncValidation.java

@@ -27,8 +27,11 @@
 @ActionType(value = "validation", expectedReturnedType = ValidationResult.class)
 @Target(METHOD)
 @Retention(RUNTIME)
-@Documentation("Mark a method as being used to validate a configuration.\n\nIMPORTANT: this is a server validation "
-        + "so only use it if you can't use other client side validation to implement it.")
+@Documentation("""
+               Mark a method as being used to validate a configuration.
+
+               IMPORTANT: this is a server validation \
+               so only use it if you can't use other client side validation to implement it.""")
 public @interface AsyncValidation {
 
     /**

component-api/src/main/java/org/talend/sdk/component/api/service/discovery/DiscoverDatasetResult.java

@@ -35,7 +35,7 @@ public DiscoverDatasetResult(final List<DatasetDescription> datasetDescriptionLi
     }
 
     @Getter
-    public final static class DatasetDescription {
+    public static final class DatasetDescription {
 
         public DatasetDescription(final String name) {
             this.name = name;

component-api/src/main/java/org/talend/sdk/component/api/service/schema/Schema.java

@@ -31,9 +31,13 @@
 import lombok.Data;
 import lombok.NoArgsConstructor;
 
-@Partial("This API should support nested schema but the Studio is not yet ready.\n\n"
-        + "The cloud platform also doesn't use it yet.\n\nAlso prefer to use "
-        + "`org.talend.sdk.component.api.record.Schema` over this partial default implementation.")
+@Partial("""
+         This API should support nested schema but the Studio is not yet ready.
+
+         The cloud platform also doesn't use it yet.
+
+         Also prefer to use \
+         `org.talend.sdk.component.api.record.Schema` over this partial default implementation.""")
 @Data
 @NoArgsConstructor
 @AllArgsConstructor

component-api/src/test/java/org/talend/sdk/component/api/record/OrderedMapTest.java

@@ -40,12 +40,12 @@ void orderedMapTest() {
 
         container.addValue(f1);
         container.addValue(f2);
-        List<String> entries = container.streams().collect(Collectors.toList());
+        List<String> entries = container.streams().toList();
         Assertions.assertSame("f1", entries.get(0));
         Assertions.assertSame("f2", entries.get(1));
 
         container.swap("f1", "f2");
-        List<String> entries2 = container.streams().collect(Collectors.toList());
+        List<String> entries2 = container.streams().toList();
         Assertions.assertSame("f2", entries2.get(0));
         Assertions.assertSame("f1", entries2.get(1));
 

component-form/component-form-core/src/main/java/org/talend/sdk/component/form/api/UiSpecService.java

@@ -15,7 +15,6 @@
  */
 package org.talend.sdk.component.form.api;
 
-import static java.util.stream.Collectors.toList;
 import static java.util.stream.Collectors.toSet;
 
 import java.util.ArrayList;
@@ -113,7 +112,7 @@ public CompletionStage<Ui> convert(final String family, final String lang, final
                             prop.getName(), prop.getDisplayName(), prop.getType(), prop.getDefaultValue(),
                             prop.getValidation(), prop.getMetadata(), prop.getPlaceholder(),
                             prop.getProposalDisplayNames()))
-                    .collect(toList());
+                    .toList();
             isRootProperty = p -> p.getPath().equals(def.getName());
         } else {
             props = node.getProperties();

component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/UiSchemaConverter.java

@@ -16,7 +16,6 @@
 package org.talend.sdk.component.form.internal.converter.impl;
 
 import static java.util.Collections.singletonMap;
-import static java.util.stream.Collectors.toList;
 import static java.util.stream.Collectors.toMap;
 
 import java.util.Collection;
@@ -115,7 +114,7 @@ public CompletionStage<PropertyContext<?>> convert(final CompletionStage<Propert
                                             .stream()
                                             .filter(prop -> prop.getPath().startsWith(nestedPrefix)
                                                     && prop.getPath().indexOf('.', from) < 0)
-                                            .collect(toList());
+                                            .toList();
                                     if (!nested.isEmpty()) {
                                         return new ObjectArrayWidgetConverter(schemas, properties, actions, family,
                                                 client, gridLayoutFilter, jsonSchema, lang, customConverters, metadata,

component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/schema/ArrayPropertyConverter.java

@@ -16,7 +16,6 @@
 package org.talend.sdk.component.form.internal.converter.impl.schema;
 
 import static java.util.Locale.ROOT;
-import static java.util.stream.Collectors.toList;
 
 import java.util.Collection;
 import java.util.List;
@@ -50,7 +49,7 @@ public CompletionStage<PropertyContext<?>> convert(final CompletionStage<Propert
             jsonSchema.setType(context.getProperty().getType().toLowerCase(ROOT));
             final String prefix = context.getProperty().getPath() + "[]";
             final List<SimplePropertyDefinition> arrayElements =
-                    properties.stream().filter(child -> child.getPath().startsWith(prefix)).collect(toList());
+                    properties.stream().filter(child -> child.getPath().startsWith(prefix)).toList();
 
             if (arrayElements.stream().anyMatch(e -> e.getPath().startsWith(prefix + '.'))) { // complex object
                 final JsonSchema items = new JsonSchema();

component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/AbstractWidgetConverter.java

@@ -86,7 +86,7 @@ protected <T> CompletionStage<List<UiSchema.NameValue>> loadDynamicValues(final
                                         val.setValue((String) entry.get("id"));
                                         return val;
                                     })
-                                    .collect(toList());
+                                    .toList();
                         })
                         .orElse(emptyList()));
     }
@@ -140,7 +140,7 @@ protected List<UiSchema.Parameter> toParams(final Collection<SimplePropertyDefin
                                 .setPath(path.endsWith("[]") ? path.substring(0, path.length() - "[]".length()) : path);
                         return parameter;
                     })
-                    .collect(toList());
+                    .toList();
 
             // if we are empty and there was no "empty" object then fail
             if (!propertiesPrefix.startsWith("$") && resolvedParams.isEmpty()
@@ -149,7 +149,7 @@ protected List<UiSchema.Parameter> toParams(final Collection<SimplePropertyDefin
                         + ref.getFamily() + "/" + ref.getType() + "/" + ref.getName());
             }
             return resolvedParams.stream();
-        }).collect(toList())).orElse(null);
+        }).toList()).orElse(null);
     }
 
     protected UiSchema newUiSchema(final PropertyContext<?> ctx) {
@@ -330,7 +330,6 @@ protected Map<String, Collection<Object>> createCondition(final PropertyContext<
                             .collect(toList());
                     final Map<String, Collection<Object>> condition = values.size() == 1 ? values.iterator().next()
                             : new UiSchema.ConditionBuilder().withOperator("or").withValues(values).build();
-                    final UiSchema.ConditionValuesBuilder rootBuilder;
                     if (!shouldBe) { // no need to add the wrapper if we test true (default)
                         return new UiSchema.ConditionBuilder()
                                 .withOperator("==")
@@ -380,8 +379,7 @@ protected Map<String, Collection<Object>> toCondition(final String path, final S
                         .withVar(path + ".length")
                         .withValue(value instanceof String ? Integer.parseInt(String.valueOf(value)) : value)
                         .build();
-            case "contains":
-            case "contains(lowercase=true)":
+            case "contains", "contains(lowercase=true)":
                 final UiSchema.ConditionValuesBuilder in = new UiSchema.ConditionBuilder().withOperator("in");
                 final Object val =
                         strategy.endsWith("(lowercase=true)") ? ((String) value).toLowerCase(ROOT) : value;

component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/DataListWidgetConverter.java

@@ -90,7 +90,7 @@ protected CompletionStage<PropertyContext<?>> fillProposalsAndReturn(final Prope
                 return pairs.thenApply(namedValues -> {
                     schema.setTitleMap(namedValues);
                     schema.setRestricted(true);
-                    jsonSchema.setEnumValues(namedValues.stream().map(UiSchema.NameValue::getValue).collect(toList()));
+                    jsonSchema.setEnumValues(namedValues.stream().map(UiSchema.NameValue::getValue).toList());
                     return context;
                 });
             } else {

component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/DateTimeConverter.java

@@ -57,7 +57,7 @@
                 Boolean.parseBoolean(context.getProperty().getMetadata().getOrDefault("ui::datetime::useUTC", "true"));
         switch (format) {
             case "time": {
                 schema.setWidget("datetime"); // todo: move to "time" widget when existing
                 final Map<String, Object> options = new HashMap<>();
                 options.put("useSeconds", useSeconds);
                 schema.setOptions(options);
@@ -67,8 +67,7 @@
                 schema.setWidget("date");
                 schema.setOptions(singletonMap("dateFormat", dateFormat));
                 break;
-            case "datetime":
-            case "zoneddatetime": {
+            case "datetime", "zoneddatetime": {
                 schema.setWidget("datetime");
                 final Map<String, Object> options = new HashMap<>();
                 options.put("useSeconds", useSeconds);

component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/GridLayoutWidgetConverter.java

@@ -82,7 +82,7 @@ public CompletionStage<PropertyContext<?>> convert(final CompletionStage<Propert
                         // if we have multiple tabs, priority is MAIN/ADVANCED pair first
                         // but if they are not present then we use all layouts in "String" order
                         final List<String> tabs = (layouts.containsKey("Main") ? Stream.of("Main", "Advanced")
-                                : layouts.keySet().stream().sorted(String::compareToIgnoreCase)).collect(toList());
+                                : layouts.keySet().stream().sorted(String::compareToIgnoreCase)).toList();
 
                         final UiSchema schema = newUiSchema(context);
                         schema.setTitle(null);

component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/MultiSelectWidgetConverter.java

@@ -16,7 +16,6 @@
 package org.talend.sdk.component.form.internal.converter.impl.widget;
 
 import static java.util.Collections.emptyList;
-import static java.util.stream.Collectors.toList;
 
 import java.util.Collection;
 import java.util.List;
@@ -69,7 +68,7 @@ public CompletionStage<PropertyContext<?>> convert(final CompletionStage<Propert
                         loadDynamicValues(client, family, actionName, context.getRootContext());
                 return pairs.thenApply(namedValues -> {
                     schema.setTitleMap(namedValues);
-                    jsonSchema.setEnumValues(namedValues.stream().map(UiSchema.NameValue::getValue).collect(toList()));
+                    jsonSchema.setEnumValues(namedValues.stream().map(UiSchema.NameValue::getValue).toList());
                     return context;
                 });
             } else {

component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/validation/spi/ext/BaseValidation.java

@@ -59,8 +59,7 @@ public Stream<ValidationResult.ValidationError> apply(final JsonValue obj) {
         switch (value.getValueType()) {
             case STRING:
                 return onString((JsonString) value);
-            case TRUE:
-            case FALSE:
+            case TRUE, FALSE:
                 return onBoolean(JsonValue.TRUE.equals(value));
             case NUMBER:
                 return onNumber((JsonNumber) value);

component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/validation/spi/ext/TypeValidation.java

@@ -16,7 +16,6 @@
 package org.talend.sdk.component.form.internal.validation.spi.ext;
 
 import static java.util.Comparator.comparing;
-import static java.util.stream.Collectors.toList;
 
 import java.util.Collection;
 import java.util.Optional;
@@ -38,10 +37,10 @@ public class TypeValidation implements ValidationExtension {
     @Override
     public Optional<Function<JsonValue, Stream<ValidationError>>> create(final ValidationContext model) {
         final JsonValue value = model.getSchema().get("type");
-        if (value instanceof JsonString) {
+        if (value instanceof JsonString jsonString) {
             return Optional
                     .of(new Impl(model.toPointer(), model.getValueProvider(),
-                            mapType((JsonString) value).toArray(JsonValue.ValueType[]::new)));
+                            mapType(jsonString).toArray(JsonValue.ValueType[]::new)));
         }
         if (value instanceof JsonArray) {
             return Optional
@@ -83,7 +82,7 @@ private Impl(final String pointer, final Function<JsonValue, JsonValue> extracto
                     .concat(Stream.of(types), Stream.of(JsonValue.ValueType.NULL))
                     .distinct()
                     .sorted(comparing(JsonValue.ValueType::name))
-                    .collect(toList());
+                    .toList();
         }
 
         @Override

component-form/component-form-core/src/test/java/org/talend/sdk/component/form/api/UiSpecServiceTest.java

@@ -23,7 +23,6 @@
 import static java.util.Optional.ofNullable;
 import static java.util.concurrent.CompletableFuture.completedFuture;
 import static java.util.stream.Collectors.joining;
-import static java.util.stream.Collectors.toList;
 import static java.util.stream.Collectors.toSet;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
@@ -48,7 +47,6 @@
 import java.util.concurrent.CompletionStage;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Consumer;
-import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
 import javax.json.bind.Jsonb;
@@ -288,7 +286,7 @@
                         .getItems()
                         .stream()
                         .map(UiSchema::getTitle)
-                        .collect(toList()));
+                        .toList());
     }
 
     @Test
@@ -311,12 +309,6 @@
     @Test
     void optionsOrder() throws Exception {
         final ConfigTypeNode node = load("optionsorder.json", ConfigTypeNode.class);
-        final SimplePropertyDefinition root = node
-                .getProperties()
-                .stream()
-                .filter(it -> it.getPath().equals("configuration"))
-                .findFirst()
-                .orElseThrow(() -> new IllegalArgumentException("bad config"));
         final Ui payload = service.convert("FileIO", "en", node, null).toCompletableFuture().get();
         final List<String> actualOrder = payload
                 .getUiSchema()
@@ -327,7 +319,7 @@
                 .map(UiSchema::getKey)
                 .filter(Objects::nonNull)
                 .map(s -> s.substring(s.lastIndexOf('.') + 1))
-                .collect(toList());
+                .toList();
         assertEquals(asList("region", "unknownRegion", "bucket", "object", "encryptDataAtRest", "kmsForDataAtRest",
                 "format", "recordDelimiter", "specificRecordDelimiter", "fieldDelimiter", "specificFieldDelimiter",
                 "limit"), actualOrder);
@@ -462,7 +454,7 @@
 
         assertEquals(5, tableDataSetMain.getItems().size());
         assertEquals(asList("dataStore", "commonConfig", "Query", "Ordered", "Order"),
-                tableDataSetMain.getItems().stream().map(UiSchema::getTitle).collect(toList()));
+                tableDataSetMain.getItems().stream().map(UiSchema::getTitle).toList());
 
         final Iterator<UiSchema> mainIt = tableDataSetMain.getItems().iterator();
         final UiSchema dataStore = mainIt.next();
@@ -471,7 +463,7 @@
         final UiSchema credentials = dataStoreIt.next();
         assertEquals("columns", credentials.getWidget());
         assertEquals(asList("Username", "Password"),
-                credentials.getItems().stream().map(UiSchema::getTitle).collect(toList()));
+                credentials.getItems().stream().map(UiSchema::getTitle).toList());
 
         final UiSchema tableDataSetAdvanced = tableDataSetIt.next();
         assertEquals("Advanced", tableDataSetAdvanced.getTitle());
@@ -539,7 +531,7 @@
         assertEquals("SuggestionForJdbcDrivers", driverTrigger.getAction());
         assertNull(driverTrigger.getRemote());
         assertEquals(singletonList("currentValue/configuration.driver"),
-                driverTrigger.getParameters().stream().map(it -> it.getKey() + '/' + it.getPath()).collect(toList()));
+                driverTrigger.getParameters().stream().map(it -> it.getKey() + '/' + it.getPath()).toList());
 
         assertEquals("change", triggers.next().getOnEvent());
     }
@@ -625,7 +617,7 @@
     }
 
     @Test
     void uiSchema() throws Exception {
         final Ui payload = service.convert(load("jdbc.json"), "en", null).toCompletableFuture().get();
         final Collection<UiSchema> uiSchema = payload.getUiSchema();
         assertNotNull(uiSchema);
@@ -658,7 +650,7 @@
                                     .getTitleMap()
                                     .stream()
                                     .map(UiSchema.NameValue.class::cast)
-                                    .collect(Collectors.toList());
+                                    .toList();
                             assertEquals(1, titleMap.size());
                             final UiSchema.NameValue firstTitleMap = titleMap.iterator().next();
                             assertEquals("some.driver.Jdbc", firstTitleMap.getValue());

component-form/component-form-core/src/test/java/org/talend/sdk/component/form/internal/validation/ValidationServiceTest.java

@@ -15,7 +15,6 @@
  */
 package org.talend.sdk.component.form.internal.validation;
 
-import static java.util.stream.Collectors.toList;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import java.io.IOException;
@@ -61,7 +60,7 @@ public CompletionStage<Collection<ValidationError>> validate(final ConfigTypeNod
                         .getErrors()
                         .stream()
                         .map(e -> new ValidationError(e.getField(), e.getMessage()))
-                        .collect(toList()));
+                        .toList());
     }
 
     public CompletionStage<JsonSchemaValidator> getValidator(final ConfigTypeNode config) {