Jazzy/feat/dist range#9
Open
MrKeith99 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for user-configurable minimum and maximum range limits for the lidar scan data, allowing filtering of near-field and far-field noise by dropping returns outside the specified window. It also updates configuration files and parameter handling to support these new options, and improves frame ID prefixing logic. The most important changes are:
Range window filtering and parameter support:
dist_minanddist_maxparameters to all relevant config YAML files (urg_node_ethernet.yaml,urg_node_multi_ethernet1.yaml,urg_node_multi_ethernet2.yaml,urg_node_serial.yaml) to allow users to specify minimum and maximum valid scan ranges. Setting these to0.0uses the device's physical limits. [1] [2] [3] [4]setRangeLimits,getEffectiveRangeMin, andgetEffectiveRangeMaxinURGCWrapperto enforce the user-specified range window, clamped to the device's physical limits. These are used in scan acquisition to replace out-of-window readings with NaN (or drop echoes) for noise/self-collision filtering. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]dist_min_anddist_max_members toUrgNode, declared/loaded them as parameters, and passed them toURGCWrapperduring connection. Parameter change validation was also updated to support integer/double types for these parameters. [1] [2] [3] [4] [5]Frame ID prefixing improvements:
enable_tf_prefix_parameter and logic to optionally prefix the frame ID with the node namespace, improving flexibility for multi-robot or namespaced deployments. [1] [2] [3] [4]Miscellaneous:
<algorithm>include forstd::max/std::min, initialized new members). [1] [2]These changes enable more robust and customizable lidar scan filtering and improve configuration flexibility.