Skip to content

Jazzy/feat/dist range#9

Open
MrKeith99 wants to merge 3 commits into
jazzy-develfrom
jazzy/feat/dist_range
Open

Jazzy/feat/dist range#9
MrKeith99 wants to merge 3 commits into
jazzy-develfrom
jazzy/feat/dist_range

Conversation

@MrKeith99

Copy link
Copy Markdown
Member

This pull request adds support for user-configurable minimum and maximum range limits for the lidar scan data, allowing filtering of near-field and far-field noise by dropping returns outside the specified window. It also updates configuration files and parameter handling to support these new options, and improves frame ID prefixing logic. The most important changes are:

Range window filtering and parameter support:

  • Added dist_min and dist_max parameters to all relevant config YAML files (urg_node_ethernet.yaml, urg_node_multi_ethernet1.yaml, urg_node_multi_ethernet2.yaml, urg_node_serial.yaml) to allow users to specify minimum and maximum valid scan ranges. Setting these to 0.0 uses the device's physical limits. [1] [2] [3] [4]
  • Implemented setRangeLimits, getEffectiveRangeMin, and getEffectiveRangeMax in URGCWrapper to enforce the user-specified range window, clamped to the device's physical limits. These are used in scan acquisition to replace out-of-window readings with NaN (or drop echoes) for noise/self-collision filtering. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Added dist_min_ and dist_max_ members to UrgNode, declared/loaded them as parameters, and passed them to URGCWrapper during connection. Parameter change validation was also updated to support integer/double types for these parameters. [1] [2] [3] [4] [5]

Frame ID prefixing improvements:

  • Added enable_tf_prefix_ parameter and logic to optionally prefix the frame ID with the node namespace, improving flexibility for multi-robot or namespaced deployments. [1] [2] [3] [4]

Miscellaneous:

  • Minor includes and initialization improvements (e.g., added <algorithm> include for std::max/std::min, initialized new members). [1] [2]

These changes enable more robust and customizable lidar scan filtering and improve configuration flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant