fix(home-new): show nav bar immediately instead of after scroll - #519
Merged
Conversation
home-new.astro was the only -new page not passing alwaysVisible to HomeNavbar, leaving the nav hidden until the user scrolled halfway down the viewport.
Deploying website with
|
| Latest commit: |
60e47f4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://63c75c82.website-aun.pages.dev |
| Branch Preview URL: | https://fix-home-new-nav-always-visi.website-aun.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
home-new.astrowas the only-newredesign page not passingalwaysVisibletoHomeNavbar, so its nav stayed hidden (opacity: 0, translated off-screen) until the user scrolled past half the viewport height.-newpage (about-new, donate-new, team-new, events-new, faq-new, etc.) already passesalwaysVisible, so this bringshome-newin line with the rest.Test plan
/home-newand confirm the nav bar is visible immediately on page load, without scrolling-newpage (e.g./about-new) to confirm nav behavior is unchanged there