perf: skip rewriting files untouched by in-place anonymization#22
Open
CompactAIOfficial wants to merge 1 commit into
Open
perf: skip rewriting files untouched by in-place anonymization#22CompactAIOfficial wants to merge 1 commit into
CompactAIOfficial wants to merge 1 commit into
Conversation
In-place anonymization always replaced the destination with the temp file even when no line changed, rewriting every clean trace and churning mtimes. Track whether any line was actually modified and drop the temp file when an in-place run left the content identical; apply the same check to whole-text (non-jsonl) files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-place anonymization (
teich extract's default post-pass,teich anonymize --in-place) always replaced the destination with the freshly written temp file, even when zero lines changed — every clean trace got rewritten and its mtime churned on every run.This tracks whether any line was actually modified while streaming; when an in-place run leaves the content identical, the temp file is discarded instead of replacing the destination. Whole-text (non-jsonl) files get the same check. Copy-to-other-destination behavior is unchanged.
Testing
pytest tests/test_extract_anonymize_cli.py— 32 passed🤖 Generated with Claude Code