test(test): guard status filter validation order#222
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughAdded a new test case to ChangesStatus validation regression test
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
zeshi-du
left a comment
There was a problem hiding this comment.
Merging as a harmless additive test: note the ordering fix itself (validate --status before client/auth setup) already shipped via the #152 backport, whose test asserts the stronger property (fetch never called). This one adds the CLI-wiring angle via createTestCommand + parseAsync, which is a distinct layer. Thanks @Lexiie!
Summary
test list --status junkregression test that runs without credentials.VALIDATION_ERRORbehavior so invalid status filters cannot regress intoAUTH_REQUIREDif validation order changes.Changes
runListcommand-parser path for--statusvalidation before credentials/client setup.Verification
rtk vitest run src/commands/test.test.ts -t "rejects --status=junk before reading credentials"rtk npx eslint src/commands/test.test.ts --fix-dry-run --format stylishrtk npx eslint src/commands/test.test.tsrtk npm run typecheckFixes #210
Summary by CodeRabbit
--statusvalues are rejected immediately when listing tests, with a clear validation error.