Skip to content
This repository was archived by the owner on Oct 20, 2023. It is now read-only.

I give to you the power of regex#37

Open
greenbigfrog wants to merge 4 commits into
masterfrom
hotfix/regex-escaping
Open

I give to you the power of regex#37
greenbigfrog wants to merge 4 commits into
masterfrom
hotfix/regex-escaping

Conversation

@greenbigfrog

Copy link
Copy Markdown
Contributor

No description provided.

I always meant to implement this, but it somehow got lost somewhere
along the way.
But LW including a `|`, and thus causing anyone who mentions `Discord
Nitro` or `Steam Store` to get banned, and making me look for a bug at
first, made me realize, we never got around to it. Luckily no false
positive bans caused by this though :akek:
Welp, never thought mini slash would still be in use in 2021, especially
after it came practically useless after the switch to zeppelin.
@kantenkugel

Copy link
Copy Markdown
Contributor

IMO this looks fine. i have a few issues though:

  • when adding phrases in the default no-regex way, it would make sense to add \w* on the left and right again (outside of the regex escape)
  • how are you currently planning of migrating the existing config?
  • should regex really be controlled by a single true at the end of the phrase? i can see phrases accidentally being added in shortened and regex way, when ending with a true. Maybe use the full regex=true suffix? that should be a bit more obvious when adding and chances of that actually occuring in a ban phrase are way lower too

@kantenkugel kantenkugel self-requested a review October 25, 2021 20:03

@kantenkugel kantenkugel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing the \w* part on non-regex

@kantenkugel kantenkugel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing the \w* part on non-regex

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants