Conversation
Name of the module is extracted from GITHUB_WORKSPACE
This is in line with how vlogsimargs works
This reverts commit 4382f3c.
Icarus simulations break when vloglibfilemodules (e.g. external memory simulation models) are provided due to manual path parsing logic with string operations. self.vloglibfilemodules are already included in self.rtlfiles. Modify icarus backend logic to more closely match working questa backend logic and perform path concatenations using os.path.join()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the release commit v1.14