Further Ngspice integration#33
Open
MiikkaMaki wants to merge 14 commits into
Open
Conversation
Member
|
@MiikkaMaki Without further study, this breaks inverter simulation with ngspice. You can verify that by cloning thesedk_template, schecking out this branch on the inverter and running ./configure && make sim for it. Can not be merged as is. Output signal reading back to python fails |
Member
|
@MiikkaMaki Please check this. Verify with inverter, at least. |
mkosunen
reviewed
Jun 19, 2026
Member
|
In general, the commit has been made with precommit hooks inactive. @MiikkaMaki , let me know in which environment you have made the commit, and I can fix the precommit hook execution. |
For now the value of cmdfile_ext for ngspice is '.ngcir'. Changing this will break every simulation. Lint spice/ngspice/ngspice.py with 'black -l 80 spice/ngspice/ngspice.py'
Contributor
Author
|
Could you specify what you need, and how do I avoid this in the future? I am not familiar with precommit hooks. |
Contributor
Author
|
This change (d1c5f23) breaks sparam and noise simulations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch has been used to integrate Ngspice to thesydekick, and should now have all relevant Ngspice simulation types implemented. This has been used by me for some months now and small bug fixes and features have been added from time to time. The code is trying to replicate the spectre class so that thesydekick testbenches don't need to do anything else than switch the simulator name. However, it should be noted that some simulation types and some features are not possible using Ngspice.
I recommend that this is merged to v1.14_RC somewhere before release. Note that the changes are not only in ngspice files, but also require modifications in general non-simulator specific files.
Ping @mkosunen.