Skip to content

Commit 01f3bb5

Browse files
committed
Audit remaining monolithic Playwright test code and classify evidence-backed split or wrapper actions - PR_26146_041-monolithic-test-code-audit
1 parent a6d9a67 commit 01f3bb5

28 files changed

Lines changed: 347 additions & 170 deletions

docs/dev/reports/dependency_gating_report.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Dependency Gating Report
22

3-
Generated: 2026-05-26T21:52:45.136Z
4-
Status: FAIL
3+
Generated: 2026-05-26T22:00:48.031Z
4+
Status: PASS
55

66
## Gate Order
77

@@ -20,12 +20,10 @@ Status: FAIL
2020
| integration | No | SKIP | none | Workspace, tool, game index, and manifest handoff behavior | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
2121
| engine-src | No | SKIP | none | src/ engine and shared runtime capability behavior | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
2222
| samples | No | SKIP | none | Affected samples lane, on request only | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
23-
| invalid-targeted-closeout-lane | Yes | FAIL | none | unknown | Requested lane does not exist in laneDefinitions. |
2423

2524
## Dependency Failures Caught Pre-Runtime
2625

27-
- Unknown lane requested before dependency gating: invalid-targeted-closeout-lane
28-
- Lane compilation failed; dependency-gated runtime scheduling is blocked.
26+
No deterministic dependency failures were found before runtime.
2927

3028
## Enforcement Notes
3129

docs/dev/reports/dependency_hydration_reuse_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Dependency Hydration Reuse Report
22

3-
Generated: 2026-05-26T21:52:45.136Z
4-
Status: SKIP
3+
Generated: 2026-05-26T22:00:48.031Z
4+
Status: PASS
55

66
## Summary
77

docs/dev/reports/execution_graph_reuse_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Execution Graph Reuse Report
22

3-
Generated: 2026-05-26T21:52:45.136Z
4-
Status: SKIP
3+
Generated: 2026-05-26T22:00:48.031Z
4+
Status: PASS
55

66
## Summary
77

docs/dev/reports/failure_fingerprint_report.md

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
# Failure Fingerprint Report
22

3-
Generated: 2026-05-26T21:52:45.136Z
4-
Status: WARN
3+
Generated: 2026-05-26T22:00:48.031Z
4+
Status: PASS
55

66
## Summary
77

8-
Deterministic setup failures: 4
8+
Deterministic setup failures: 0
99
Runtime failures: 0
1010
Flaky/transient failures: 0
1111
Infrastructure failures: 0
@@ -14,10 +14,7 @@ Infrastructure failures: 0
1414

1515
| Fingerprint | Category | Rule | Lane | Source | Retry Allowed | Diagnostic |
1616
| --- | --- | --- | --- | --- | --- | --- |
17-
| 8a34b1f6897ef32e | deterministic setup failure | lane-compilation-failures | invalid-targeted-closeout-lane | lane compilation | No | Unknown lane requested: invalid-targeted-closeout-lane |
18-
| bfa111cdb8feb351 | deterministic setup failure | lane-compilation-failures | setup | lane compilation | No | Unknown lane requested: invalid-targeted-closeout-lane |
19-
| e9a7db048b3390cb | deterministic setup failure | lane-compilation-failures | setup | dependency validation | No | Unknown lane requested before dependency gating: invalid-targeted-closeout-lane |
20-
| d77953343f5cb155 | deterministic setup failure | lane-compilation-failures | setup | dependency validation | No | Lane compilation failed; dependency-gated runtime scheduling is blocked. |
17+
| none | none | none | none | none | No | No failures observed during deterministic classification. |
2118

2219
## Known Deterministic Fingerprint Rules
2320

docs/dev/reports/filesystem_scan_reduction_report.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,18 @@
11
# Filesystem Scan Reduction Report
22

3-
Generated: 2026-05-26T21:52:20.631Z
3+
Generated: 2026-05-26T22:01:52.177Z
44
Status: PASS
55

66
## Scan Enforcement
77

88
| Path | Status | Reason |
99
| --- | --- | --- |
10-
| tests/playwright | PREVENTED | Targeted lanes supplied explicit spec files; global Playwright discovery was not used. |
11-
| tests/helpers | SCOPED | Helper discovery used the targeted import graph instead of enumerating every helper. |
12-
| games/ | SCOPED | Game fixture discovery used explicit manifest/path references from targeted files. |
13-
| tests/playwright/engine | SKIP | Unselected lane directory discovery was skipped. |
14-
| tests/playwright/games | SKIP | Unselected lane directory discovery was skipped. |
15-
| tests/playwright/integration | SCOPED | Selected lane discovery was restricted to explicit target specs. |
16-
| tests/playwright/tools | SKIP | Unselected lane directory discovery was skipped. |
10+
| tests/playwright | BROAD | Standalone structural audit intentionally enumerated all Playwright ownership buckets. |
11+
| tests/helpers | BROAD | Standalone structural audit intentionally checked all shared helper ownership. |
1712

1813
## Runtime Savings Observations
1914

20-
- Scoped discovery prevented broad Playwright lane-directory enumeration for targeted execution.
15+
- Standalone ownership validation used broad mode by design; targeted lane runner supplies scoped discovery inputs.
2116
- Helper and fixture inputs are explicit, allowing the runner to cache the discovery map within one execution cycle.
2217
- Deterministic discovery-scope failures block Playwright launch instead of expanding into fallback lanes.
2318
- Full samples smoke remains outside targeted discovery unless samples scope is explicitly active.

docs/dev/reports/incremental_validation_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Incremental Validation Report
22

3-
Generated: 2026-05-26T21:52:45.137Z
3+
Generated: 2026-05-26T22:00:48.032Z
44
Status: PASS
55

66
## Reuse Summary

docs/dev/reports/lane_compilation_report.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Lane Compilation Report
22

3-
Generated: 2026-05-26T21:52:45.136Z
4-
Status: FAIL
3+
Generated: 2026-05-26T22:00:48.031Z
4+
Status: PASS
55

66
## Lane Graph
77

@@ -13,11 +13,10 @@ Status: FAIL
1313
| integration | SKIP | Workspace, tool, game index, and manifest handoff behavior | tests/playwright/integration/GameIndexPreviewManifestResolution.spec.mjs | C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/integration/GameIndexPreviewManifestResolution.spec.mjs --grep Pong --project=playwright --workers=1 --reporter=list | Lane was not selected. |
1414
| engine-src | SKIP | src/ engine and shared runtime capability behavior | tests/core/EngineCoreBoundaryBaseline.test.mjs; tests/core/FrameClock.test.mjs; tests/core/FixedTicker.test.mjs; tests/assets/AssetLoaderSystem.test.mjs; tests/audio/AudioService.test.mjs; tests/input/InputMap.test.mjs; tests/input/KeyboardState.test.mjs; tests/input/MouseState.test.mjs; tests/input/GamepadInputAdapter.test.mjs; tests/input/GamepadHapticsService.test.mjs; tests/render/Renderer.test.mjs | C:\nvm4w\nodejs\node.exe scripts/run-node-test-files.mjs tests/core/EngineCoreBoundaryBaseline.test.mjs tests/core/FrameClock.test.mjs tests/core/FixedTicker.test.mjs tests/assets/AssetLoaderSystem.test.mjs tests/audio/AudioService.test.mjs tests/input/InputMap.test.mjs tests/input/KeyboardState.test.mjs tests/input/MouseState.test.mjs tests/input/GamepadInputAdapter.test.mjs tests/input/GamepadHapticsService.test.mjs tests/render/Renderer.test.mjs | Lane was not selected. |
1515
| samples | SKIP | Affected samples lane, on request only | tests/samples/SamplesProgramCombinedPass.test.mjs; tests/samples/FullscreenRuleEnforcement.test.mjs | C:\nvm4w\nodejs\node.exe scripts/run-node-test-files.mjs tests/samples/SamplesProgramCombinedPass.test.mjs tests/samples/FullscreenRuleEnforcement.test.mjs | Lane was not selected. |
16-
| invalid-targeted-closeout-lane | FAIL | unknown | none | none | Requested lane does not exist in laneDefinitions. |
1716

1817
## Compilation Failures
1918

20-
- Unknown lane requested: invalid-targeted-closeout-lane
19+
No lane compilation failures.
2120

2221
## Deterministic Setup Rules
2322

docs/dev/reports/lane_deduplication_report.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# Lane Deduplication Report
22

3-
Generated: 2026-05-26T21:52:45.136Z
3+
Generated: 2026-05-26T22:00:48.031Z
44
Status: PASS
55

66
## Summary
77

8-
Raw lane requests: invalid-targeted-closeout-lane
9-
Unique scheduled lanes: invalid-targeted-closeout-lane
8+
Raw lane requests: none
9+
Unique scheduled lanes: none
1010
Prevented duplicate lane executions: 0
1111
Prevented browser launches: 0
1212
Prevented Workspace lane reruns: 0

docs/dev/reports/lane_input_validation_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Lane Input Validation Report
22

3-
Generated: 2026-05-26T21:52:45.137Z
4-
Status: SKIP
3+
Generated: 2026-05-26T22:00:48.032Z
4+
Status: PASS
55

66
## Input Files
77

docs/dev/reports/lane_runtime_optimization_report.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Lane Runtime Optimization Report
22

3-
Generated: 2026-05-26T21:52:45.136Z
4-
Status: SKIP
3+
Generated: 2026-05-26T22:00:48.031Z
4+
Status: PASS
55

66
## Runtime Cost Summary
77

@@ -12,7 +12,7 @@ Reused dependency hydration: 0
1212
Prevented graph rebuilds: 0
1313
Prevented redundant initialization: 0
1414
Prevented redundant browser launches: 0
15-
Prevented redundant lane execution: 0
15+
Prevented redundant lane execution: 6
1616
Baseline Playwright/browser launches: 0
1717
Scheduled Playwright/browser launches: 0
1818

@@ -22,9 +22,7 @@ No runtime lanes are eligible for scheduling.
2222

2323
## Scheduling Blockers
2424

25-
- Unknown lane requested: invalid-targeted-closeout-lane
26-
- Unknown lane requested before dependency gating: invalid-targeted-closeout-lane
27-
- Lane compilation failed; dependency-gated runtime scheduling is blocked.
25+
No zero-browser, compilation, or dependency blockers were found.
2826

2927
## Lane Plans
3028

0 commit comments

Comments
 (0)