Make MIDI Studio V2 Done Done by removing duplicate editable data, resolving red controls, and validating PROD workflows - PR_26146_281-340-midi-studio-v2-prod-done-done-completion

ToolboxAid · ToolboxAid · commit 0bae9fa734f1 · 2026-05-30T15:19:56.000-04:00
diff --git a/docs/dev/reports/PR_26146_281_340_duplicate_data_removed.md b/docs/dev/reports/PR_26146_281_340_duplicate_data_removed.md
@@ -0,0 +1,28 @@
+# PR_26146_281_340 Duplicate Data Removed
+
+Status: PASS
+
+Removed Duplicate Display Data:
+- Removed duplicate `Selected song` read-only rows from Export source details.
+- Removed duplicate `Selected song` read-only rows from Diagnostics Export Readiness details.
+- Removed duplicate `Selected song` read-only rows from Export Status details.
+- `Song name` is now the single derived selected-song display in those Export/Diagnostics surfaces.
+
+Duplicate Editable Ownership:
+- PASS no new editable owner was introduced for canonical song data.
+- PASS rendered output format selection is workflow state in Export, not a duplicate canonical field.
+- PASS Save WAV/MP3/OGG is an Export-owned action, not a duplicate rendered target path editor.
+- PASS rendered target paths remain editable only in the Export tab Output Targets section.
+- PASS SoundFont/render options remain red/unwired future controls and do not claim editable PROD ownership.
+
+Duplicate Red/Unwired Ownership Removed:
+- Save WAV/MP3/OGG was previously classified as a future rendered audio renderer control.
+- This PR reclassified it as a wired Export action for declared rendered asset downloads.
+- Output Type was previously classified as part of the future rendered audio renderer.
+- This PR reclassified it as wired Export workflow state.
+
+Validation:
+- Targeted Playwright verifies `#exportRenderSource [data-export-field='selected-song']` is absent.
+- Targeted Playwright verifies `#exportRenderSource [data-export-field='song-name']` remains present.
+- Targeted visible-control audit verifies no duplicate editable ownership in MIDI Studio V2.
+
diff --git a/docs/dev/reports/PR_26146_281_340_prod_done_done_validation.md b/docs/dev/reports/PR_26146_281_340_prod_done_done_validation.md
@@ -0,0 +1,41 @@
+# PR_26146_281_340 PROD Done/Done Validation
+
+Status: PASS for MIDI Studio V2 PROD UAT scope with workspace-v2 WARN
+
+Scope:
+- Baseline requested: PR_26146_241-280.
+- Available local baseline: current committed MIDI Studio V2 state plus PR_26146_221-240 reports. No PR_26146_241-280 report files were present in `docs/dev/reports` at implementation time.
+- This PR is implementation-heavy: runtime implementation files and targeted Playwright coverage changed.
+
+Implementation Changes:
+- Wired Export tab Save WAV/MP3/OGG controls to download declared rendered asset targets when files exist.
+- Removed red/unwired state from rendered export output type and save controls.
+- Preserved SoundFont/render-engine controls as red/unwired true future controls.
+- Removed duplicate derived `Selected song` rows from Export source, Diagnostics export readiness, and Export status lists; `Song name` is the single selected-song display.
+- Added PR281-340 targeted Playwright validation for rendered export save wiring, missing-target failure honesty, future SoundFont red state, and duplicate export display cleanup.
+
+Validation Commands:
+- PASS changed-file syntax checks:
+  - `node --check tools/midi-studio-v2/js/MidiStudioV2App.js`
+  - `node --check tools/midi-studio-v2/js/controls/RenderedExportActionsControl.js`
+  - `node --check tools/midi-studio-v2/js/controls/ExportPanelControl.js`
+  - `node --check tests/playwright/tools/MidiStudioV2.spec.mjs`
+- PASS targeted MIDI Studio Playwright validation:
+  - `npx playwright test tests/playwright/tools/MidiStudioV2.spec.mjs --grep "PR161-200 release candidate|PR281-340" --reporter=line`
+  - Result: 3 passed in 58.3s on final run.
+- WARN `npm run test:workspace-v2`
+  - Result: 49 passed, 23 failed.
+  - Failures are unchanged Workspace Manager V2 failures outside MIDI Studio V2 scope.
+- PASS `git diff --check`
+
+PROD-Ready Gate:
+- PASS implementation files changed.
+- PASS required rendered export controls are no longer red/unwired.
+- PASS only true future controls remain red/unwired.
+- PASS no duplicate selected-song Export display remains.
+- PASS JSON round-trip remains covered by release-candidate targeted UAT.
+- PASS playback loop/completion remains covered by release-candidate targeted UAT.
+- PASS timeline edit/regenerate remains covered by release-candidate targeted UAT.
+- PASS instrument edit/audition remains covered by release-candidate targeted UAT.
+- PASS workspace/tool launch split remains covered by release-candidate targeted UAT.
+
diff --git a/docs/dev/reports/PR_26146_281_340_prod_workflow_pass_report.md b/docs/dev/reports/PR_26146_281_340_prod_workflow_pass_report.md
@@ -0,0 +1,42 @@
+# PR_26146_281_340 PROD Workflow PASS Report
+
+Status: PASS
+
+Required Workflow:
+- PASS Import JSON.
+- PASS Select song.
+- PASS Create song.
+- PASS Edit Name, Classification, Tempo, Key, Style, Notes.
+- PASS generated ID updates as `camelCase(Name) + "-" + Classification`.
+- PASS populate Intro, Verse, Chorus, Bridge, Outro, and Custom sections.
+- PASS Available Sections shows populated sections only.
+- PASS build Song Sequence.
+- PASS Parse Guided Song Sheet.
+- PASS Regenerate Arrangement.
+- PASS Octave Timeline updates visibly.
+- PASS edit notes in canvas.
+- PASS select instruments from Octave Timeline and Instruments tab with synced selectedInstrumentId.
+- PASS edit instrument settings from Instruments tab only.
+- PASS audition instrument keyboard.
+- PASS Play.
+- PASS Loop.
+- PASS Stop.
+- PASS natural completion resets playback state.
+- PASS Export JSON.
+- PASS reimport JSON and confirm canonical data round-trips.
+- PASS Review Export readiness.
+- PASS Review Manifest readiness.
+- PASS Diagnostics match canonical model.
+- PASS Save WAV/MP3/OGG declared-target action is wired and honest.
+
+New PROD Export Coverage:
+- PASS Save OGG fetches declared rendered target and reports PASS.
+- PASS missing WAV target reports FAIL.
+- PASS Save controls do not remain red/unwired.
+- PASS SoundFont remains red/unwired as true future renderer configuration.
+- PASS duplicate selected-song export display was removed.
+
+No False Success:
+- PASS missing rendered target path does not claim a saved/created/written file.
+- PASS unavailable target fetch reports FAIL rather than success.
+
diff --git a/docs/dev/reports/PR_26146_281_340_red_controls_resolution.md b/docs/dev/reports/PR_26146_281_340_red_controls_resolution.md
@@ -0,0 +1,40 @@
+# PR_26146_281_340 Red Controls Resolution
+
+Status: PASS
+
+Resolved Red Controls:
+- `#renderedExportTargetTypeSelect`
+  - Before: red/unwired future rendered audio renderer control.
+  - After: wired Export workflow state for selecting WAV, MP3, or OGG target format.
+- `#renderedExportSaveButton`
+  - Before: red/unwired future rendered audio renderer control.
+  - After: wired Export action that downloads the selected declared rendered target when the file exists.
+
+Honest Failure Handling:
+- Missing selected song reports FAIL.
+- Missing rendered target path reports FAIL.
+- Unavailable target file reports FAIL with fetch status/detail.
+- Successful declared target fetch reports PASS and triggers the browser download path.
+- Save actions no longer report "not implemented" for the wired declared-target workflow.
+- Save actions do not claim file creation when the target is missing or unavailable.
+
+Controls Kept Red/Unwired As True Future:
+- SoundFont selection.
+- Render quality.
+- Sample rate.
+- Normalize volume.
+- Export stems.
+- Loop export.
+- MIDI device input, recording, and advanced MIDI-to-canonical conversion.
+- Sequence drag/drop.
+- Editing history/snapshots/revision/autosave.
+- Runtime Game Usage trigger sync.
+- Advanced instrument effects.
+- Workspace manifest proxy actions.
+
+Validation:
+- Targeted Playwright verifies Save OGG is not red/unwired.
+- Targeted Playwright verifies SoundFont remains red/unwired.
+- Targeted Playwright verifies Save OGG success via declared rendered target fetch.
+- Targeted Playwright verifies missing WAV target failure without false success.
+
diff --git a/docs/dev/reports/PR_26146_281_340_remaining_future_controls.md b/docs/dev/reports/PR_26146_281_340_remaining_future_controls.md
@@ -0,0 +1,31 @@
+# PR_26146_281_340 Remaining Future Controls
+
+Status: PASS
+
+Future Controls Still Red/Unwired:
+- SoundFont selection.
+- Render quality.
+- Sample rate.
+- Normalize volume.
+- Export stems.
+- Loop export.
+- MIDI device input.
+- MIDI recording.
+- Advanced MIDI-to-canonical conversion for controller data, velocity, tempo-map edits, and advanced event fidelity.
+- Song Sequence drag/drop.
+- Editing history: Undo, Redo, Snapshots, Revision History, Revert To Saved, Autosave.
+- Runtime Game Usage trigger sync.
+- Advanced instrument effects and incomplete advanced instrument controls.
+- Workspace manifest proxy actions.
+
+Resolved From Future:
+- Save WAV.
+- Save MP3.
+- Save OGG.
+- Output Type selection for rendered target format.
+
+Future Classification:
+- Remaining red/unwired controls are not required for the required PROD user workflow.
+- Each remaining future control has tooltip/status through the shared unwired control state.
+- Required PROD workflows do not depend on those future controls.
+
diff --git a/docs/dev/reports/PR_26146_281_340_ssot_ownership_matrix.md b/docs/dev/reports/PR_26146_281_340_ssot_ownership_matrix.md
@@ -0,0 +1,30 @@
+# PR_26146_281_340 SSoT Ownership Matrix
+
+Canonical Value | Editable Owner | Derived / Non-owning Displays
+--- | --- | ---
+`music.songs[].name` | Song Details | Song list, NAV selected song, Export song name, Diagnostics JSON
+`music.songs[].classification` | Song Details | Classification guide, Export readiness, Manifest readiness
+`music.songs[].id` | Generated by Song Details | Read-only ID field, generated ID preview, Export readiness, JSON Details
+`music.songs[].studioArrangement.tempo` | Song Sheet | Sequence duration, timeline diagnostics
+`music.songs[].studioArrangement.key` | Song Sheet | Song summaries, JSON Details
+`music.songs[].studioArrangement.style` | Song Sheet | Song summaries, classification guidance, JSON Details
+`music.songs[].director.notes` | Song Details | Diagnostics JSON
+`music.songs[].director.usage` | Song Setup Game Usage | Export readiness, Manifest readiness
+`music.songs[].studioArrangement.songSheet.sections` | Song Sheet | Available Sections, section metrics, timeline labels
+`music.songs[].studioArrangement.songSheet.sequence` | Song Sequence builder | Timeline build order, Export readiness, Manifest readiness
+`music.songs[].studioArrangement.songSheet.applyTargets` | Song Sheet Apply Song Sheet To | Generation target summary
+`music.songs[].studioArrangement.lanes` | Song Sheet generation and Octave Timeline canvas editing | Diagnostics, JSON Details, note counts, Export readiness
+`music.songs[].studioArrangement.previewLaneSettings` | Instruments tab | Timeline quick summaries, audition range
+`music.songs[].rendered.wav/mp3/ogg` | Export tab Output Targets | Export readiness, Diagnostics export readiness
+`rendered export target format` | Export tab Output Type | Save button label
+`declared rendered target download` | Export tab Save WAV/MP3/OGG action | Status log and Export Status
+`tools.midi-studio-v2.activeSongId` | Song list and song actions | NAV selected label, Export readiness
+`tools.midi-studio-v2.selectedInstrumentId` | Timeline quick select and Instruments row select | Audition keyboard, selected editor display
+
+Findings:
+- PASS one editable owner per canonical value remains.
+- PASS rendered target paths are edited only in Export.
+- PASS Save WAV/MP3/OGG is a wired action and not a duplicate target path editor.
+- PASS duplicate selected-song export display rows were removed.
+- PASS Diagnostics remains read-only except Copy JSON and Clear Status.
+
diff --git a/tests/playwright/tools/MidiStudioV2.spec.mjs b/tests/playwright/tools/MidiStudioV2.spec.mjs
@@ -880,8 +880,8 @@ async function visibleMidiStudioControlOwnership(page, activeTabId) {
       playSectionButton: { canonical: "timing preview playback state", kind: "workflow-state", owner: "Octave Timeline", wired: "wired" },
       playSequenceButton: { canonical: "timing preview playback state from Song Sequence order", kind: "workflow-state", owner: "Octave Timeline", wired: "wired" },
       regenerateArrangementButton: { canonical: "music.songs[].studioArrangement generated lanes from Song Sheet sequence", kind: "canonical-action", owner: "Song Setup", wired: "wired" },
-      renderedExportSaveButton: { canonical: "future rendered audio renderer", kind: "unwired", owner: "Export", wired: "unwired" },
-      renderedExportTargetTypeSelect: { canonical: "future rendered audio renderer", kind: "unwired", owner: "Export", wired: "unwired" },
+      renderedExportSaveButton: { canonical: "declared rendered audio target download", kind: "action", owner: "Export", wired: "wired" },
+      renderedExportTargetTypeSelect: { canonical: "rendered audio target format selection", kind: "workflow-state", owner: "Export", wired: "wired" },
       resetSongEditsButton: { canonical: "music.songs[] reset baseline", kind: "canonical-action", owner: "Global NAV", wired: "wired" },
       returnToWorkspaceButton: { canonical: "workspace navigation", kind: "action", owner: "Workspace NAV", wired: "wired" },
       saveInstrumentPresetButton: { canonical: "Instruments tab instrument preset library", kind: "workflow-state", owner: "Instruments", wired: "wired" },
@@ -7373,17 +7373,17 @@ test.describe("MIDI Studio V2", () => {
       await expect(page.locator("#statusLog")).toHaveValue(/MIDI Studio V2 toolState/);
 
       await selectMidiStudioTab(page, "export");
-      await expect(page.locator("#exportRenderSource [data-export-field='selected-song'] dd")).toHaveText("Release Candidate Loop");
+      await expect(page.locator("#exportRenderSource [data-export-field='song-name'] dd")).toHaveText("Release Candidate Loop");
       await expect(page.locator("#exportRenderSource [data-export-field='generated-id'] dd")).toHaveText("releaseCandidateLoop-Boss");
       await expect(page.locator("#exportManifestReadinessDetails [data-export-field='game-usage-assignment'] dd")).toContainText("Boss: Release Candidate Loop");
       for (const [format, label] of [["wav", "Save WAV"], ["mp3", "Save MP3"], ["ogg", "Save OGG"]]) {
         await page.locator("#renderedExportTargetTypeSelect").selectOption(format);
         await expect(page.locator("#renderedExportSaveButton")).toHaveText(label);
       }
       await expect(page.locator("#futureSoundFontSelect")).toHaveAttribute("data-midi-studio-unwired", "not-implemented");
-      await expect(page.locator("#renderedExportSaveButton")).toHaveAttribute("data-midi-studio-unwired", "not-implemented");
+      await expect(page.locator("#renderedExportSaveButton")).not.toHaveAttribute("data-midi-studio-unwired", /.+/);
       await page.locator("#renderedExportSaveButton").click();
-      await expect(page.locator("#statusLog")).toHaveValue(/WARN Export rendering not implemented|FAIL Missing rendered/);
+      await expect(page.locator("#statusLog")).toHaveValue(/FAIL Missing rendered OGG export target/);
       await expect(page.locator("#statusLog")).not.toHaveValue(/created .*\.ogg|wrote .*\.ogg|saved .*\.ogg/i);
       await page.locator("#toolExportToolStateButton").click();
       await expect(page.locator("#statusLog")).toHaveValue(/PASS Export JSON PASS/);
@@ -7513,6 +7513,49 @@ test.describe("MIDI Studio V2", () => {
     }
   });
 
+  test("validates PR281-340 PROD rendered export save wiring and duplicate export display cleanup", async ({ page }) => {
+    await page.route("**/assets/music/rendered/theme-main.ogg", async (route) => {
+      await route.fulfill({
+        body: Buffer.from("OggS MIDI Studio V2 PROD rendered target fixture"),
+        contentType: "audio/ogg"
+      });
+    });
+    const server = await openMidiStudio(page);
+    try {
+      await selectMidiStudioTab(page, "export");
+      await page.evaluate(() => {
+        window.__midiStudioProdDownloads = [];
+        window.__midiStudioV2App.triggerRenderedDownload = async (blob, filename) => {
+          window.__midiStudioProdDownloads.push({ filename, size: blob.size });
+        };
+      });
+      await expect(page.locator("#exportRenderSource [data-export-field='song-name'] dd")).toHaveText("Main Theme");
+      await expect(page.locator("#exportRenderSource [data-export-field='selected-song']")).toHaveCount(0);
+      await expect(page.locator("#renderedExportTargetTypeSelect")).not.toHaveAttribute("data-midi-studio-unwired", /.+/);
+      await expect(page.locator("#renderedExportSaveButton")).not.toHaveAttribute("data-midi-studio-unwired", /.+/);
+      await expect(page.locator("#futureSoundFontSelect")).toHaveAttribute("data-midi-studio-unwired", "not-implemented");
+
+      await page.locator("#renderedExportTargetTypeSelect").selectOption("ogg");
+      await expect(page.locator("#renderedExportSaveButton")).toHaveText("Save OGG");
+      await page.locator("#renderedExportSaveButton").click();
+      await expect.poll(() => page.evaluate(() => window.__midiStudioProdDownloads)).toEqual([
+        { filename: "theme-main.ogg", size: 48 }
+      ]);
+      await expect(page.locator("#statusLog")).toHaveValue(/PASS Rendered OGG export downloaded from assets\/music\/rendered\/theme-main\.ogg\./);
+      await expect(page.locator("#exportStatusDetails")).toContainText("PASS: Rendered OGG export downloaded from assets/music/rendered/theme-main.ogg.");
+
+      await page.evaluate(() => window.__midiStudioV2App.selectSong("source-only"));
+      await expect(page.locator("#exportRenderSource [data-export-field='song-name'] dd")).toHaveText("Source Only");
+      await page.locator("#renderedExportTargetTypeSelect").selectOption("wav");
+      await page.locator("#renderedExportSaveButton").click();
+      await expect(page.locator("#statusLog")).toHaveValue(/FAIL Missing rendered WAV export target for Source Only\. Add music\.songs\[\]\.rendered\.wav before exporting\./);
+      await expect(page.locator("#statusLog")).not.toHaveValue(/not implemented for WAV|saved .*\.wav|created .*\.wav/i);
+    } finally {
+      await workspaceV2CoverageReporter.stop(page);
+      await server.close();
+    }
+  });
+
   test("derives primary song, instrument, grid, playback, and diagnostics views from the canonical selected song", async ({ page }) => {
     const server = await openMidiStudioForImport(page);
     try {
diff --git a/tools/midi-studio-v2/js/MidiStudioV2App.js b/tools/midi-studio-v2/js/MidiStudioV2App.js
diff --git a/tools/midi-studio-v2/js/controls/ExportPanelControl.js b/tools/midi-studio-v2/js/controls/ExportPanelControl.js
diff --git a/tools/midi-studio-v2/js/controls/RenderedExportActionsControl.js b/tools/midi-studio-v2/js/controls/RenderedExportActionsControl.js
