Fix Toolbox Planned filter tile display - PR_26160_058-toolbox-planned-filter-tiles

ToolboxAid · ToolboxAid · commit 4090ff31c978 · 2026-06-09T13:35:13.000-04:00
diff --git a/docs_build/dev/reports/coverage_changed_js_guardrail.txt b/docs_build/dev/reports/coverage_changed_js_guardrail.txt
@@ -6,17 +6,15 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
+(0%) admin/tool-votes.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) toolbox/toolRegistry.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(77%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 547/547; executed functions 37/48
-(96%) toolbox/tools-page-accordions.js - executed lines 1033/1033; executed functions 108/113
-(100%) admin/tool-votes.js - executed lines 120/120; executed functions 16/16
-(100%) src/engine/api/toolbox-votes-api-client.js - executed lines 28/28; executed functions 4/4
+(50%) src/engine/api/toolbox-votes-api-client.js - executed lines 28/28; executed functions 2/4
+(85%) toolbox/tools-page-accordions.js - executed lines 1033/1033; executed functions 93/109
 
 Guardrail warnings:
+(0%) admin/tool-votes.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) toolbox/toolRegistry.js - WARNING: changed runtime JS file missing from coverage; advisory only
diff --git a/docs_build/dev/reports/playwright_v8_coverage_report.txt b/docs_build/dev/reports/playwright_v8_coverage_report.txt
@@ -12,51 +12,39 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(68%) Toolbox Index - exercised 9 runtime JS files
+(79%) Toolbox Index - exercised 3 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
-(74%) Theme V2 Shared JS - exercised 2 runtime JS files
+(65%) Theme V2 Shared JS - exercised 1 runtime JS files
 
 Changed runtime JS files covered:
+(0%) admin/tool-votes.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) toolbox/toolRegistry.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(77%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 547/547; executed functions 37/48
-(96%) toolbox/tools-page-accordions.js - executed lines 1033/1033; executed functions 108/113
-(100%) admin/tool-votes.js - executed lines 120/120; executed functions 16/16
-(100%) src/engine/api/toolbox-votes-api-client.js - executed lines 28/28; executed functions 4/4
+(50%) src/engine/api/toolbox-votes-api-client.js - executed lines 28/28; executed functions 2/4
+(85%) toolbox/tools-page-accordions.js - executed lines 1033/1033; executed functions 93/109
 
 Files with executed line/function counts where available:
 (38%) src/engine/api/session-api-client.js - executed lines 34/34; executed functions 3/8
-(55%) toolbox/colors/colors.js - executed lines 2147/2147; executed functions 114/206
-(55%) toolbox/project-journey/project-journey.js - executed lines 1003/1003; executed functions 54/99
-(58%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 11/19
-(64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
-(71%) toolbox/assets/assets.js - executed lines 519/519; executed functions 42/59
-(77%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 547/547; executed functions 37/48
-(85%) toolbox/tool-registry-api-client.js - executed lines 148/148; executed functions 23/27
-(96%) toolbox/tools-page-accordions.js - executed lines 1033/1033; executed functions 108/113
-(100%) admin/tool-votes.js - executed lines 120/120; executed functions 16/16
-(100%) src/engine/api/toolbox-votes-api-client.js - executed lines 28/28; executed functions 4/4
-(100%) toolbox/assets/assets-api-client.js - executed lines 17/17; executed functions 3/3
-(100%) toolbox/colors/palette-api-client.js - executed lines 19/19; executed functions 4/4
-(100%) toolbox/project-journey/project-journey-api-client.js - executed lines 12/12; executed functions 2/2
+(43%) toolbox/tool-registry-api-client.js - executed lines 148/148; executed functions 9/21
+(50%) src/engine/api/toolbox-votes-api-client.js - executed lines 28/28; executed functions 2/4
+(53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
+(65%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 547/547; executed functions 30/46
+(85%) toolbox/tools-page-accordions.js - executed lines 1033/1033; executed functions 93/109
 (100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
+(0%) admin/tool-votes.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
-(0%) toolbox/toolRegistry.js - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
+(0%) admin/tool-votes.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/guest-seeds/tool-state-samples.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/helpers/playwrightV8CoverageReporter.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ToolboxRoutePages.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) toolbox/toolRegistry.js - changed JS file not collected as browser runtime coverage
-(77%) assets/theme-v2/js/gamefoundry-partials.js - changed JS file with browser V8 coverage
-(96%) toolbox/tools-page-accordions.js - changed JS file with browser V8 coverage
-(100%) admin/tool-votes.js - changed JS file with browser V8 coverage
-(100%) src/engine/api/toolbox-votes-api-client.js - changed JS file with browser V8 coverage
+(50%) src/engine/api/toolbox-votes-api-client.js - changed JS file with browser V8 coverage
+(85%) toolbox/tools-page-accordions.js - changed JS file with browser V8 coverage
diff --git a/docs_build/dev/reports/toolbox-planned-filter-tiles-report.md b/docs_build/dev/reports/toolbox-planned-filter-tiles-report.md
@@ -0,0 +1,62 @@
+# PR_26160_058 Toolbox Planned Filter Tiles Report
+
+## Branch Validation
+
+| Check | Result | Evidence |
+| --- | --- | --- |
+| Current branch is `main` | PASS | `git branch --show-current` returned `main`. |
+| Local branches reported | PASS | `git branch --list` returned only `* main`. |
+
+## Requirement Checklist
+
+| Requirement | Status | Evidence |
+| --- | --- | --- |
+| Fix Build Path Planned filter so selecting Planned displays all planned tool tiles/rows | PASS | `toolbox/tools-page-accordions.js` now builds Build Path rows from all `visibleInToolsList` registry tools, matching the Planned count. |
+| Keep Planned count DB/registry-driven | PASS | Counts still come from registry-normalized release channels; Playwright asserts `Planned (28)`. |
+| Ensure filter matching uses same normalized status source for counts and visible tiles | PASS | Both counts and Build Path rows now map `registryTools.filter(visibleInToolsList).map(enrichTool)` and use `releaseChannel`. |
+| Preserve Complete as only default active filter | PASS | Build Path defaults remain `complete`; Playwright verifies Complete active and Planned/Wireframe/Beta inactive by default. |
+| Complete default shows Colors only | PASS | Focused Playwright verifies one complete Build Path row and `Colors` visible. |
+| Planned selected shows all planned tools matching count | PASS | Focused Playwright verifies `planned` rows count is `28` and every row has `data-build-path-release-channel="planned"`. |
+| Wireframe selected shows 4 tools | PASS | Focused Playwright verifies `wireframe` rows count is `4`. |
+| Beta selected shows 5 tools | PASS | Focused Playwright verifies `beta` rows count is `5`. |
+| Do not add new features or expand scope | PASS | Changed only Build Path row/filter behavior and targeted assertions/reports. |
+| No inline script/style/event handlers | PASS | Static `rg --pcre2` scan of `toolbox/index.html` found no inline scripts, styles, or event handlers. |
+
+## Validation Performed
+
+| Lane | Command | Result |
+| --- | --- | --- |
+| Branch guard | `git branch --show-current`; `git branch --list` | PASS |
+| Changed-file syntax | `node --check toolbox/tools-page-accordions.js`; `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs` | PASS |
+| Static diff check | `git diff --check` | PASS |
+| Inline HTML guard | `rg --pcre2 -n "<script(?![^>]+src=)|<style[\\s>]|\\son(?:click|change|input|submit|keydown|keyup|load)=" toolbox/index.html` | PASS, no matches |
+| Targeted Toolbox Build Path Playwright | `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "Build Path status filters" --reporter=line` | PASS, 1 passed |
+| Playwright V8 coverage | Generated by focused Playwright run via `workspaceV2CoverageReporter` | PASS, report written to `docs_build/dev/reports/playwright_v8_coverage_report.txt` |
+
+## Impacted Lane
+
+Targeted Toolbox Build Path status-filter lane only.
+
+## Skipped Lanes
+
+| Lane | Decision | Reason |
+| --- | --- | --- |
+| Full samples validation | SKIPPED | Samples were not changed and no shared sample loader/framework was touched. |
+| Broad Toolbox route smoke | SKIPPED | The focused Build Path status-filter test covers the requested behavior. |
+| Full app Playwright suite | SKIPPED | PR scope is limited to Build Path filter matching. |
+
+## Manual Test Notes
+
+1. Open `http://127.0.0.1:5501/toolbox/index.html`.
+2. Click `Build Path`.
+3. Verify Complete is the only active default filter and only Colors is listed.
+4. Click Planned and verify 28 planned rows are listed.
+5. Click Wireframe and verify 4 rows are listed.
+6. Click Beta and verify 5 rows are listed.
+
+## Artifacts
+
+- Codex review diff: `docs_build/dev/reports/codex_review.diff`
+- Changed files: `docs_build/dev/reports/codex_changed_files.txt`
+- V8 coverage: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- Repo-structured ZIP: `tmp/PR_26160_058-toolbox-planned-filter-tiles_20260609_001_delta.zip`
diff --git a/tests/playwright/tools/ToolboxRoutePages.spec.mjs b/tests/playwright/tools/ToolboxRoutePages.spec.mjs
@@ -392,6 +392,88 @@ test("toolbox status kickers, filters, card order, and voting controls work from
   }
 });
 
+test("toolbox Build Path status filters show registry-matched tool rows", async ({ page }) => {
+  const server = await startRepoServer();
+  const failedRequests = [];
+  const pageErrors = [];
+  const consoleErrors = [];
+
+  page.on("response", (response) => {
+    if (response.status() >= 400) {
+      failedRequests.push(`${response.status()} ${response.url()}`);
+    }
+  });
+  page.on("requestfailed", (request) => {
+    failedRequests.push(`FAILED ${request.url()}`);
+  });
+  page.on("pageerror", (error) => {
+    const text = error.stack || error.message;
+    if (!isBrowserExtensionNoise(text)) {
+      pageErrors.push(error.message);
+    }
+  });
+  page.on("console", (message) => {
+    if (message.type() === "error" && !isBrowserExtensionNoise(message.text())) {
+      consoleErrors.push(message.text());
+    }
+  });
+
+  async function expectBuildPathChannel(channel, expectedCount) {
+    await expect(page.locator("[data-build-path-tool]")).toHaveCount(expectedCount);
+    await expect(page.locator("[data-build-path-release-channel]")).toHaveCount(expectedCount);
+    const releaseChannels = await page.locator("[data-build-path-release-channel]").evaluateAll((rows) => (
+      rows.map((row) => row.getAttribute("data-build-path-release-channel"))
+    ));
+    expect(releaseChannels.every((releaseChannel) => releaseChannel === channel)).toBe(true);
+  }
+
+  async function selectBuildPathFilter(channel) {
+    await page.locator(`[data-toolbox-status-filter='${channel}']`).click();
+    for (const releaseChannel of ["planned", "wireframe", "beta", "complete"]) {
+      await expect(page.locator(`[data-toolbox-status-filter='${releaseChannel}']`)).toHaveAttribute(
+        "aria-pressed",
+        String(releaseChannel === channel),
+      );
+    }
+  }
+
+  try {
+    await workspaceV2CoverageReporter.start(page);
+    await setServerSession(server, MOCK_DB_KEYS.users.user1);
+    await page.goto(`${server.baseUrl}/toolbox/index.html`, { waitUntil: "networkidle" });
+    await page.locator("[data-tools-view='build-path']").click();
+
+    await expect(page.locator("[data-toolbox-status-filter]")).toHaveText([
+      "Planned (28)",
+      "Wireframe (4)",
+      "Beta (5)",
+      "Complete (1)",
+    ]);
+    await expect(page.locator("[data-toolbox-status-filter='planned']")).toHaveAttribute("aria-pressed", "false");
+    await expect(page.locator("[data-toolbox-status-filter='wireframe']")).toHaveAttribute("aria-pressed", "false");
+    await expect(page.locator("[data-toolbox-status-filter='beta']")).toHaveAttribute("aria-pressed", "false");
+    await expect(page.locator("[data-toolbox-status-filter='complete']")).toHaveAttribute("aria-pressed", "true");
+    await expect(page.locator("[data-build-path-tool='Colors']")).toBeVisible();
+    await expectBuildPathChannel("complete", 1);
+
+    await selectBuildPathFilter("planned");
+    await expectBuildPathChannel("planned", 28);
+
+    await selectBuildPathFilter("wireframe");
+    await expectBuildPathChannel("wireframe", 4);
+
+    await selectBuildPathFilter("beta");
+    await expectBuildPathChannel("beta", 5);
+
+    expect(failedRequests).toEqual([]);
+    expect(pageErrors).toEqual([]);
+    expect(consoleErrors).toEqual([]);
+  } finally {
+    await workspaceV2CoverageReporter.stop(page);
+    await server.close();
+  }
+});
+
 test("wireframe-only pages expose left center right accordion controls without runtime wiring", async ({ page }) => {
   const server = await startRepoServer();
   const failedRequests = [];
diff --git a/toolbox/tools-page-accordions.js b/toolbox/tools-page-accordions.js
@@ -460,20 +460,17 @@ import { getSessionCurrent } from "../src/engine/api/session-api-client.js";
     }
 
     function getBuildPathRows() {
-        let order = 0;
-        return buildPathGroups.flatMap((group) => group.tools.map((title) => {
-            const tool = sourceToolByTitle(title);
-            if (!tool) {
-                return null;
-            }
-            order += 1;
-            return {
-                order,
+        return registryTools
+            .filter((tool) => tool.visibleInToolsList === true)
+            .map((tool) => enrichTool(tool))
+            .filter(isVisibleForStatusFilter)
+            .sort((left, right) => (left.order ?? Number.MAX_SAFE_INTEGER) - (right.order ?? Number.MAX_SAFE_INTEGER) || left.title.localeCompare(right.title))
+            .map((tool, index) => ({
+                order: index + 1,
                 status: tool.releaseChannel,
                 statusLabel: tool.releaseChannelLabel,
                 tool
-            };
-        }).filter(Boolean)).filter((row) => isVisibleForStatusFilter(row.tool));
+            }));
     }
 
     function createBuildPathSummary() {
@@ -673,7 +670,10 @@ import { getSessionCurrent } from "../src/engine/api/session-api-client.js";
             button.title = releaseChannelHelp(channel);
             button.textContent = `${releaseChannelLabel(channel)} (${counts[channel] || 0})`;
             button.addEventListener("click", () => {
-                if (visibleReleaseChannels.has(channel)) {
+                if (currentMode === "build-path") {
+                    visibleReleaseChannels.clear();
+                    visibleReleaseChannels.add(channel);
+                } else if (visibleReleaseChannels.has(channel)) {
                     visibleReleaseChannels.delete(channel);
                 } else {
                     visibleReleaseChannels.add(channel);
