You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs_build/dev/reports/coverage_changed_js_guardrail.txt
+1-5Lines changed: 1 addition & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -7,12 +7,8 @@ Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
7
7
8
8
Changed runtime JS files considered:
9
9
(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
10
-
(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-`docs_build/dev/PROJECT_INSTRUCTIONS.md` was read before execution.
13
+
-`docs_build/pr/PR_26161_005-objects-role-type-save-fix/BUILD_PR.md` was not present.
14
+
-`docs_build/pr/BUILD_PR.md` was stale and unrelated.
15
+
- Execution used the user-provided PR_26161_005 request as the active BUILD source.
16
+
17
+
## Requirement Checklist
18
+
19
+
- PASS: Kept Objects as a clickable `Wireframe` tool; no metadata status change was made.
20
+
- PASS: Removed the visible `Type` column and dropdown from the Objects table.
21
+
- PASS: Kept `Role` as the broad creator-facing category with `Hero`, `Enemy`, `Projectile`, `Platform`, `Wall`, `Collectible`, `Hazard`, `Goal`, `Spawner`, `UI`, and `Custom`.
22
+
- PASS: Derived the hidden internal object-model family from Role for the shared validator instead of asking creators to choose overlapping Type values.
- PASS: Fixed edit save for existing Sprite objects by carrying the linked sprite asset through the edit row.
25
+
- PASS: Sprite render rows create or resolve a real shared sprite asset before entering the saved table.
26
+
- PASS: `None` render rows save without requiring a Render Asset.
27
+
- PASS: Saved Sprite rows validate with a linked asset; missing Sprite asset is allowed only during pre-handoff row validation.
28
+
- PASS: Added no sample JSON alignment, auth behavior, production DB behavior, or unrelated tool rewrites.
29
+
30
+
## Implementation Evidence
31
+
32
+
-`toolbox/objects/index.html` now shows table columns `Name`, `Role`, `State`, `Render`, `Traits`, `Render Asset`, and `Actions`.
33
+
-`toolbox/objects/objects.js` adds Role-to-internal-family derivation and removes the visible Type option flow.
34
+
-`toolbox/objects/objects.js` preserves an existing Sprite asset key/preview path during edit mode and validates Sprite rows after asset handoff.
35
+
-`tests/playwright/tools/ObjectsTool.spec.mjs` verifies no Type column/dropdown, no Object Types panel, Role choices, Add disable, None-render save, Sprite create/resolve, edit-save without handoff error, and Toolbox click-through.
- WARN: The coverage helper also reports prior-HEAD changed files such as `src/dev-runtime/guest-seeds/tool-metadata-inventory.js` and `src/engine/object-model/objectModelRegistry.js`; those files are not modified by PR_005 and are advisory for this PR.
53
+
54
+
## Skipped Lanes
55
+
56
+
- SKIP: Full samples validation. Safe to skip because no sample JSON, sample manifests, sample launch paths, or engine runtime behavior changed.
57
+
- SKIP: Toolbox/Admin metadata Playwright. Safe to skip because PR_005 did not change tool metadata; Objects clickability as wireframe is covered by targeted Objects Playwright.
58
+
- SKIP: Sprite Editor launch/handoff Playwright. Safe to skip because no Sprite Editor route or context contract files changed; Objects still uses the existing Sprite Editor URL contract.
59
+
- SKIP: Production DB/auth/persistence validation. Safe to skip because the change only uses existing mock-adapter/shared asset contracts and adds no auth, production DB, or persistence behavior.
60
+
61
+
## Manual Notes
62
+
63
+
- Role is now the only creator-facing category field in the Objects table.
64
+
- The internal object model type remains present only as derived data required by the shared validator.
65
+
- Behavior/physics configuration remains out of scope and belongs to a later rules/physics/events PR.
(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
21
-
(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
Copy file name to clipboardExpand all lines: toolbox/objects/index.html
+3-5Lines changed: 3 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -18,7 +18,7 @@
18
18
<divclass="container">
19
19
<divclass="kicker">Toolbox / Objects</div>
20
20
<h1>Objects</h1>
21
-
<pclass="lede">Define object setup with static and dynamic body types, broad roles, and sprite render assets handed off through shared asset records.</p>
21
+
<pclass="lede">Define object setup with broad roles and sprite render assets handed off through shared asset records.</p>
22
22
</div>
23
23
</section>
24
24
<sectionclass="section">
@@ -32,7 +32,7 @@ <h2>Objects</h2>
32
32
<detailsclass="vertical-accordion" open>
33
33
<summary>Object Setup</summary>
34
34
<divclass="accordion-body content-stack">
35
-
<pdata-objects-setup-context>Use the table to define object names, body types, roles, state, and optional sprite render handoff.</p>
35
+
<pdata-objects-setup-context>Use the table to define object names, roles, state, and optional sprite render handoff.</p>
0 commit comments