Advance MIDI Studio V2 production workflow with section templates regeneration safety instrument polish and export readiness - PR_26146_089-092-midi-studio-v2-production-workflow-lane

Author: ToolboxAid

docs/dev/reports/PR_26146_089_092_bundle_validation.md

@@ -0,0 +1,43 @@
+# PR_26146_089-092 Bundle Validation
+
+## Scope
+- Completed MIDI Studio V2 production workflow lane for section templates, safe regeneration, instrument workflow polish, and export readiness.
+- Baseline: PR_26146_085-088.
+
+## Changed Surface
+- `tools/midi-studio-v2/index.html`
+- `tools/midi-studio-v2/js/bootstrap.js`
+- `tools/midi-studio-v2/js/MidiStudioV2App.js`
+- `tools/midi-studio-v2/js/controls/SongSheetControl.js`
+- `tools/midi-studio-v2/js/controls/InstrumentGridControl.js`
+- `tools/midi-studio-v2/js/controls/ExportPanelControl.js`
+- `tests/playwright/tools/MidiStudioV2.spec.mjs`
+
+## Validation
+- PASS: changed-file syntax checks
+  - `node --check tools/midi-studio-v2/js/controls/SongSheetControl.js`
+  - `node --check tools/midi-studio-v2/js/MidiStudioV2App.js`
+  - `node --check tools/midi-studio-v2/js/controls/ExportPanelControl.js`
+  - `node --check tools/midi-studio-v2/js/controls/InstrumentGridControl.js`
+  - `node --check tests/playwright/tools/MidiStudioV2.spec.mjs`
+- PASS: targeted MIDI Studio Playwright
+  - `npx playwright test tests/playwright/tools/MidiStudioV2.spec.mjs -g "PR089-092"`
+  - Result: 1 passed.
+- PASS: neighboring MIDI Studio regression cluster
+  - `npx playwright test tests/playwright/tools/MidiStudioV2.spec.mjs -g "PR085-088|PR089-092|keeps Export tab usable|enforces SSoT export ownership|audits PR065 visible control ownership"`
+  - Result: 5 passed.
+- FAIL: `npm run test:workspace-v2`
+  - Result: 48 passed, 24 failed in `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`.
+  - Failures are outside the MIDI Studio V2 changed surface.
+  - Representative failures: Input Mapping V2 capture state did not clear; multiple Workspace Manager V2 tests expected 11 tool tiles but observed 12; one temporary UAT manifest seeding test timed out.
+  - Runner-generated generic workspace report side effects were restored after recording this result.
+- PASS: `git diff --check`
+  - Only Git CRLF normalization warnings were printed.
+
+## Playwright Coverage Notes
+- `docs/dev/reports/playwright_v8_coverage_report.txt` and `docs/dev/reports/coverage_changed_js_guardrail.txt` were refreshed by the targeted MIDI Studio Playwright run.
+- Changed runtime JS coverage guardrail reports no warnings for the changed MIDI runtime JS files.
+
+## Result
+PASS for changed-file syntax, targeted MIDI Studio behavior, neighboring MIDI Studio regressions, coverage guardrail, and diff hygiene.
+Required workspace-v2 command was executed and failed in unrelated Workspace Manager/Input Mapping/Text to Speech areas.

docs/dev/reports/PR_26146_089_092_instrument_workflow_audit.md

@@ -0,0 +1,30 @@
+# PR_26146_089-092 Instrument Workflow Audit
+
+## Ownership
+- Instrument lane data remains owned by `music.songs[].studioArrangement.lanes`.
+- Preview instrument settings remain owned by `music.songs[].studioArrangement.previewLaneSettings`.
+- No engine core ownership was changed.
+
+## Duplication
+- Duplicating the selected instrument still copies lane text and preview settings.
+- The duplicate is inserted after the source lane and becomes the selected instrument.
+- Workflow status is exposed on the instrument list, timeline quick list, and audition keyboard through `data-instrument-workflow-status`.
+
+## Ordering
+- Move Up and Move Down continue to reorder the canonical lane key order.
+- The selected instrument remains selected after reordering.
+- Selection evidence is exposed through `data-selected-instrument-id` on:
+  - `#instrumentList`
+  - `#timelineInstrumentQuickList`
+  - `#instrumentAuditionKeyboard`
+  - `#selectedInstrumentEditor`
+
+## Audition
+- Audition keyboard rendering is synchronized to the selected instrument ID.
+- Audition controls preserve lane settings for volume, pan, transpose, velocity, and octave range.
+- The targeted Playwright validation clicks an audition note after duplication and confirms the selected duplicate is used.
+
+## Export Readiness
+- Export tab now reports selected song, classification, generated ID, and WAV/MP3/OGG target readiness.
+- Save WAV, Save MP3, and Save OGG remain owned by the Export tab.
+- SoundFont and future render controls remain visible and red/unwired.

docs/dev/reports/PR_26146_089_092_template_and_regeneration_map.md

@@ -0,0 +1,38 @@
+# PR_26146_089-092 Template and Regeneration Map
+
+## Section Templates
+- Built-in templates are defined in `SongSheetControl` for Intro, Verse, Chorus, Bridge, and Outro.
+- Template application writes starting chord progressions into the selected first-class section editor only.
+- Section fields remain editable after template application.
+- Custom sections are preserved because template application does not rewrite the custom section textarea.
+- Populated section rules remain unchanged: empty named/custom sections are omitted from Available Sections and from generated sequence input.
+
+## Template Defaults
+- Intro: `C F G C`
+- Verse: `C Am F G`
+- Chorus: `F G C C`
+- Bridge: `Dm G Em Am`
+- Outro: `F G C`
+
+## Safe Regeneration
+- Regenerate Arrangement now performs a preflight before rebuilding generated target lanes.
+- The preflight counts generated and manual events in currently selected generated target lanes.
+- If manual target-lane notes are found, the first click does not overwrite the grid.
+- The Regenerate button switches to confirmation state through `data-regeneration-pending="true"` and `Confirm Regenerate Arrangement`.
+- A second click with the same Song Sheet source and target selection confirms regeneration.
+- Any Song Sheet field, sequence, template, parse, or target change clears pending confirmation.
+
+## Summary Fields
+- Song Sheet summary now includes:
+  - Generated notes before regeneration
+  - Manual notes before regeneration
+  - Regeneration protection
+- Confirmed regeneration keeps those counts visible in the summary after the arrangement is rebuilt.
+
+## Canonical Sync
+- Parse and confirmed regenerate continue to update:
+  - `music.songs[].studioArrangement.songSheet.sections`
+  - `music.songs[].studioArrangement.songSheet.sequence`
+  - `music.songs[].studioArrangement.songSheet.applyTargets`
+  - generated lanes in `music.songs[].studioArrangement.lanes`
+  - Octave Timeline and JSON Details through existing normalization.