Skip to content

Commit 7036188

Browse files
authored
PR_26171_033 idea board inline accordion cell
Move the Idea Board accordion chevron into the Idea cell and keep Notes count informational. Validation: - node --check toolbox/idea-board/index.js - node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs - node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs - npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line - npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"
1 parent 08ae3a8 commit 7036188

14 files changed

Lines changed: 637 additions & 1833 deletions
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading

docs_build/dev/codex_commands.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
# Codex Commands
22

33
## PR
4-
- `PR_26171_032-idea-board-accordion-table-model`
4+
- `PR_26171_033-idea-board-inline-accordion-cell`
55

66
## Source Documents
77
- `docs_build/dev/PROJECT_INSTRUCTIONS.md`
8-
- `docs_build/pr/PLAN_PR_26171_032-idea-board-accordion-table-model.md`
9-
- `docs_build/pr/BUILD_PR_26171_032-idea-board-accordion-table-model.md`
10-
- `docs_build/pr/APPLY_PR_26171_032-idea-board-accordion-table-model.md`
8+
- `docs_build/pr/PLAN_PR_26171_033-idea-board-inline-accordion-cell.md`
9+
- `docs_build/pr/BUILD_PR_26171_033-idea-board-inline-accordion-cell.md`
10+
- `docs_build/pr/APPLY_PR_26171_033-idea-board-inline-accordion-cell.md`
1111

1212
## Git Workflow Commands
1313
- `git branch --show-current`
1414
- `git status -sb`
1515
- `git branch --list`
1616
- `git pull --ff-only origin main`
17-
- `git switch -c codex/pr-26171-032-idea-board-accordion-table-model`
17+
- `git switch -c codex/pr-26171-033-idea-board-inline-accordion-cell`
1818

1919
## Inspection Commands
2020
- `Get-Content -Raw docs_build/dev/PROJECT_INSTRUCTIONS.md`
@@ -27,13 +27,11 @@
2727
- `node --check toolbox/idea-board/index.js`
2828
- `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
2929
- `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`
30-
- `node -e "<Idea Board inline HTML restriction guard>"`
3130
- `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line`
3231
- `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"`
33-
- `npm run test:workspace-v2`
3432

3533
## Artifact Commands
3634
- Generate `docs_build/dev/reports/codex_changed_files.txt`
3735
- Generate `docs_build/dev/reports/codex_review.diff`
38-
- Create `tmp/PR_26171_032-idea-board-accordion-table-model_delta.zip`
36+
- Create `tmp/PR_26171_033-idea-board-inline-accordion-cell_delta.zip`
3937
- Verify ZIP size and repo-relative paths

docs_build/dev/commit_comment.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
PR_26171_032 idea board accordion table model
1+
PR_26171_033 idea board inline accordion cell
22

3-
- reshape Idea Board in-page data into idea and note table records
4-
- default to collapsed notes with row-level expand/collapse controls
3+
- move accordion chevron into the Idea table cell
4+
- keep Notes count informational instead of a toggle
55
- update targeted Playwright coverage and reports
Lines changed: 28 additions & 93 deletions
Original file line numberDiff line numberDiff line change
@@ -1,117 +1,52 @@
1-
# Codex Changed Files - PR_26171_032-idea-board-accordion-table-model
1+
# Codex Changed Files - PR_26171_033-idea-board-inline-accordion-cell
22

33
## Git Workflow
4-
- Current branch: `codex/pr-26171-032-idea-board-accordion-table-model`
4+
- Current branch: `codex/pr-26171-033-idea-board-inline-accordion-cell`.
55
- Expected starting branch: `main` (PASS before branch creation).
6-
- Created branch: `codex/pr-26171-032-idea-board-accordion-table-model`.
6+
- Created branch: `codex/pr-26171-033-idea-board-inline-accordion-cell`.
77
- Push result: pending until after commit.
88
- PR URL: pending until after push.
99
- Merge result: pending until after PR validation/merge.
1010
- Final main commit: pending until after merge and final pull.
1111

1212
## Changed Files
13+
- assets/theme-v2/images/gfs-chevron-down.svg
14+
- assets/theme-v2/images/gfs-chevron-up.svg
1315
- docs_build/dev/codex_commands.md
1416
- docs_build/dev/commit_comment.txt
15-
- docs_build/dev/reports/dependency_gating_report.md
16-
- docs_build/dev/reports/dependency_hydration_reuse_report.md
17-
- docs_build/dev/reports/execution_graph_reuse_report.md
18-
- docs_build/dev/reports/failure_fingerprint_report.md
19-
- docs_build/dev/reports/filesystem_scan_reduction_report.md
20-
- docs_build/dev/reports/incremental_validation_report.md
21-
- docs_build/dev/reports/lane_compilation_report.md
22-
- docs_build/dev/reports/lane_deduplication_report.md
23-
- docs_build/dev/reports/lane_input_validation_report.md
24-
- docs_build/dev/reports/lane_runtime_optimization_report.md
25-
- docs_build/dev/reports/lane_snapshot_report.md
26-
- docs_build/dev/reports/lane_warm_start_report.md
27-
- docs_build/dev/reports/monolith_trigger_removal_report.md
28-
- docs_build/dev/reports/persistent_lane_manifest_report.md
29-
- docs_build/dev/reports/playwright_discovery_ownership_report.md
30-
- docs_build/dev/reports/playwright_discovery_scope_report.md
31-
- docs_build/dev/reports/playwright_structure_audit.md
32-
- docs_build/dev/reports/retry_suppression_report.md
33-
- docs_build/dev/reports/slow_path_pruning_report.md
34-
- docs_build/dev/reports/static_validation_report.md
35-
- docs_build/dev/reports/targeted_file_manifest_report.md
36-
- docs_build/dev/reports/test_cleanup_performance_report.md
37-
- docs_build/dev/reports/test_cleanup_routing_report.md
38-
- docs_build/dev/reports/testing_lane_execution_report.md
39-
- docs_build/dev/reports/validation_cache_report.md
40-
- docs_build/dev/reports/zero_browser_preflight_report.md
41-
- docs_build/pr/APPLY_PR_26171_032-idea-board-accordion-table-model.md
42-
- docs_build/pr/BUILD_PR_26171_032-idea-board-accordion-table-model.md
43-
- docs_build/pr/PLAN_PR_26171_032-idea-board-accordion-table-model.md
17+
- docs_build/dev/reports/codex_changed_files.txt
18+
- docs_build/dev/reports/codex_review.diff
19+
- docs_build/dev/reports/coverage_changed_js_guardrail.txt
20+
- docs_build/dev/reports/playwright_v8_coverage_report.txt
21+
- docs_build/pr/APPLY_PR_26171_033-idea-board-inline-accordion-cell.md
22+
- docs_build/pr/BUILD_PR_26171_033-idea-board-inline-accordion-cell.md
23+
- docs_build/pr/PLAN_PR_26171_033-idea-board-inline-accordion-cell.md
4424
- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
4525
- tests/playwright/tools/ToolboxRoutePages.spec.mjs
46-
- toolbox/idea-board/index.html
4726
- toolbox/idea-board/index.js
4827

49-
## Name Status
50-
- M docs_build/dev/codex_commands.md
51-
- M docs_build/dev/commit_comment.txt
52-
- M docs_build/dev/reports/dependency_gating_report.md
53-
- M docs_build/dev/reports/dependency_hydration_reuse_report.md
54-
- M docs_build/dev/reports/execution_graph_reuse_report.md
55-
- M docs_build/dev/reports/failure_fingerprint_report.md
56-
- M docs_build/dev/reports/filesystem_scan_reduction_report.md
57-
- M docs_build/dev/reports/incremental_validation_report.md
58-
- M docs_build/dev/reports/lane_compilation_report.md
59-
- M docs_build/dev/reports/lane_deduplication_report.md
60-
- M docs_build/dev/reports/lane_input_validation_report.md
61-
- M docs_build/dev/reports/lane_runtime_optimization_report.md
62-
- M docs_build/dev/reports/lane_snapshot_report.md
63-
- M docs_build/dev/reports/lane_warm_start_report.md
64-
- M docs_build/dev/reports/monolith_trigger_removal_report.md
65-
- M docs_build/dev/reports/persistent_lane_manifest_report.md
66-
- M docs_build/dev/reports/playwright_discovery_ownership_report.md
67-
- M docs_build/dev/reports/playwright_discovery_scope_report.md
68-
- M docs_build/dev/reports/playwright_structure_audit.md
69-
- M docs_build/dev/reports/retry_suppression_report.md
70-
- M docs_build/dev/reports/slow_path_pruning_report.md
71-
- M docs_build/dev/reports/static_validation_report.md
72-
- M docs_build/dev/reports/targeted_file_manifest_report.md
73-
- M docs_build/dev/reports/test_cleanup_performance_report.md
74-
- M docs_build/dev/reports/test_cleanup_routing_report.md
75-
- M docs_build/dev/reports/testing_lane_execution_report.md
76-
- M docs_build/dev/reports/validation_cache_report.md
77-
- M docs_build/dev/reports/zero_browser_preflight_report.md
78-
- A docs_build/pr/APPLY_PR_26171_032-idea-board-accordion-table-model.md
79-
- A docs_build/pr/BUILD_PR_26171_032-idea-board-accordion-table-model.md
80-
- A docs_build/pr/PLAN_PR_26171_032-idea-board-accordion-table-model.md
81-
- M tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
82-
- M tests/playwright/tools/ToolboxRoutePages.spec.mjs
83-
- M toolbox/idea-board/index.html
84-
- M toolbox/idea-board/index.js
85-
8628
## Requirement Evidence
87-
- PASS: Idea records use DB-shaped fields `ideaId`, `userId`, `idea`, `pitch`, `status`, and `updated` in `toolbox/idea-board/index.js`.
88-
- PASS: Note records use DB-shaped fields `noteId`, `ideaId`, `note`, `system`, and `updated` in `toolbox/idea-board/index.js`.
89-
- PASS: Relationship semantics are represented in-page by `userId` on idea records and `ideaId` on note records.
90-
- PASS: No real DB persistence, adapters, SQLite services, SQLite DDL, or SQLite seed files were added.
91-
- PASS: Default state has `expandedIdeaId: null`, no expanded rows, and the main table shows all ideas only.
92-
- PASS: Add Idea appears as the final table row/action area and opens an inline idea row at the bottom.
93-
- PASS: Visible Idea table columns are Idea, Pitch, Status, Updated, Notes, Actions.
94-
- PASS: Seed rows render Top Thoughts, Sky Orchard, and Clockwork Courier with the requested pitches, statuses, dates, note counts, and Edit/Delete actions.
95-
- PASS: Notes count and chevron buttons expand/collapse notes for that idea.
96-
- PASS: Expanded notes render directly under the owning idea row, and only one expanded idea is required/active at a time.
97-
- PASS: Notes are not selected context; visible selected-idea terminology, `Selected idea context`, and detached `Notes for Sky Orchard` heading were removed.
98-
- PASS: Visible note metadata columns are removed; expanded note table shows only Note and Actions columns.
99-
- PASS: Expanded notes include a `Notes` header.
100-
- PASS: Note rows expose Edit/Delete when allowed; system notes expose Edit and do not expose Delete.
101-
- PASS: Add Note appears under the expanded notes area for that idea.
102-
- PASS: Add/Edit Idea rows use inline controls with a Status dropdown and Save/Cancel actions on the same row.
103-
- PASS: Add/Edit Note rows use inline controls with Save/Cancel actions on the same row inside the expanded notes area.
29+
- PASS: Separate `>` expand/collapse button removed from `toolbox/idea-board/index.js`; no `data-idea-board-notes-chevron` control remains.
30+
- PASS: No separate expand/collapse control column was added; the visible Idea table remains Idea, Pitch, Status, Updated, Notes, Actions.
31+
- PASS: Notes count is rendered as a plain informational span and no longer carries `data-idea-board-toggle-notes`.
32+
- PASS: Chevron image is rendered inside the Idea row header cell.
33+
- PASS: Collapsed rows use `assets/theme-v2/images/gfs-chevron-down.svg`.
34+
- PASS: Expanded rows use `assets/theme-v2/images/gfs-chevron-up.svg`.
35+
- PASS: The whole Idea cell carries the toggle target and handles click plus Enter/Space keyboard activation.
36+
- PASS: Expanded notes continue to render directly under the owning idea row.
37+
- PASS: Targeted Playwright verifies clicking Notes count does not expand from a collapsed state.
38+
- PASS: Targeted Playwright verifies clicking Notes count does not collapse from an expanded state.
39+
- PASS: Targeted Playwright verifies clicking the Idea cell expands/collapses and the chevron switches down/up.
40+
- PASS: Theme V2 chevron SVG assets were added under `assets/theme-v2/images/`.
10441

10542
## Validation
10643
- PASS: `node --check toolbox/idea-board/index.js`.
10744
- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`.
10845
- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`.
109-
- PASS: Idea Board inline HTML guard found no inline `<script>`, `<style>`, `style=`, or inline event handlers.
110-
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line` (1 passed after correcting a test regex typo).
111-
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"` (1 passed after correcting the status assertion order).
112-
- PASS: `npm run test:workspace-v2` (5 passed).
113-
- SKIP: Full samples smoke was not run; samples are not in scope and the user explicitly prohibited full samples smoke.
46+
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line` (1 passed).
47+
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"` (1 passed).
48+
- SKIP: Full samples smoke was not run; it is not in scope for this PR.
11449

11550
## ZIP
116-
- Path: `tmp/PR_26171_032-idea-board-accordion-table-model_delta.zip`.
51+
- Path: `tmp/PR_26171_033-idea-board-inline-accordion-cell_delta.zip`.
11752
- Size and contents: reported after final ZIP generation.

0 commit comments

Comments
 (0)