Persist Objects rows through shared DB adapter - PR_26161_011-objects-db-persistence-fix

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -1,9 +1,24 @@
-docs_build/dev/codex_commands.md
-docs_build/dev/commit_comment.txt
-docs_build/dev/reports/codex_changed_files.txt
-docs_build/dev/reports/codex_review.diff
-docs_build/dev/reports/coverage_changed_js_guardrail.txt
-docs_build/dev/reports/objects-asset-return-display-report.md
-docs_build/dev/reports/playwright_v8_coverage_report.txt
-tests/playwright/tools/ObjectsTool.spec.mjs
-toolbox/objects/objects.js
+# git status --short
+M docs_build/dev/reports/coverage_changed_js_guardrail.txt
+ M docs_build/dev/reports/playwright_v8_coverage_report.txt
+ M src/dev-runtime/persistence/mock-db-store.js
+ M src/dev-runtime/server/mock-api-router.mjs
+ M tests/playwright/tools/ObjectsTool.spec.mjs
+ M toolbox/objects/objects.js
+?? docs_build/dev/reports/objects-db-persistence-fix-report.md
+?? src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js
+?? toolbox/objects/objects-api-client.js
+
+# git ls-files --others --exclude-standard
+docs_build/dev/reports/objects-db-persistence-fix-report.md
+src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js
+toolbox/objects/objects-api-client.js
+
+# git diff --stat
+.../dev/reports/coverage_changed_js_guardrail.txt  |  10 +-
+ .../dev/reports/playwright_v8_coverage_report.txt  |  19 +++-
+ src/dev-runtime/persistence/mock-db-store.js       |   5 +
+ src/dev-runtime/server/mock-api-router.mjs         |  20 +++-
+ tests/playwright/tools/ObjectsTool.spec.mjs        |  95 ++++++++++++++++++
+ toolbox/objects/objects.js                         | 109 +++++++++++++++++++--
+ 6 files changed, 241 insertions(+), 17 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -6,7 +6,13 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(94%) toolbox/objects/objects.js - executed lines 1065/1065; executed functions 100/106
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(94%) toolbox/objects/objects.js - executed lines 1150/1150; executed functions 103/109
+(100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 
 Guardrail warnings:
-(100%) none - no changed runtime JS coverage warnings
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -0,0 +1,85 @@
+# PR_26161_011 Objects DB Persistence Fix Report
+
+## Branch Guard
+- Current branch: `main`
+- Expected branch: `main`
+- Local branches found: `* main`
+- Branch validation: PASS
+
+## Source Of Truth
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before edits.
+- PASS: Used the user-provided `PR_26161_011-objects-db-persistence-fix` request as the active BUILD source.
+- PASS: Continued from `PR_26161_010`.
+- PASS: Kept the PR purpose singular: persist Objects table rows through the shared DB/mock adapter.
+
+## Requirement Checklist
+- PASS: Added/edited/deleted object rows persist through the shared Objects repository exposed by the shared server API/mock adapter.
+- PASS: Object definitions are no longer stored only in page-local memory; the page uses `draftedObjects` as a render cache loaded from and saved to the shared adapter.
+- PASS: Page load reads existing object records from the shared adapter.
+- PASS: Add/Edit/Delete/Reset writes the updated object record list to the shared adapter.
+- PASS: Sprite render asset links persist with each object record through `renderAssetKey` and `renderPreviewPath`.
+- PASS: Returning to or reloading the Objects page shows previously saved rows.
+- PASS: Asset remains linked render-record display data, not an invalid free-text user field.
+- PASS: `State` remains visible in the Objects table.
+- PASS: Preserved Object Type Catalog compact display with `Template` and `Capability` only.
+- PASS: Preserved table-first input, `Add Object` below the table, Add disabled while adding, Cancel, Edit, Trash, Reset Table, Object Status, and Sprite asset linking.
+- PASS: Did not add sample JSON alignment, auth behavior, production DB behavior, or unrelated tool rewrites.
+- PASS: Kept Theme V2 only and preserved HTML restrictions.
+- PASS: No runtime engine behavior changed.
+
+## Implementation Evidence
+- `src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js`: added an Objects repository with `listObjects`, `replaceObjects`, `resetObjects`, `getTables`, and `getSnapshot`.
+- `src/dev-runtime/persistence/mock-db-store.js`: added the Objects table group and `object_definition_records` schema.
+- `src/dev-runtime/server/mock-api-router.mjs`: exposed the Objects repository and table snapshot through the existing toolbox server API.
+- `toolbox/objects/objects-api-client.js`: added the Objects API client for the browser tool.
+- `toolbox/objects/objects.js`: loads Objects rows from the repository on page load and persists rows after Add/Edit/Delete/Reset while preserving linked sprite asset display.
+- `tests/playwright/tools/ObjectsTool.spec.mjs`: added reload persistence checks for add, edit, delete, and sprite asset links.
+
+## Impacted Lane
+- Impacted lane: Objects tool UI/runtime plus shared mock DB adapter contract for the Objects table.
+- Playwright impacted: Yes.
+- Changed runtime JavaScript: `toolbox/objects/objects.js`, `toolbox/objects/objects-api-client.js`, `src/dev-runtime/server/mock-api-router.mjs`, `src/dev-runtime/persistence/mock-db-store.js`, `src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js`.
+
+## Testing Performed
+- PASS: `node --check src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js`
+- PASS: `node --check toolbox/objects/objects-api-client.js`
+- PASS: `node --check toolbox/objects/objects.js`
+- PASS: `node --check tests/playwright/tools/ObjectsTool.spec.mjs`
+- PASS: `node --check src/dev-runtime/server/mock-api-router.mjs`
+- PASS: `node --check src/dev-runtime/persistence/mock-db-store.js`
+- PASS: HTML restriction check for `toolbox/objects/index.html` returned no inline script/style/event handler matches.
+- PASS: Objects forbidden wording scan returned no matches in `toolbox/objects/index.html` or `toolbox/objects/objects.js`.
+- PASS: `npx playwright test tests/playwright/tools/ObjectsTool.spec.mjs --workers=1 --reporter=line` (6 passed).
+- PASS: `git diff --check` exited 0 with line-ending warnings only.
+- PASS: `docs_build/dev/reports/playwright_v8_coverage_report.txt` was produced by targeted Objects Playwright.
+
+## Playwright Behavior Coverage
+- PASS: Add row persists to `object_definition_records` and remains visible after page reload.
+- PASS: Edit row persists to `object_definition_records` and remains visible after page reload.
+- PASS: Delete row removes the shared DB record and remains removed after page reload.
+- PASS: Sprite render creates/resolves a linked shared asset and persists its key on the object record.
+- PASS: Reloading Objects restores the linked sprite asset display and `Edit Sprite` action.
+- PASS: Existing Objects UI checks still cover Type/Capabilities wording, compact catalog, table-first editing, Object Status actions, and Sprite linking.
+
+## Skipped Lanes
+- `npm run test:workspace-v2`: SKIP. The script maps to the legacy workspace-contract lane and does not cover Objects tool UI/runtime behavior.
+- Full samples validation: SKIP. Safe because no sample JSON, sample launch path, or sample runtime behavior changed.
+- Engine runtime validation beyond changed-file syntax/import checks: SKIP. Safe because no engine runtime behavior changed.
+- Production DB/auth validation: SKIP. Safe because the change is limited to the shared dev mock adapter and Objects tool.
+- Broad Toolbox/Admin validation: SKIP. Safe because navigation, registration, auth, admin surfaces, and sample paths were not changed.
+
+## Manual Validation Steps
+- Open `/toolbox/objects/index.html`.
+- Add a non-Sprite object, reload the page, and confirm the row remains.
+- Edit the saved row, reload the page, and confirm the edited name/state remain.
+- Delete the row, reload the page, and confirm the table is empty.
+- Add a Sprite object, save it, reload the page, and confirm the Render Asset display and `Edit Sprite` link still point to the linked sprite asset.
+- Click `Reset Table`, reload the page, and confirm the shared object records remain cleared.
+- Confirm Object Type Catalog still shows only `Template` and `Capability`, and the Objects table still shows `State`.
+
+## Required Artifacts
+- PASS: `docs_build/dev/reports/objects-db-persistence-fix-report.md`
+- PASS: `docs_build/dev/reports/codex_review.diff`
+- PASS: `docs_build/dev/reports/codex_changed_files.txt`
+- PASS: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- PASS: `tmp/PR_26161_011-objects-db-persistence-fix_delta.zip`

docs_build/dev/reports/objects-db-persistence-fix-report.md

@@ -12,12 +12,16 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(86%) Toolbox Index - exercised 5 runtime JS files
+(86%) Toolbox Index - exercised 6 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(94%) toolbox/objects/objects.js - executed lines 1065/1065; executed functions 100/106
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(94%) toolbox/objects/objects.js - executed lines 1150/1150; executed functions 103/109
+(100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 
 Files with executed line/function counts where available:
 (33%) src/engine/api/toolbox-votes-api-client.js - executed lines 46/46; executed functions 2/6
@@ -31,13 +35,20 @@ Files with executed line/function counts where available:
 (75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 58/58; executed functions 3/4
 (77%) toolbox/tools-page-accordions.js - executed lines 965/965; executed functions 79/103
 (86%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 24/28
-(94%) toolbox/objects/objects.js - executed lines 1065/1065; executed functions 100/106
+(94%) toolbox/objects/objects.js - executed lines 1150/1150; executed functions 103/109
 (100%) src/engine/object-model/index.js - executed lines 29/29; executed functions 1/1
+(100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 (100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
-(100%) none - no low-coverage changed runtime JS files
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
+(0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ObjectsTool.spec.mjs - changed JS file not collected as browser runtime coverage
 (94%) toolbox/objects/objects.js - changed JS file with browser V8 coverage
+(100%) toolbox/objects/objects-api-client.js - changed JS file with browser V8 coverage

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -83,6 +83,10 @@ export const MOCK_DB_TOOL_GROUPS = Object.freeze({
     label: "Game Configuration",
     tableNames: Object.freeze(["game_configuration_records", "game_configuration_validation_items"]),
   }),
+  objects: Object.freeze({
+    label: "Objects",
+    tableNames: Object.freeze(["object_definition_records"]),
+  }),
   "project-journey": Object.freeze({
     label: "Project Journey",
     tableNames: Object.freeze([
@@ -127,6 +131,7 @@ const MOCK_DB_TABLE_SCHEMAS = Object.freeze({
   game_design_validation_items: Object.freeze(["key", "projectKey", "label", "status", "action", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   game_configuration_records: Object.freeze(["key", "projectKey", "status", "summary", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   game_configuration_validation_items: Object.freeze(["key", "projectKey", "label", "status", "action", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
+  object_definition_records: Object.freeze(["key", "id", "projectId", "name", "type", "state", "modelType", "renderType", "renderAssetKey", "renderPreviewPath", "capabilities", "behavior", "interaction", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_note_types: Object.freeze(["key", "typeSlug", "name", "seeded", "userExtensible", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_notes: Object.freeze(["key", "slug", "projectKey", "ownerKey", "name", "typeKey", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_templates: Object.freeze(["key", "templateSlug", "originalMeaning", "systemGuidance", "linkedToolContexts", "version", "isActive", "createdAt", "updatedAt", "createdBy", "updatedBy"]),