Enforce tools-progress as Toolbox status source of truth - PR_26156_128-tool-status-registry-enforcement

Author: ToolboxAid

admin/tools-progress-source.js

@@ -1,13 +1,9 @@
 import { getActiveToolRegistry, getToolRoute } from "../toolbox/toolRegistry.js";
-
-const completionByStatus = Object.freeze({
-  Ready: "Yes",
-  Wireframe: "No",
-  "Under Construction": "No",
-  Planned: "No",
-  Hidden: "No",
-  Deprecated: "No"
-});
+import {
+  getToolProgressReadiness,
+  getToolsProgressSource,
+  toolProgressMetadataDiagnostic
+} from "./tools-progress-source.js";
 
 const swatchByGroup = Object.freeze({
   AI: "swatch-purple",
@@ -79,8 +75,22 @@ function createGroupCell(tool) {
   return cell;
 }
 
+function createStatusCell(tool) {
+  const cell = createCell("td", tool.status);
+  const statusDiagnostic = toolProgressMetadataDiagnostic(tool);
+  if (statusDiagnostic) {
+    const diagnostic = document.createElement("span");
+    diagnostic.className = "status";
+    diagnostic.dataset.toolsProgressStatusDiagnostic = tool.displayName;
+    diagnostic.setAttribute("role", "status");
+    diagnostic.textContent = statusDiagnostic;
+    cell.append(diagnostic);
+  }
+  return cell;
+}
+
 function isComplete(tool) {
-  return completionByStatus[tool.status] || "No";
+  return tool.readiness || getToolProgressReadiness(tool.status);
 }
 
 function firstIncompleteTool(tools) {
@@ -92,22 +102,26 @@ function renderToolsProgress() {
     return;
   }
 
-  const tools = getActiveToolRegistry();
+  const tools = getToolsProgressSource(getActiveToolRegistry());
   progressBody.replaceChildren();
   tools.forEach((tool) => {
     const row = document.createElement("tr");
+    const statusDiagnostic = toolProgressMetadataDiagnostic(tool);
     row.className = tool.colorGroup;
     row.dataset.toolsProgressTool = tool.displayName;
     row.dataset.toolsProgressOrder = String(tool.order);
     row.dataset.toolsProgressGroup = tool.category;
     row.dataset.toolsProgressColorGroup = tool.colorGroup;
     row.dataset.toolsProgressStatus = tool.status;
     row.dataset.toolsProgressComplete = isComplete(tool);
+    if (statusDiagnostic) {
+      row.dataset.toolsProgressStatusDiagnostic = statusDiagnostic;
+    }
     row.append(
       createCell("td", String(tool.order)),
       createToolNameCell(tool),
       createGroupCell(tool),
-      createCell("td", tool.status),
+      createStatusCell(tool),
       createCell("td", isComplete(tool))
     );
     progressBody.append(row);

admin/tools-progress.js

@@ -896,3 +896,39 @@ Required reports:
 - `docs_build/dev/reports/testing_lane_execution_report.md`
 - `docs_build/dev/reports/codex_changed_files.txt`
 - `docs_build/dev/reports/codex_review.diff`
+
+
+## PR_26156_128
+
+Changes:
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Added `admin/tools-progress-source.js` as the Admin Tools Progress status metadata source consumed by both Admin Tools Progress and Toolbox rendering.
+- Removed duplicated Toolbox-local status/readiness/visibility/requiredness ownership from `toolbox/toolRegistry.js`.
+- Updated `admin/tools-progress.js` to hydrate rows from the Admin status source.
+- Updated `toolbox/tools-page-accordions.js` to hydrate card visibility/status from the Admin status source.
+- Added visible missing-metadata diagnostics for Admin Tools Progress rows and Toolbox cards.
+- Removed obsolete/dead Toolbox status constants and local progress mappings.
+- Updated targeted Tools Progress tests to verify Admin source reflection, user/Admin visibility, and missing-metadata diagnostics.
+- Updated the tool registry validator so base registry entries no longer need duplicate status visibility fields.
+- Did not modify archived V1/V2 pages.
+- Did not modify `start_of_day`.
+
+Validation:
+- `node --check admin/tools-progress-source.js`
+- `node --check admin/tools-progress.js`
+- `node --check toolbox/toolRegistry.js`
+- `node --check toolbox/tools-page-accordions.js`
+- `node --check tests/playwright/tools/ToolsProgressHydration.spec.mjs`
+- `node --check scripts/validate-tool-registry.mjs`
+- `node --check scripts/validate-active-tools-surface.mjs`
+- `node scripts/validate-tool-registry.mjs`
+- `node ./scripts/run-targeted-test-lanes.mjs --lane tools-progress --lane tool-runtime`
+- `git diff --check`
+- Supplemental `node scripts/validate-active-tools-surface.mjs` was not used as this PR's validation gate because it still reports existing non-status Toolbox wireframe expectations outside PR_26156_128 scope.
+- Full samples smoke: skipped by request.
+
+Required reports:
+- `docs_build/dev/reports/tool-status-registry-enforcement-report.md`
+- `docs_build/dev/reports/testing_lane_execution_report.md`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/codex_review.diff`

assets/theme-v2/images/logo-merch-1.png assets/theme-v2/images/logo-merch-0.pngassets/theme-v2/images/logo-merch-1.png renamed to assets/theme-v2/images/logo-merch-0.png

@@ -1 +1 @@
-Clean up Toolbox cards and status visibility - PR_26156_127-toolbox-card-and-status-cleanup
+Enforce Admin Tools Progress status source - PR_26156_128-tool-status-registry-enforcement