Move Controls capture into mapping rows and fix input click behavior - PR_26161_020-controls-row-capture-cleanup

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -1,28 +1,20 @@
 # git status --short
-M docs_build/dev/reports/codex_changed_files.txt
- M docs_build/dev/reports/codex_review.diff
- M docs_build/dev/reports/coverage_changed_js_guardrail.txt
+M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M docs_build/dev/reports/playwright_v8_coverage_report.txt
- M src/dev-runtime/persistence/mock-db-store.js
- M src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js
  M tests/playwright/tools/InputMappingV2Tool.spec.mjs
  M toolbox/controls/index.html
  M toolbox/input-mapping-v2/index.html
  M toolbox/input-mapping-v2/input-mapping-v2.js
-?? docs_build/dev/reports/controls-db-controller-profiles-report.md
+?? docs_build/dev/reports/controls-row-capture-cleanup-report.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/controls-db-controller-profiles-report.md
+docs_build/dev/reports/controls-row-capture-cleanup-report.md
 
 # git diff --stat
-docs_build/dev/reports/codex_changed_files.txt     |   30 +-
- docs_build/dev/reports/codex_review.diff           | 2400 ++++++++------------
- .../dev/reports/coverage_changed_js_guardrail.txt  |    6 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |   14 +-
- src/dev-runtime/persistence/mock-db-store.js       |    5 +-
- .../input-mapping-mock-repository.js               |   98 +-
- tests/playwright/tools/InputMappingV2Tool.spec.mjs |   92 +-
- toolbox/controls/index.html                        |   21 +-
- toolbox/input-mapping-v2/index.html                |   21 +-
- toolbox/input-mapping-v2/input-mapping-v2.js       |  326 ++-
- 10 files changed, 1567 insertions(+), 1446 deletions(-)
+.../dev/reports/coverage_changed_js_guardrail.txt  |   9 +-
+ .../dev/reports/playwright_v8_coverage_report.txt  |  18 +-
+ tests/playwright/tools/InputMappingV2Tool.spec.mjs |  86 +++++++--
+ toolbox/controls/index.html                        |  26 +--
+ toolbox/input-mapping-v2/index.html                |  26 +--
+ toolbox/input-mapping-v2/input-mapping-v2.js       | 204 +++++++++++++--------
+ 6 files changed, 226 insertions(+), 143 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -0,0 +1,67 @@
+# PR_26161_020 Controls Row Capture Cleanup Report
+
+## Branch Validation
+- Current branch: `main`
+- Expected branch: `main`
+- Result: PASS
+
+## Summary
+- Removed the separate Controls/Input Mapping Capture accordion.
+- Moved selected Action/Object context into the right side of the mappings table footer next to Add Mapping and Reset Mappings.
+- Replaced the row Input free-text editor with row-level capture buttons:
+  - Capture Keyboard
+  - Capture Mouse
+  - Capture Gamepad
+- Kept Input display clickable without deleting mappings.
+- Kept deletion scoped to the row Trash action.
+- Preserved table-first add/edit/cancel, Mapping JSON, Devices, Status, controller profiles, workspace return, and shared DB/mock-adapter persistence.
+
+## Impacted Lane
+- runtime
+- recovery/UAT
+
+## Playwright Impacted
+- Yes
+
+## Testing Performed
+- `node --check toolbox/input-mapping-v2/input-mapping-v2.js` - PASS
+- `node --check tests/playwright/tools/InputMappingV2Tool.spec.mjs` - PASS
+- `rg --pcre2 -n "<style|style=|<script(?![^>]*\\bsrc=)|on(click|change|input|submit|keydown|keyup|pointerdown|mousedown|mouseup)=" toolbox/input-mapping-v2/index.html toolbox/controls/index.html` - PASS, no inline CSS/JS/event handlers found
+- `git diff --check` - PASS
+- `npx playwright test tests/playwright/tools/InputMappingV2Tool.spec.mjs --workers=1 --reporter=line` - PASS, 5 passed
+
+## Playwright Behavior Covered
+- Selected Action/Object display appears in the mappings table footer and updates from the Actions panel.
+- Capture accordion is absent.
+- Row-level Capture Keyboard, Capture Mouse, and Capture Gamepad buttons appear during row add/edit.
+- Keyboard capture updates the active row input and persists after Save/reload.
+- Gamepad capture shows actionable WARN when no live gamepad value is available.
+- Gamepad capture can populate a row when a live gamepad value is supplied by the test harness.
+- Clicking the displayed Input token does not delete the row.
+- Trash is the only covered row deletion path.
+- Mapping JSON, Devices, Status, controller profiles, and compatibility route continue to render.
+
+## V8 Coverage
+- Report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- Changed runtime JS covered: `toolbox/input-mapping-v2/input-mapping-v2.js`
+- Coverage result: 92% function coverage, 105/114 functions
+
+## Manual Validation Steps
+1. Open `/toolbox/input-mapping-v2/index.html`.
+2. Confirm the left column shows Actions and Controller Profiles, with no Capture accordion.
+3. Confirm Add Mapping and Reset Mappings are on the left side of the table footer.
+4. Confirm Selected Action and Selected Object appear on the right side of the table footer.
+5. Click Add Mapping and confirm Add Mapping disables while the edit row is active.
+6. Click Capture Keyboard, press a key, save the row, reload, and confirm the mapping remains.
+7. Click the Input token and confirm the row remains.
+8. Click Trash and confirm the row is deleted.
+
+## Skipped Lanes
+- Full samples validation was skipped as required by the PR instructions; this change is limited to the Controls/Input Mapping toolbox UI and test coverage.
+- Full workspace contract lane was skipped because no Workspace V2 contract/runtime files changed; workspace return visibility is covered in the targeted Controls Playwright test.
+
+## Runtime Scope Confirmation
+- Controls remains Wireframe.
+- No production controller runtime was added.
+- No sample JSON alignment, auth behavior, production DB behavior, engine runtime behavior, or unrelated rewrites were added.
+- Controls mapping data remains persisted through the shared DB/mock adapter.

docs_build/dev/reports/controls-row-capture-cleanup-report.md

@@ -6,12 +6,7 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(90%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1000/1000; executed functions 99/110
+(92%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1053/1053; executed functions 105/114
 
 Guardrail warnings:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
+None.

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -12,33 +12,25 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(87%) Toolbox Index - exercised 4 runtime JS files
+(89%) Toolbox Index - exercised 4 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(90%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1000/1000; executed functions 99/110
+(92%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1053/1053; executed functions 105/114
 
 Files with executed line/function counts where available:
 (53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
 (58%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 603/603; executed functions 30/52
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
 (75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
-(90%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1000/1000; executed functions 99/110
+(92%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1053/1053; executed functions 105/114
 (100%) toolbox/input-mapping-v2/input-mapping-api-client.js - executed lines 12/12; executed functions 2/2
 (100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
+None.
 
 Changed JS files considered:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/InputMappingV2Tool.spec.mjs - changed JS file not collected as browser runtime coverage
-(90%) toolbox/input-mapping-v2/input-mapping-v2.js - changed JS file with browser V8 coverage
+(92%) toolbox/input-mapping-v2/input-mapping-v2.js - changed JS file with browser V8 coverage