Skip to content

Commit 9993a12

Browse files
committed
Sort tools index groups and tool tiles while continuing root cleanup - PR_26154_014-tools-index-sort-cleanup
1 parent 4c48713 commit 9993a12

4 files changed

Lines changed: 231 additions & 183 deletions

File tree

docs_build/dev/codex_commands.md

Lines changed: 31 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,60 +1,47 @@
11
# Codex Commands
22

3-
Tasks:
3+
Task:
44

5-
- `PR_26154_011-theme-v1-final-teardown`
6-
- `PR_26154_012-root-asset-reference-cleanup`
7-
- `PR_26154_013-root-structure-inventory-closeout`
5+
- `PR_26154_014-tools-index-sort-cleanup`
86

97
Commands run:
108

119
- `Get-Content .codex/skills/repo-build/SKILL.md`
1210
- `Get-Content docs_build/dev/PROJECT_INSTRUCTIONS.md`
1311
- `git status --short --untracked-files=all`
14-
- Targeted `Get-ChildItem`, `Get-Content`, and `rg` inventory for:
15-
- `src/engine/theme/`
16-
- `assets/theme/v1/`
17-
- active public/root pages
18-
- active tool surfaces under `tools/`
19-
- `games/`
20-
- `docs/`
21-
- stale path strings
22-
- current root ownership folders
23-
- Updated `src/engine/theme/README.md` to document runtime ownership and the current direct helper import path.
24-
- Targeted stale-reference checks for:
25-
- `GameFoundryStudio/`
26-
- `src/engine/theme/index.js`
27-
- `assets/theme/v2/assets/`
28-
- `assets/theme/v2/images/games/`
29-
- `favicon.ico`
30-
- Root structure inventory counts for:
31-
- `assets/`
32-
- `tools/`
33-
- `old-tools/`
34-
- `games/`
35-
- `old_games/`
36-
- `old_samples/`
37-
- `docs/`
38-
- `docs_build/`
39-
- `schemas/`
40-
- `src/`
41-
- Node targeted static validation for changed HTML, JS, CSS, JSON, and Markdown paths.
42-
- `git status --short -- start_of_day old_games old_samples`
12+
- `Get-Content tools/index.html`
13+
- `Get-Content tools/tools-page-accordions.js`
14+
- `rg -n "GameFoundryStudio/|src/engine/theme/|assets/theme/v2/assets/|assets/theme/v2/images/games/|favicon\\.ico" tools/index.html tools/tools-page-accordions.js`
15+
- Node scoped rewrite for `tools/tools-page-accordions.js` group and tile ordering.
16+
- `rg --files | rg -i "localization|localisation|localize|translate|translation"`
17+
- `Get-ChildItem assets/theme/v2/images/tools`
18+
- `rg -n "localization\\.png|localization-studio|Localization|localization" tools assets docs docs_build -g "!*old*"`
19+
- `rg -n "tools-page-accordions\\.js" -g "*.html" -g "*.js" -g "*.md" -g "*.json" .`
20+
- `node --check tools/tools-page-accordions.js`
21+
- Node targeted validator for:
22+
- active Tools index group ordering
23+
- tile ordering within each group
24+
- active tool href/image file existence
25+
- `tools/index.html` local ref file existence
26+
- stale active path strings
27+
- Node static validation for changed HTML, JS, CSS, JSON, and Markdown files.
4328
- `git diff --check`
29+
- `git status --short -- start_of_day old_games old_samples`
4430
- `npm run codex:review-artifacts`
45-
- Python ZIP packaging for `tmp/PR_26154_011-013-root-structure-closeout_delta.zip`
31+
- ZIP packaging for `tmp/PR_26154_014-tools-index-sort-cleanup_delta.zip`
4632

4733
Validation summary:
4834

49-
- PASS no confirmed V1 legacy/static assets remain under `src/engine/theme/`.
50-
- PASS remaining `src/engine/theme/` files are runtime-owned or runtime documentation.
51-
- PASS `src/engine/theme/README.md` no longer references the removed `index.js` barrel.
52-
- PASS no active public/root page, active tool page, game page, public doc, asset, script, or source helper references remain to stale public asset paths.
53-
- PASS remaining `src/engine/theme/` references are intentional runtime/guard/test references or historical/generated records.
54-
- PASS root structure ownership inventory completed.
55-
- PASS `schemas/` absence confirmed; active schemas are under `tools/schemas/`.
56-
- PASS `start_of_day/`, `old_games/`, and `old_samples/` unchanged.
35+
- PASS `tools/tools-page-accordions.js` syntax validation.
36+
- PASS active Tools index group order is alphabetical.
37+
- PASS active Tools index tile order is alphabetical within every group.
38+
- PASS 19 active tool href/image references resolve.
39+
- PASS 4 `tools/index.html` local refs resolve.
40+
- PASS no targeted stale path strings remain in `tools/index.html` or `tools/tools-page-accordions.js`.
41+
- PASS static validation for changed HTML, JS, CSS, JSON, and Markdown files.
5742
- PASS `git diff --check`.
58-
- PASS `npm run codex:review-artifacts`.
43+
- PASS no `start_of_day/`, `old_games/`, or `old_samples/` changes.
44+
- PASS review artifact generation.
45+
- PASS repo-structured delta ZIP packaging.
5946
- SKIPPED `npm run test:workspace-v2`; active Workspace V2 launch/navigation behavior was not changed.
60-
- SKIPPED old_games, old_samples, and full samples smoke validation per request.
47+
- SKIPPED old games, old samples, and full samples smoke validation per request.

docs_build/dev/commit_comment.txt

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
1-
Theme V1 final teardown, root asset reference cleanup, and structure inventory closeout
1+
Tools index sort cleanup
22

3-
Stack:
4-
- PR_26154_011-theme-v1-final-teardown
5-
- PR_26154_012-root-asset-reference-cleanup
6-
- PR_26154_013-root-structure-inventory-closeout
3+
PR: PR_26154_014-tools-index-sort-cleanup
74

8-
- Confirm no further V1 static/theme assets can safely move from `src/engine/theme/` because the remaining files are runtime-owned.
9-
- Update `src/engine/theme/README.md` to remove a stale removed-barrel import and document current runtime ownership.
10-
- Audit active root/page/tool/game/doc references for stale path strings and report remaining intentional runtime, generated, or historical references.
11-
- Create root structure ownership inventory and cleanup candidate report without moving unrelated files.
12-
- Validate targeted references, changed static files, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.
5+
- Sort active Tools index groups alphabetically by group name.
6+
- Sort tool tiles alphabetically by visible tool name within each existing group.
7+
- Preserve all existing group assignments, tool names, and launch hrefs.
8+
- Fix the active Localization tile image path to the existing `localization-studio.png` asset.
9+
- Validate active Tools index ordering, resolved local href/image paths, stale path strings, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.
Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
# PR_26154_014 Tools Index Sort Cleanup Report
2+
3+
Task: `PR_26154_014-tools-index-sort-cleanup`
4+
5+
## Scope
6+
7+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
8+
- Kept `tools/index.html` layout and markup unchanged.
9+
- Updated the active Tools index data source: `tools/tools-page-accordions.js`.
10+
- Preserved existing group assignments and tool names.
11+
- Did not touch `old_games/`, `old_samples/`, or `start_of_day/`.
12+
- Did not run full samples smoke validation.
13+
14+
## Ordering Changes
15+
16+
`tools/index.html` loads `tools-page-accordions.js`, so the visible grouped order is controlled by `tools/tools-page-accordions.js`.
17+
18+
Alphabetized group order:
19+
20+
1. AI
21+
2. Assets
22+
3. Audio
23+
4. Colors
24+
5. Input
25+
6. Objects
26+
7. Worlds
27+
28+
Alphabetized tool order by group:
29+
30+
| Group | Tool Order |
31+
| --- | --- |
32+
| AI | AI Assistant |
33+
| Assets | Arcade, Cloud, Localization, Marketplace, Publish, Storage Inspector |
34+
| Audio | MIDI, Sound |
35+
| Colors | Palette Manager |
36+
| Input | Input |
37+
| Objects | Animation, Assets, Custom Extensions, Object Vector |
38+
| Worlds | Game Builder, Game Design, Particles, World Vector |
39+
40+
## Targeted Path Cleanup
41+
42+
| File | Previous Path | Updated Path | Reason |
43+
| --- | --- | --- | --- |
44+
| `tools/tools-page-accordions.js` | `../assets/theme/v2/images/tools/localization.png` | `../assets/theme/v2/images/tools/localization-studio.png` | Active Tools index image validation found the previous file missing; the existing matching Localization tile asset is `localization-studio.png`. |
45+
46+
No tool hrefs were renamed or reassigned.
47+
48+
## Validation
49+
50+
- PASS: `node --check tools/tools-page-accordions.js`.
51+
- PASS: Targeted order validator confirmed group order is alphabetical.
52+
- PASS: Targeted order validator confirmed every group sorts tool tiles alphabetically by visible tool name.
53+
- PASS: Targeted link/path validator resolved 19 tool href/image references and 4 `tools/index.html` local refs.
54+
- PASS: Targeted stale reference check found no `GameFoundryStudio/`, `src/engine/theme/`, `assets/theme/v2/assets/`, `assets/theme/v2/images/games/`, or `favicon.ico` references in the active Tools index files.
55+
- PASS: Static validation covered changed HTML/JS/CSS/JSON/Markdown paths.
56+
- PASS: `git diff --check`.
57+
- PASS: `git status --short -- start_of_day old_games old_samples` returned no output.
58+
- SKIPPED: `npm run test:workspace-v2`; active Workspace V2 launch/navigation behavior was not changed.
59+
- SKIPPED: old games, old samples, and full samples smoke tests per request.
60+
61+
## Notes
62+
63+
- The active Tools index loads `tools/tools-page-accordions.js`.
64+
- A separate historical helper copy at `assets/theme/v2/js/tools-page-accordions.js` is not imported by `tools/index.html`; it was not changed in this scoped PR.

0 commit comments

Comments
 (0)