Skip to content

Commit 9bc567b

Browse files
committed
Clarify Toolbox modes and targeted validation governance - PR_26155_003-toolbox-targeted-validation-and-project-workspace
1 parent d4db33a commit 9bc567b

30 files changed

Lines changed: 293 additions & 128 deletions

docs_build/dev/PROJECT_INSTRUCTIONS.md

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1477,3 +1477,55 @@ Rules:
14771477
- If existing Theme V2 cannot support a required Toolbox pattern, document the gap before adding an approved reusable Theme V2 pattern.
14781478
- Reusable Theme V2 patterns must live under `assets/theme-v2/css/` and must not reintroduce legacy/V1 styling.
14791479
- Wireframe-only Toolbox rebuilds must not add implementation logic.
1480+
1481+
## Targeted Independent Validation Guidance
1482+
1483+
Tool, page, and `src/` changes must use the narrowest affected validation lane that proves the changed behavior.
1484+
1485+
Rules:
1486+
- Small scoped tool changes validate the affected tool/page and directly touched shared dependencies only.
1487+
- Small scoped page changes validate the affected page and directly touched shared page dependencies only.
1488+
- Small scoped `src/` changes validate the affected module and directly dependent runtime/tool surface only.
1489+
- Do not trigger broad validation for small scoped changes unless shared runtime behavior, cross-tool launch behavior, engine behavior, or public navigation behavior changed.
1490+
- Do not run full samples validation unless samples are explicitly in scope or the changed shared runtime behavior directly affects samples.
1491+
- Reports must identify lanes run, broad lanes skipped, and the reason broad validation was not required.
1492+
1493+
## Tool Registry Planning Governance
1494+
1495+
Runtime database behavior for tools must not be introduced until tool planning metadata has a declared registry or data source.
1496+
1497+
The declared tool registry/data source must own:
1498+
- tool metadata
1499+
- category
1500+
- route
1501+
- status
1502+
- readiness
1503+
- requirements
1504+
- progress checklist
1505+
- deferred flags
1506+
1507+
Rules:
1508+
- Toolbox wireframes may show planning metadata as static text only.
1509+
- Future runtime database work must consume the declared data source rather than duplicating tool metadata in page-local code.
1510+
- Tool status, readiness, requirements, progress checklist, and deferred flags must be traceable to the declared registry/data source before database-backed behavior ships.
1511+
1512+
## Game Debug Configuration Governance
1513+
1514+
Game debug settings may exist for creator testing and development diagnostics.
1515+
1516+
Rules:
1517+
- Debug settings must be visible and configurable for creators/testers.
1518+
- Debug settings must not be hidden defaults.
1519+
- Debug settings must be disabled, stripped, or rejected when a game is promoted to playable/public release.
1520+
- Release validation must fail visibly when public/playable promotion includes enabled debug-only settings.
1521+
- Reports for affected game release or publish flows must state whether debug settings were present and how public release gating handled them.
1522+
1523+
## Project Workspace Naming Guidance
1524+
1525+
Use `Project Workspace` for user-facing copy and new test/report prose.
1526+
1527+
Rules:
1528+
- Do not introduce new user-facing `Workspace V2` wording.
1529+
- Do not introduce new report/test prose that describes the current user-facing experience as `Workspace V2`.
1530+
- Existing package scripts such as `npm run test:workspace-v2`, legacy lane identifiers, and historical test suite names may remain until renamed by a dedicated cleanup PR.
1531+
- When a report invokes a legacy command name such as `npm run test:workspace-v2`, the report must explain that the command name is legacy and the user-facing product language is `Project Workspace`.

docs_build/dev/codex_commands.md

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ Changes:
9292
- Added Build Path view rendering as visual path groups using existing tool tiles.
9393
- Kept Arcade out of Toolbox content.
9494
- Kept forbidden `Studio` wording out of Toolbox dynamic tool labels except brand usage.
95-
- Updated active validation scripts and Workspace V2 Playwright assertions for the corrected view-mode contract.
95+
- Updated active validation scripts and Project Workspace Playwright assertions for the corrected view-mode contract.
9696
- Added validation and manual test notes.
9797
- Generated local review artifacts.
9898
- Created the repo-structured delta ZIP at `tmp/PR_26154_053-toolbox-wireframe-rebuild-rule_view-mode-correction_delta.zip`.
@@ -110,3 +110,34 @@ Required reports:
110110
- `docs_build/dev/reports/codex_changed_files.txt`
111111
- `docs_build/dev/reports/codex_review.diff`
112112
- `docs_build/dev/reports/toolbox_wireframe_rebuild_rule_report.md`
113+
114+
## PR_26155_001
115+
116+
Changes:
117+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
118+
- Added targeted independent validation guidance to `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
119+
- Added tools database planning governance requiring tool metadata, category, route, status, readiness, requirements, progress checklist, and deferred flags to come from a declared registry/data source before runtime DB behavior.
120+
- Added game debug configuration governance for visible creator testing settings and public/playable release rejection or disablement.
121+
- Added Project Workspace naming guidance; `npm run test:workspace-v2` is treated as legacy test-command naming only.
122+
- Reviewed `toolbox/index.html` and confirmed Order, Group, Progress, and Build Path remain page modes for the same Toolbox surface.
123+
- Confirmed Progress and Build Path are not represented as standalone tool tiles or extra accordions.
124+
- Kept Arcade out of Toolbox content.
125+
- Kept forbidden `Studio` wording out of Toolbox dynamic tool labels except brand usage.
126+
- Added targeted validation notes, skipped broad-lane rationale, Project Workspace naming note, and manual test notes.
127+
- Generated local review artifacts.
128+
- Created the repo-structured delta ZIP at `tmp/PR_26155_001-project-workspace-governance-toolbox-modes_delta.zip`.
129+
130+
Validation:
131+
- `node scripts/validate-active-tools-surface.mjs`
132+
- `node scripts/validate-tool-registry.mjs`
133+
- Toolbox source checks for view controls, Progress readiness labels, Build Path path groups, absence of extra Progress/Build Path wireframe sections, Arcade absence, forbidden `Studio` label absence, and no inline CSS/JS/event handlers.
134+
- `npm run test:workspace-v2` (legacy command name for the Project Workspace test lane)
135+
- `git diff --check`
136+
- `node --check` for changed JS/MJS files.
137+
- No new CSS added.
138+
- Full samples smoke test skipped because samples are not in scope and no shared sample runtime behavior changed.
139+
140+
Required reports:
141+
- `docs_build/dev/reports/codex_changed_files.txt`
142+
- `docs_build/dev/reports/codex_review.diff`
143+
- `docs_build/dev/reports/project_workspace_governance_toolbox_modes_report.md`

docs_build/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Correct Toolbox wireframe view modes on shared tool surface - PR_26154_053-toolbox-wireframe-rebuild-rule
1+
Add Project Workspace governance and confirm Toolbox page modes - PR_26155_001-project-workspace-governance-toolbox-modes

docs_build/dev/reports/dependency_gating_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Dependency Gating Report
22

3-
Generated: 2026-06-04T03:43:28.722Z
3+
Generated: 2026-06-04T03:52:34.901Z
44
Status: PASS
55

66
## Gate Order

docs_build/dev/reports/dependency_hydration_reuse_report.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
# Dependency Hydration Reuse Report
22

3-
Generated: 2026-06-04T03:43:28.722Z
3+
Generated: 2026-06-04T03:52:34.901Z
44
Status: PASS
55

66
## Summary
77

8-
Reused dependency hydration: 0
9-
Invalidated dependency hydration: 1
8+
Reused dependency hydration: 1
9+
Invalidated dependency hydration: 0
1010
Generated dependency hydration: 0
11-
Prevented dependency graph hydration: 0
12-
Prevented helper resolution passes: 0
11+
Prevented dependency graph hydration: 1
12+
Prevented helper resolution passes: 4
1313
Prevented fixture ownership traversal: 0
1414

1515
## Hydration Decisions
1616

1717
| Lane | Status | Helpers | Fixtures | Imports | Dependency Hydration Hash | Reason |
1818
| --- | --- | --- | --- | --- | --- | --- |
19-
| workspace-contract | INVALIDATED | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | none | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | 0ff8fc92c789456d | Dependency hydration was refreshed after warm-start invalidation. |
19+
| workspace-contract | REUSED | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | none | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | 0ff8fc92c789456d | Dependency hydration reused from validated warm-start state. |
2020

2121
## Safeguards
2222

docs_build/dev/reports/execution_graph_reuse_report.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
# Execution Graph Reuse Report
22

3-
Generated: 2026-06-04T03:43:28.723Z
3+
Generated: 2026-06-04T03:52:34.902Z
44
Status: PASS
55

66
## Summary
77

8-
Reused execution graphs: 0
9-
Prevented graph rebuilds: 0
10-
Prevented redundant dependency traversal: 0
11-
Prevented fixture/helper graph assembly: 0
12-
Prevented manifest traversal: 0
13-
Prevented targeted scheduling work: 0
8+
Reused execution graphs: 1
9+
Prevented graph rebuilds: 1
10+
Prevented redundant dependency traversal: 1
11+
Prevented fixture/helper graph assembly: 4
12+
Prevented manifest traversal: 1
13+
Prevented targeted scheduling work: 1
1414

1515
## Execution Graph Decisions
1616

1717
| Lane | Status | Snapshot Status | Execution Graph Hash | Reason |
1818
| --- | --- | --- | --- | --- |
19-
| workspace-contract | INVALIDATED | INVALIDATED | d71814dbea6e33fd | Lane snapshot is part of the selected targeted execution graph. |
19+
| workspace-contract | REUSED | REUSED | d71814dbea6e33fd | Lane snapshot is part of the selected targeted execution graph. |
2020

2121
## Safeguards
2222

docs_build/dev/reports/failure_fingerprint_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Failure Fingerprint Report
22

3-
Generated: 2026-06-04T03:43:38.895Z
3+
Generated: 2026-06-04T03:52:43.267Z
44
Status: PASS
55

66
## Summary

docs_build/dev/reports/filesystem_scan_reduction_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Filesystem Scan Reduction Report
22

3-
Generated: 2026-06-04T03:43:28.704Z
3+
Generated: 2026-06-04T03:52:34.884Z
44
Status: PASS
55

66
## Scan Enforcement

docs_build/dev/reports/incremental_validation_report.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
# Incremental Validation Report
22

3-
Generated: 2026-06-04T03:43:28.723Z
3+
Generated: 2026-06-04T03:52:34.903Z
44
Status: PASS
55

66
## Reuse Summary
77

8-
Reused manifests: 0
9-
Invalidated manifests: 1
8+
Reused manifests: 1
9+
Invalidated manifests: 0
1010
Generated manifests: 0
1111
Skipped manifests: 0
12-
Prevented lane regeneration: 0
13-
Prevented discovery scans: 0
14-
Prevented helper resolution passes: 0
12+
Prevented lane regeneration: 1
13+
Prevented discovery scans: 1
14+
Prevented helper resolution passes: 4
1515
Prevented fixture resolution passes: 0
1616

1717
## Incremental Decisions
1818

1919
| Lane | Decision | Invalidated By | Runtime Savings Observation |
2020
| --- | --- | --- | --- |
21-
| workspace-contract | INVALIDATED | Persistent manifest input hash changed for workspace-contract.; Persistent manifest hash changed for workspace-contract. | Manifest was regenerated or skipped; no reuse savings for this lane. |
21+
| workspace-contract | REUSED | unchanged inputs | Reused 1 test input(s), 4 helper(s), and 0 fixture(s). |
2222

2323
## Invalidation Rules
2424

docs_build/dev/reports/lane_compilation_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Lane Compilation Report
22

3-
Generated: 2026-06-04T03:43:28.722Z
3+
Generated: 2026-06-04T03:52:34.901Z
44
Status: PASS
55

66
## Lane Graph

0 commit comments

Comments
 (0)