Fix fullscreen scrolling audit fallbacks and Colors tag help - PR_26159_052-fullscreen-scroll-audit-tags-help

Author: ToolboxAid

assets/theme-v2/css/layout.css

@@ -206,7 +206,9 @@ body.tool-focus-mode .tool-workspace {
   grid-template-rows: auto minmax(var(--space-0), 1fr);
   gap: var(--space-10);
   padding: var(--space-10);
-  align-items: stretch
+  align-items: stretch;
+  overflow: hidden;
+  min-height: var(--space-0)
 }
 
 body.tool-focus-mode .tool-workspace.is-left-collapsed {
@@ -230,9 +232,19 @@ body.tool-focus-mode .tool-display-mode {
   margin: var(--space-0)
 }
 
-body.tool-focus-mode .tool-column,
-body.tool-focus-mode .tool-center-panel {
+body.tool-focus-mode .tool-workspace>* {
+  min-height: var(--space-0)
+}
+
+body.tool-focus-mode .tool-column {
   height: calc(100vh - var(--space-20));
+  max-height: calc(100vh - var(--space-20));
+  overflow: auto
+}
+
+body.tool-focus-mode .tool-center-panel {
+  height: 100%;
+  max-height: 100%;
   overflow: auto
 }
 

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -6,9 +6,14 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
+(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(86%) toolbox/colors/colors.js - executed lines 2136/2136; executed functions 183/212
-(92%) assets/theme-v2/js/account-controls.js - executed lines 47/47; executed functions 12/13
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(86%) toolbox/colors/colors.js - executed lines 2147/2147; executed functions 185/214
 
 Guardrail warnings:
+(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/fullscreen-scroll-audit-tags-help-report.md

@@ -0,0 +1,74 @@
+# PR_26159_052 Fullscreen Scroll, Audit Fallback, And Tags Help Report
+
+## Branch Guard
+
+| Check | Status | Evidence |
+| --- | --- | --- |
+| Current branch is `main` before build | PASS | `git branch --show-current` returned `main`. |
+
+## Requirement Checklist
+
+| Requirement | Status | Evidence |
+| --- | --- | --- |
+| Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` first | PASS | Read before edits and before branch validation. |
+| Hard stop if current branch is not `main` | PASS | Branch was `main`; build continued. |
+| Fix fullscreen center-column scrollbar overflow globally | PASS | `assets/theme-v2/css/layout.css` now lets the center panel use its assigned grid-row height instead of a full viewport height. |
+| Apply fullscreen fix as shared Theme V2/tool shell behavior | PASS | Only shared `layout.css` changed for fullscreen layout; no per-tool fullscreen patch. |
+| Center column stays within viewport in fullscreen | PASS | `ToolCenterFullscreenAccordion.spec.mjs` and `ToolDisplayModeNavigation.spec.mjs` assert center bottom is within `window.innerHeight`. |
+| Left, center, and right columns scroll inside available viewport area | PASS | Fullscreen Playwright assertions check left/center/right overflow behavior and viewport bounds. |
+| No page body overflow required in fullscreen | PASS | Fullscreen Playwright assertions check `body` overflow is hidden and document overflow is within tolerance. |
+| Preserve H2/description hidden behavior from PR_26159_051 | PASS | `ToolDisplayModeNavigation.spec.mjs` still asserts center H2/description hide in fullscreen and restore on exit. |
+| Investigate seed-only audit fallback startup messages | PASS | Root cause identified in `mock-db-store.js` fallback normalization plus server snapshot rows missing explicit audit fields. |
+| Remove silent audit fallback behavior | PASS | Removed `allowSeedAuditFallback`, `seedFallbackContext`, and `seed-only audit fallback` handling from active dev-runtime source. |
+| Seed/snapshot records have explicit valid audit ownership | PASS | `palette-source-mock-db.js` now emits audit fields; `mock-api-router.mjs` maps workspace/design/config snapshots with explicit `createdBy`/`updatedBy`. |
+| Missing audit ownership fails visibly/actionably | PASS | `AdminDbViewer.spec.mjs` asserts missing audit ownership throws `Add explicit createdBy and updatedBy values...`; invalid persisted audit users still show DB Viewer diagnostics. |
+| Fix listed startup warnings | PASS | Listed tables now normalize without fallback warnings: `palette_source_swatches`, `workspace_projects`, `workspace_progress`, `game_design_documents`, `game_configuration_validation_items`, `game_configuration_records`. |
+| Add Colors `?` help control beside Tags input | PASS | `toolbox/colors/index.html` adds a Theme V2 `details` help control beside `paletteTagsInput`. |
+| Help control shows full `SUGGESTED_TAGS` list | PASS | `colors.js` renders `SUGGESTED_TAGS` into `[data-palette-tags-help-list]`; Playwright asserts 64 suggestions including `UI` and `16-Bit`. |
+| Suggested tags are not activated unless selected/added | PASS | Playwright opens help and asserts tag filter count is unchanged before explicit tag input. |
+| Preserve typeahead behavior | PASS | Existing typeahead assertion for `Player` still passes in `PaletteToolMockRepository.spec.mjs`. |
+| No inline style/script/event handlers added | PASS | `rg --pcre2` scan for inline script/style/event handlers returned no matches in changed active files. |
+| No console errors | PASS | Targeted Playwright lanes collect browser console errors and passed. |
+| Playwright impacted | PASS | Targeted Colors, Admin DB Viewer, Tool Display Mode, and Tool Center Fullscreen lanes passed. |
+
+## Fallback Root Cause
+
+`src/dev-runtime/persistence/mock-db-store.js` still supported a seed-only fallback path that silently replaced missing or invalid `createdBy`/`updatedBy` values with `forge-bot` when callers passed `allowSeedAuditFallback`. Server snapshot adapters in `src/dev-runtime/server/mock-api-router.mjs` were using that option because several translated tool tables did not provide explicit audit fields.
+
+The noisy startup warnings were the visible symptom:
+
+- `palette_source_swatches createdBy/updatedBy`: palette source seed rows lacked audit ownership before DB normalization.
+- `workspace_projects createdBy/updatedBy`: workspace snapshot rows were mapped from project repository records without audit ownership.
+- `workspace_progress createdBy/updatedBy`: generated progress snapshot row lacked audit ownership.
+- `game_design_documents createdBy/updatedBy`: game design document snapshots relied on fallback ownership.
+- `game_configuration_validation_items createdBy/updatedBy`: generated validation rows lacked audit ownership.
+- `game_configuration_records createdBy/updatedBy`: configuration snapshot rows relied on fallback ownership.
+
+Fixes:
+
+- Removed the fallback branch from `normalizeUserKey` so missing audit ownership throws an actionable error.
+- Removed fallback options from seed and server snapshot normalization.
+- Added explicit forge-bot audit fields to palette source seed rows.
+- Added explicit user/forge-bot ownership when server snapshots translate workspace, game design, game configuration, and invalid palette source diagnostic rows.
+
+## Validation Evidence
+
+| Lane | Status | Evidence |
+| --- | --- | --- |
+| Changed JS syntax | PASS | `node --check` passed for changed runtime/test JS files. |
+| Audit smoke | PASS | Node API/repository smoke printed `audit-smoke-pass`; no `seed-only audit fallback` output. |
+| Fullscreen tool shell | PASS | `npx playwright test tests/playwright/tools/ToolCenterFullscreenAccordion.spec.mjs tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs` -> 6 passed. |
+| Colors runtime/tags | PASS | `npx playwright test tests/playwright/tools/PaletteToolMockRepository.spec.mjs -g "Colors adds\|Palette Tool batch tags"` -> 2 passed. |
+| DB Viewer audit normalization | PASS | `npx playwright test tests/playwright/tools/AdminDbViewer.spec.mjs -g "Local Mem DB audit normalization\|Palette and Asset raw Local Mem DB tables"` -> 2 passed. |
+| DB Viewer live Local Mem snapshot | PASS | `npx playwright test tests/playwright/tools/AdminDbViewer.spec.mjs -g "Admin DB Viewer shows current read-only Local Mem"` -> 1 passed. |
+| DB Viewer invalid audit diagnostic | PASS | `npx playwright test tests/playwright/tools/AdminDbViewer.spec.mjs -g "invalid persisted audit users"` -> 1 passed. |
+| Combined impacted Playwright pass | PASS | `npx playwright test tests/playwright/tools/ToolCenterFullscreenAccordion.spec.mjs tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs tests/playwright/tools/PaletteToolMockRepository.spec.mjs tests/playwright/tools/AdminDbViewer.spec.mjs` -> 22 passed. |
+| Playwright V8 coverage | PASS | `docs_build/dev/reports/playwright_v8_coverage_report.txt` includes `toolbox/colors/colors.js` at 86%; dev-runtime server files are server-side and reported as advisory browser coverage warnings. |
+| Static fallback string check | PASS | `rg` for `seed-only audit fallback`, `allowSeedAuditFallback`, and `seedFallbackContext` returned no matches in active source/tests. |
+| Static inline check | PASS | `rg --pcre2` inline script/style/event handler scan returned no matches in changed active files. |
+| Diff whitespace | PASS | `git diff --check` passed with line-ending warnings only. |
+
+## Skipped Lanes
+
+- Full samples validation: skipped per request.
+- Broad repo-wide Playwright: skipped because this PR touched shared tool fullscreen CSS, Colors tag UI, and dev-runtime audit normalization; targeted lanes covered those exact surfaces.

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -17,26 +17,35 @@ Exercised tool entry points detected:
 (77%) Theme V2 Shared JS - exercised 3 runtime JS files
 
 Changed runtime JS files covered:
+(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(86%) toolbox/colors/colors.js - executed lines 2136/2136; executed functions 183/212
-(92%) assets/theme-v2/js/account-controls.js - executed lines 47/47; executed functions 12/13
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(86%) toolbox/colors/colors.js - executed lines 2147/2147; executed functions 185/214
 
 Files with executed line/function counts where available:
 (58%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 11/19
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 9/14
 (76%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 525/525; executed functions 35/46
 (78%) toolbox/tool-registry-api-client.js - executed lines 148/148; executed functions 21/27
-(86%) toolbox/colors/colors.js - executed lines 2136/2136; executed functions 183/212
+(86%) toolbox/colors/colors.js - executed lines 2147/2147; executed functions 185/214
 (92%) assets/theme-v2/js/account-controls.js - executed lines 47/47; executed functions 12/13
 (100%) toolbox/colors/palette-api-client.js - executed lines 19/19; executed functions 4/4
 
 Uncovered or low-coverage changed JS files:
+(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
+(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/playwright/tools/AdminDbViewer.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/GameConfigurationMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/PaletteToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/playwright/tools/ToolCenterFullscreenAccordion.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs - changed JS file not collected as browser runtime coverage
 (86%) toolbox/colors/colors.js - changed JS file with browser V8 coverage
-(92%) assets/theme-v2/js/account-controls.js - changed JS file with browser V8 coverage

src/dev-runtime/guest-seeds/palette-source-mock-db.js

@@ -1,3 +1,8 @@
+import {
+  MOCK_DB_KEYS,
+  createMockDbAuditFields
+} from "../persistence/mock-db-store.js";
+
 const MOCK_DB_SOURCE_GROUPS = Object.freeze([
   {
     label: "8-color set",
@@ -917,7 +922,9 @@ function tagForLabel(label) {
 }
 
 export function createPaletteSourceMockDbRows() {
+  let auditIndex = 0;
   return MOCK_DB_SOURCE_GROUPS.flatMap((definition) => definition.swatches.map(([hex, name], index) => ({
+    ...createMockDbAuditFields(auditIndex += 1, MOCK_DB_KEYS.users.forgeBot),
     hex,
     id: `${definition.source}-source-swatch-${index + 1}`,
     name,

src/dev-runtime/persistence/mock-db-store.js

@@ -457,37 +457,13 @@ export function setMockDbSessionUser(userKey, options = {}) {
   return clone(sessionUser);
 }
 
-function defaultAuditUserKey(options = {}) {
-  return options.userKey || MOCK_DB_SYSTEM_USER.userKey;
-}
-
-const seedFallbackDiagnostics = new Set();
-
-function emitSeedAuditFallbackDiagnostic(message, options = {}) {
-  if (Array.isArray(options.diagnostics)) {
-    options.diagnostics.push(message);
-  }
-  if (typeof console !== "undefined" && !seedFallbackDiagnostics.has(message)) {
-    seedFallbackDiagnostics.add(message);
-    console.warn(message);
-  }
-}
-
 function normalizeUserKey(value, fieldName, options = {}) {
   const key = String(value || "");
   if (isUlidKey(key)) {
     return key;
   }
-  if (options.allowSeedAuditFallback && isUlidKey(options.fallbackUserKey)) {
-    const context = options.seedFallbackContext || `${options.ownerId || "mock DB"} seed normalization`;
-    emitSeedAuditFallbackDiagnostic(
-      `${context}: ${options.tableName || "record"} ${fieldName} used seed-only audit fallback.`,
-      options,
-    );
-    return options.fallbackUserKey;
-  }
   throw new Error(
-    `Invalid mock DB audit user key for ${options.tableName || "record"}.${fieldName}: ${key || "(empty)"}.`,
+    `Invalid mock DB audit user key for ${options.tableName || "record"}.${fieldName}: ${key || "(empty)"}. Add explicit createdBy and updatedBy values that reference users.key.`,
   );
 }
 
@@ -520,17 +496,14 @@ function normalizeRecord(tableName, record, index, options = {}) {
     tableName,
     record && typeof record === "object" && !Array.isArray(record) ? record : {},
   );
-  const fallbackUserKey = defaultAuditUserKey(options);
   const createdAt = source.createdAt || timestampForIndex(index);
   const updatedAt = source.updatedAt || createdAt;
   const createdBy = normalizeUserKey(source.createdBy, "createdBy", {
     ...options,
-    fallbackUserKey,
     tableName,
   });
   const updatedBy = normalizeUserKey(source.updatedBy, "updatedBy", {
     ...options,
-    fallbackUserKey: createdBy,
     tableName,
   });
   return {
@@ -586,12 +559,7 @@ function ensureKnownTables(state) {
 
 export function loadMockDbTables(ownerId, seedTables = {}, options = {}) {
   const state = readStoredState(options);
-  const normalizedSeeds = normalizeTables(seedTables, {
-    ...options,
-    allowSeedAuditFallback: true,
-    ownerId,
-    seedFallbackContext: `${ownerId} seed table initialization`,
-  });
+  const normalizedSeeds = normalizeTables(seedTables, { ...options, ownerId });
   const tableNames = Object.keys(normalizedSeeds);
   const persisted = tableNames.some((tableName) => Object.hasOwn(state.tables, tableName));
   let changed = false;
@@ -671,11 +639,7 @@ export function clearMockDbTables(options = {}) {
 export function seedMockDbTables(options = {}) {
   const state = emptyState();
   Object.entries(getStandaloneMockDbSeedTables()).forEach(([tableName, rows]) => {
-    state.tables[tableName] = normalizeTableRows(tableName, rows, {
-      ...options,
-      allowSeedAuditFallback: true,
-      seedFallbackContext: "standalone seed table initialization",
-    });
+    state.tables[tableName] = normalizeTableRows(tableName, rows, options);
     state.owners[tableName] = "standalone";
   });
   writeStoredState(state, options);