|
1 | | -diff --git a/docs_build/dev/PROJECT_INSTRUCTIONS.md b/docs_build/dev/PROJECT_INSTRUCTIONS.md |
2 | | -index 8ec5d3681..6a2014f2f 100644 |
3 | | ---- a/docs_build/dev/PROJECT_INSTRUCTIONS.md |
4 | | -+++ b/docs_build/dev/PROJECT_INSTRUCTIONS.md |
5 | | -@@ -1660,6 +1660,81 @@ For tools that present Summary Table or Notes Table note-management surfaces: |
6 | | - - System-created notes may only have status changed when the tool explicitly allows status editing. |
7 | | - - Selected Note Metadata must be shown as table columns, not as a separate detached panel. |
8 | | - |
9 | | -+## TABLE-FIRST WORKSPACE GOVERNANCE |
10 | | -+ |
11 | | -+Primary tool work surfaces must be table-first unless a PR explicitly approves another interaction model. |
12 | | -+ |
13 | | -+Rules: |
14 | | -+- The primary work surface is a table. |
15 | | -+- Prefer inline table workflows over forms. |
16 | | -+- No detached selected-item context panels. |
17 | | -+- No detached notes/detail panels when child rows can render under the parent row. |
18 | | -+- Parent name cells own accordion behavior. |
19 | | -+- The chevron appears inside the parent name cell. |
20 | | -+- The entire parent name cell toggles expansion. |
21 | | -+- Child count columns are informational only. |
22 | | -+- Only one parent row may be expanded at a time. |
23 | | -+- The default state is all collapsed. |
24 | | -+- Child rows are indented. |
25 | | -+- The child Add button aligns with child rows. |
26 | | -+- Metadata remains stored but hidden unless explicitly needed. |
27 | | -+- Add buttons are left aligned and self-describing. |
28 | | -+- Enumerated fields become dropdowns during edit mode. |
29 | | -+ |
30 | | -+Parent/child table pattern examples: |
31 | | -+- Idea 1-* Notes |
32 | | -+- Character 1-* Dialog |
33 | | -+- Quest 1-* Objectives |
34 | | -+- Audio Profile 1-* Effects |
35 | | -+ |
36 | | -+Visual examples: |
37 | | -+ |
38 | | -+1. Default collapsed table. |
39 | | -+ |
40 | | -+| Idea | Pitch | Status | Updated | Notes | Actions | |
41 | | -+| --- | --- | --- | --- | --- | --- | |
42 | | -+| > Sky Orchard | Grow floating islands... | Exploring | 2026-06-20 | 3 Notes | Edit Delete | |
43 | | -+| > Clockwork Courier | Deliver messages through looping city... | New | 2026-06-20 | 0 Notes | Edit Delete | |
44 | | -+| Add Idea | | | | | | |
45 | | -+ |
46 | | -+2. Expanded parent with child rows indented. |
47 | | -+ |
48 | | -+| Idea | Pitch | Status | Updated | Notes | Actions | |
49 | | -+| --- | --- | --- | --- | --- | --- | |
50 | | -+| v Sky Orchard | Grow floating islands... | Exploring | 2026-06-20 | 3 Notes | Edit Delete | |
51 | | -+| Note | Actions | | | | | |
52 | | -+| Wind test needs traversal risks. | Edit Delete | | | | | |
53 | | -+| Island height should read from camera. | Edit Delete | | | | | |
54 | | -+| Add Note | | | | | | |
55 | | -+ |
56 | | -+3. Normal row with Edit/Delete. |
57 | | -+ |
58 | | -+| Idea | Pitch | Status | Updated | Notes | Actions | |
59 | | -+| --- | --- | --- | --- | --- | --- | |
60 | | -+| > Sky Orchard | Grow floating islands... | Exploring | 2026-06-20 | 3 Notes | Edit Delete | |
61 | | -+ |
62 | | -+4. Edit row with Save/Cancel and dropdown status. |
63 | | -+ |
64 | | -+| Idea | Pitch | Status | Updated | Notes | Actions | |
65 | | -+| --- | --- | --- | --- | --- | --- | |
66 | | -+| [Sky Orchard] | [Grow floating islands...] | [Exploring v] | 2026-06-20 | 3 Notes | Save Cancel | |
67 | | -+ |
68 | | -+5. Add row with Save/Cancel. |
69 | | -+ |
70 | | -+| Idea | Pitch | Status | Updated | Notes | Actions | |
71 | | -+| --- | --- | --- | --- | --- | --- | |
72 | | -+| [New idea] | [Pitch] | [New v] | auto | 0 Notes | Save Cancel | |
73 | | -+ |
74 | | -+Explicit row-state rules: |
75 | | -+- Normal row actions: Edit Delete. |
76 | | -+- Edit row actions: Save Cancel. |
77 | | -+- Add row actions: Save Cancel. |
78 | | -+- Save/Cancel is row-level only. |
79 | | -+- No page-level Save for normal row editing. |
80 | | -+- Cancel restores previous row state. |
81 | | -+- Save commits only the edited row. |
82 | | -+- Multiple simultaneous row edits are prohibited unless explicitly approved. |
83 | | -+ |
84 | | - ## INPUT RESOLUTION RULES |
85 | | - |
86 | | - - Discover real files and directories. |
87 | | -diff --git a/docs_build/dev/reports/codex_changed_files.txt b/docs_build/dev/reports/codex_changed_files.txt |
88 | | -index ac3c628b0..4a954a997 100644 |
| 1 | +diff --git a/docs_build/dev/reports/codex_changed_files.txt b/docs_build/dev/reports/codex_changed_files.txt |
| 2 | +index 3c2821db9..105ba5ca3 100644 |
89 | 3 | --- a/docs_build/dev/reports/codex_changed_files.txt |
90 | 4 | +++ b/docs_build/dev/reports/codex_changed_files.txt |
91 | | -@@ -1,52 +1,57 @@ |
92 | | --# Codex Changed Files - PR_26171_033-idea-board-inline-accordion-cell |
93 | | -+# Codex Changed Files - PR_26171_039-table-first-workspace-governance |
94 | | - |
95 | | - ## Git Workflow |
96 | | --- Current branch: `codex/pr-26171-033-idea-board-inline-accordion-cell`. |
97 | | -+- Current branch: `codex/pr-26171-039-table-first-workspace-governance`. |
98 | | - - Expected starting branch: `main` (PASS before branch creation). |
99 | | --- Created branch: `codex/pr-26171-033-idea-board-inline-accordion-cell`. |
100 | | -+- Created branch: `codex/pr-26171-039-table-first-workspace-governance`. |
101 | | - - Push result: pending until after commit. |
102 | | - - PR URL: pending until after push. |
103 | | - - Merge result: pending until after PR validation/merge. |
104 | | - - Final main commit: pending until after merge and final pull. |
105 | | - |
106 | | - ## Changed Files |
107 | | --- assets/theme-v2/images/gfs-chevron-down.svg |
108 | | --- assets/theme-v2/images/gfs-chevron-up.svg |
109 | | --- docs_build/dev/codex_commands.md |
110 | | --- docs_build/dev/commit_comment.txt |
111 | | -+- docs_build/dev/PROJECT_INSTRUCTIONS.md |
112 | | - - docs_build/dev/reports/codex_changed_files.txt |
113 | | - - docs_build/dev/reports/codex_review.diff |
114 | | --- docs_build/dev/reports/coverage_changed_js_guardrail.txt |
115 | | --- docs_build/dev/reports/playwright_v8_coverage_report.txt |
116 | | --- docs_build/pr/APPLY_PR_26171_033-idea-board-inline-accordion-cell.md |
117 | | --- docs_build/pr/BUILD_PR_26171_033-idea-board-inline-accordion-cell.md |
118 | | --- docs_build/pr/PLAN_PR_26171_033-idea-board-inline-accordion-cell.md |
119 | | --- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs |
120 | | --- tests/playwright/tools/ToolboxRoutePages.spec.mjs |
121 | | --- toolbox/idea-board/index.js |
122 | | - |
123 | | - ## Requirement Evidence |
124 | | --- PASS: Separate `>` expand/collapse button removed from `toolbox/idea-board/index.js`; no `data-idea-board-notes-chevron` control remains. |
125 | | --- PASS: No separate expand/collapse control column was added; the visible Idea table remains Idea, Pitch, Status, Updated, Notes, Actions. |
126 | | --- PASS: Notes count is rendered as a plain informational span and no longer carries `data-idea-board-toggle-notes`. |
127 | | --- PASS: Chevron image is rendered inside the Idea row header cell. |
128 | | --- PASS: Collapsed rows use `assets/theme-v2/images/gfs-chevron-down.svg`. |
129 | | --- PASS: Expanded rows use `assets/theme-v2/images/gfs-chevron-up.svg`. |
130 | | --- PASS: The whole Idea cell carries the toggle target and handles click plus Enter/Space keyboard activation. |
131 | | --- PASS: Expanded notes continue to render directly under the owning idea row. |
132 | | --- PASS: Targeted Playwright verifies clicking Notes count does not expand from a collapsed state. |
133 | | --- PASS: Targeted Playwright verifies clicking Notes count does not collapse from an expanded state. |
134 | | --- PASS: Targeted Playwright verifies clicking the Idea cell expands/collapses and the chevron switches down/up. |
135 | | --- PASS: Theme V2 chevron SVG assets were added under `assets/theme-v2/images/`. |
136 | | -+- PASS: Added `TABLE-FIRST WORKSPACE GOVERNANCE` section to `docs_build/dev/PROJECT_INSTRUCTIONS.md`. |
137 | | -+- PASS: Section states primary work surface is a table. |
138 | | -+- PASS: Section says to prefer inline table workflows over forms. |
139 | | -+- PASS: Section prohibits detached selected-item context panels. |
140 | | -+- PASS: Section prohibits detached notes/detail panels when child rows can render under the parent row. |
141 | | -+- PASS: Parent/child patterns include Idea 1-* Notes, Character 1-* Dialog, Quest 1-* Objectives, and Audio Profile 1-* Effects. |
142 | | -+- PASS: Section says parent name cell owns accordion behavior. |
143 | | -+- PASS: Section says chevron appears inside parent name cell. |
144 | | -+- PASS: Section says entire parent name cell toggles expansion. |
145 | | -+- PASS: Section says child count columns are informational only. |
146 | | -+- PASS: Section says only one parent row may be expanded at a time. |
147 | | -+- PASS: Section says default state is all collapsed. |
148 | | -+- PASS: Section says child rows are indented. |
149 | | -+- PASS: Section says child Add button aligns with child rows. |
150 | | -+- PASS: Section says metadata remains stored but hidden unless explicitly needed. |
151 | | -+- PASS: Section says Add buttons are left aligned and self-describing. |
152 | | -+- PASS: Section says enumerated fields become dropdowns during edit mode. |
153 | | -+- PASS: Visual examples include default collapsed table, expanded parent with indented child rows, normal Edit/Delete row, edit Save/Cancel row with dropdown status, and add Save/Cancel row. |
154 | | -+- PASS: Explicit row-state rules include Normal row actions: Edit Delete. |
155 | | -+- PASS: Explicit row-state rules include Edit row actions: Save Cancel. |
156 | | -+- PASS: Explicit row-state rules include Add row actions: Save Cancel. |
157 | | -+- PASS: Explicit row-state rules state Save/Cancel is row-level only. |
158 | | -+- PASS: Explicit row-state rules prohibit page-level Save for normal row editing. |
159 | | -+- PASS: Explicit row-state rules state Cancel restores previous row state. |
160 | | -+- PASS: Explicit row-state rules state Save commits only the edited row. |
161 | | -+- PASS: Explicit row-state rules prohibit multiple simultaneous row edits unless explicitly approved. |
162 | | -+- PASS: Runtime code was not changed. |
163 | | -+- PASS: Tests were not changed. |
164 | | -+- PASS: Roadmap status was not changed. |
165 | | - |
166 | | - ## Validation |
167 | | --- PASS: `node --check toolbox/idea-board/index.js`. |
168 | | --- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`. |
169 | | --- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`. |
170 | | --- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line` (1 passed). |
171 | | --- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"` (1 passed). |
172 | | --- SKIP: Full samples smoke was not run; it is not in scope for this PR. |
173 | | -+- PASS: `git diff --check`. |
174 | | -+- PASS: Heading confirmation found `## TABLE-FIRST WORKSPACE GOVERNANCE`. |
175 | | -+- PASS: Visual examples confirmation found `Visual examples:` and numbered examples. |
176 | | -+- PASS: Save/Cancel row-state confirmation found edit/add examples and explicit row-state rules. |
177 | | -+- PASS: No Playwright impact; this PR is docs/workflow only. |
| 5 | +@@ -44,4 +44,15 @@ |
178 | 6 |
|
179 | 7 | ## ZIP |
180 | | --- Path: `tmp/PR_26171_033-idea-board-inline-accordion-cell_delta.zip`. |
181 | | -+- Path: `tmp/PR_26171_039-table-first-workspace-governance_delta.zip`. |
182 | | - - Size and contents: reported after final ZIP generation. |
| 8 | + - Path: `tmp/PR_26171_040-idea-board-production-copy-cleanup_delta.zip`. |
| 9 | +-- Size and contents: reported after final ZIP generation. |
| 10 | ++- Size: `86984` bytes before final report refresh; final size reported in the delivery summary. |
| 11 | ++- Contents: |
| 12 | ++ - docs_build/dev/reports/codex_changed_files.txt |
| 13 | ++ - docs_build/dev/reports/codex_review.diff |
| 14 | ++ - docs_build/dev/reports/coverage_changed_js_guardrail.txt |
| 15 | ++ - docs_build/dev/reports/playwright_v8_coverage_report.txt |
| 16 | ++ - src/dev-runtime/server/local-api-router.mjs |
| 17 | ++ - src/shared/toolbox/tool-metadata-inventory.js |
| 18 | ++ - tests/playwright/tools/IdeaBoardTableNotes.spec.mjs |
| 19 | ++ - tests/playwright/tools/ToolboxRoutePages.spec.mjs |
| 20 | ++ - toolbox/idea-board/index.html |
| 21 | ++ - toolbox/idea-board/index.js |
0 commit comments