Skip to content

Commit ae7258c

Browse files
committed
Use the individual commit comment generated for each PR. Do not squash PR_26152_249 through PR_26152_253 into a single commit.
1 parent e4b06fc commit ae7258c

17 files changed

Lines changed: 1234 additions & 146 deletions

GameFoundryStudio/assets/partials/footer.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<section class="footer__group" aria-labelledby="footer-product">
66
<h2 id="footer-product">Product</h2>
77
<div class="footer__links">
8-
<a data-route="tools" href="tools/index.html">Tools</a>
8+
<a data-route="tools" href="tools/index.html">Toolbox</a>
99
<a data-route="games" href="arcade/index.html">Games</a>
1010
<a data-route="marketplace" href="marketplace/index.html">Marketplace</a>
1111
<a data-route="learn" href="learn/index.html">Learn</a>

GameFoundryStudio/assets/partials/header-nav.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
</a>
77
<nav class="nav-links" aria-label="Main navigation">
88
<div class="nav-item">
9-
<a data-nav-link data-route="tools" href="tools/index.html">Tools &#9662;</a>
9+
<a data-nav-link data-route="tools" href="tools/index.html">Toolbox &#9662;</a>
1010
<div class="sub-menu">
1111
<a data-nav-link data-route="ai-assistant" href="tools/ai-assistant.html">AI Assistant</a>
1212
<a data-nav-link data-route="animation-studio" href="tools/animation-studio.html">Animation Studio</a>
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
# PR_26152_252 Engine V2 Dialogue System Validation
2+
3+
Status: PASS
4+
5+
## Scope
6+
7+
- Added manifest-driven NPC dialogue nodes, choices, choice conditions, and action requests.
8+
- Rejected missing dialogue, nodes, choices, malformed definitions, and unmet choice conditions visibly.
9+
- Avoided hard-coded dialogue flow, samples, tools, and UI changes.
10+
11+
## Lanes Executed
12+
13+
- engine: validated the dialogue runtime slice with targeted headless tests.
14+
- static validation: ran syntax checks for the new dialogue module and test.
15+
16+
## Lanes Skipped
17+
18+
- samples: SKIP / permanently out of scope for this stack.
19+
- tool runtime: SKIP / no tool behavior changed.
20+
- browser/UI: SKIP / dialogue system is headless engine runtime.
21+
22+
## Commands
23+
24+
- `node --check src/engine/runtime/engineV2DialogueSystem.js`
25+
- `node --check tests/engine/EngineV2DialogueSystem.test.mjs`
26+
- `node tests/engine/EngineV2DialogueSystem.test.mjs`
27+
28+
## Results
29+
30+
- Syntax checks: PASS.
31+
- Dialogue system test: PASS.
32+
33+
## Manual Validation
34+
35+
- Review `tests/engine/EngineV2DialogueSystem.test.mjs`.
36+
- Confirm dialogue display emits the active node.
37+
- Confirm a valid choice advances state and emits configured action requests.
38+
- Confirm a choice with unmet conditions rejects visibly.
39+
40+
## Blocker Scope
41+
42+
- None found in the targeted dialogue runtime lane.
43+
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
# PR_26152_250 Engine V2 Objective System Validation
2+
3+
Status: PASS
4+
5+
## Scope
6+
7+
- Added manifest-driven objective processing for collect, defeat, reach, survive, timer, score, and interact objectives.
8+
- Rejected invalid objective definitions, missing required runtime score/timer state, missing objective states, and malformed objective events visibly.
9+
- Avoided game-specific objective logic, samples, tools, and UI changes.
10+
11+
## Lanes Executed
12+
13+
- engine: validated the objective runtime slice with targeted headless tests.
14+
- static validation: ran syntax checks for the new objective module and test.
15+
16+
## Lanes Skipped
17+
18+
- samples: SKIP / permanently out of scope for this stack.
19+
- tool runtime: SKIP / no tool behavior changed.
20+
- browser/UI: SKIP / objective system is headless engine runtime.
21+
22+
## Commands
23+
24+
- `node --check src/engine/runtime/engineV2ObjectiveSystem.js`
25+
- `node --check tests/engine/EngineV2ObjectiveSystem.test.mjs`
26+
- `node tests/engine/EngineV2ObjectiveSystem.test.mjs`
27+
28+
## Results
29+
30+
- Syntax checks: PASS.
31+
- Objective system test: PASS.
32+
33+
## Manual Validation
34+
35+
- Review `tests/engine/EngineV2ObjectiveSystem.test.mjs`.
36+
- Confirm all seven objective types complete from manifest-owned definitions, runtime state, and events.
37+
- Confirm invalid objective type and missing score state reject with explicit error codes.
38+
39+
## Blocker Scope
40+
41+
- None found in the targeted objective runtime lane.
42+
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
# PR_26152_253 Engine V2 Player Runtime Closeout
2+
3+
Status: PASS
4+
5+
## Scope
6+
7+
- Closed the player runtime lane for objectives, quests, and dialogue.
8+
- Validated objectives, quests, and dialogue together through the shared player runtime fixture.
9+
- Documented the next Engine V2 slice without starting it.
10+
11+
## Lanes Executed
12+
13+
- engine: ran objective, quest, and dialogue targeted tests.
14+
- closeout: confirmed the three slices compose through shared fixture data.
15+
16+
## Lanes Skipped
17+
18+
- samples: SKIP / permanently out of scope for this stack.
19+
- tool runtime: SKIP / no tool behavior changed.
20+
- browser/UI: SKIP / player runtime closeout is headless engine validation.
21+
22+
## Commands
23+
24+
- `node tests/engine/EngineV2ObjectiveSystem.test.mjs`
25+
- `node tests/engine/EngineV2QuestSystem.test.mjs`
26+
- `node tests/engine/EngineV2DialogueSystem.test.mjs`
27+
28+
## Results
29+
30+
- Objective system test: PASS.
31+
- Quest system test: PASS.
32+
- Dialogue system test: PASS.
33+
34+
## Next Engine V2 Slice
35+
36+
- Recommended next slice: content-facing progression polish for journal/log surfacing, objective/quest event reporting, and player-facing state summaries once the runtime lane explicitly authorizes UI or tool integration.
37+
38+
## Manual Validation
39+
40+
- Review the shared fixture in `tests/engine/EngineV2PlayerRuntimeFixture.mjs`.
41+
- Confirm objective completion feeds quest completion.
42+
- Confirm quest/dialogue action and trigger requests remain data-driven runtime outputs.
43+
44+
## Blocker Scope
45+
46+
- None found in the targeted player runtime closeout lane.
47+
Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
# PR_26152_251 Engine V2 Quest System Validation
2+
3+
Status: PASS
4+
5+
## Scope
6+
7+
- Added manifest-driven quest state processing with quest states, steps, prerequisites, rewards, and completion.
8+
- Integrated quest completion with objective state, inventory reward requests, economy/currency reward requests, and trigger requests.
9+
- Avoided game-specific quest logic, samples, tools, and UI changes.
10+
11+
## Lanes Executed
12+
13+
- engine: validated the quest runtime slice with targeted headless tests.
14+
- dependent engine: used the objective system fixture output to validate quest step completion.
15+
- static validation: ran syntax checks for the new quest module and test.
16+
17+
## Lanes Skipped
18+
19+
- samples: SKIP / permanently out of scope for this stack.
20+
- tool runtime: SKIP / no tool behavior changed.
21+
- browser/UI: SKIP / quest system is headless engine runtime.
22+
23+
## Commands
24+
25+
- `node --check src/engine/runtime/engineV2QuestSystem.js`
26+
- `node --check tests/engine/EngineV2QuestSystem.test.mjs`
27+
- `node tests/engine/EngineV2QuestSystem.test.mjs`
28+
29+
## Results
30+
31+
- Syntax checks: PASS.
32+
- Quest system test: PASS.
33+
34+
## Manual Validation
35+
36+
- Review `tests/engine/EngineV2QuestSystem.test.mjs`.
37+
- Confirm completed objectives complete the tutorial quest.
38+
- Confirm inventory, economy, and trigger outputs are emitted as requests rather than hard-coded game behavior.
39+
- Confirm a quest step pointing to a missing objective rejects visibly.
40+
41+
## Blocker Scope
42+
43+
- None found in the targeted quest runtime lane.
44+
Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
# PR_26152_249 Toolbox Menu IA Validation
2+
3+
Status: PASS
4+
5+
## Scope
6+
7+
- Changed user-facing Tools labels to Toolbox in the root GameFoundryStudio navigation and footer.
8+
- Added Toolbox group structure on the root Tools index without renaming internal `tools/` paths, toolState names, registry names, or technical contract names.
9+
- Preserved existing tool links and root public Tools index behavior.
10+
11+
## Toolbox IA
12+
13+
- Objects: Vector, Sprite, Animated Sprite, UI
14+
- Worlds: Vector, Tilemap, Isometric, Hybrid
15+
- Audio
16+
- Input
17+
- AI
18+
- Colors
19+
- Assets
20+
21+
## Lanes Executed
22+
23+
- navigation/UI: updated visible navigation labels and Tools index grouping data.
24+
- workspace-contract: ran targeted Toolbox/navigation Playwright grep.
25+
- static validation: ran `git diff --check`.
26+
27+
## Lanes Skipped
28+
29+
- engine: no engine files changed in PR_26152_249.
30+
- samples: SKIP / permanently out of scope for this stack.
31+
- tool rebuild: SKIP / not requested.
32+
- runtime tool validation: SKIP / no individual tool runtime behavior changed.
33+
34+
## Commands
35+
36+
- `git diff --check`
37+
- `npm run test:workspace-v2 -- --grep "navigation|toolbox"`
38+
39+
## Results
40+
41+
- `git diff --check`: PASS with line-ending warnings only.
42+
- `npm run test:workspace-v2 -- --grep "navigation|toolbox"`: PASS, 1 Playwright test passed.
43+
44+
## Manual Validation
45+
46+
- Open `tools/index.html`.
47+
- Confirm the top navigation and footer show Toolbox as the user-facing label.
48+
- Switch the Tools index grouping control to grouped mode.
49+
- Confirm top-level groups match Objects, Worlds, Audio, Input, AI, Colors, and Assets.
50+
- Confirm Objects and Worlds cards show the requested nested labels.
51+
52+
## Blocker Scope
53+
54+
- None found in the targeted Toolbox IA lane.
55+

0 commit comments

Comments
 (0)